Keyboard Navigation - translatability

Bug #623224 reported by Andrew Nicols
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
Low
Andrew Nicols

Bug Description

Bug #623105 just reminded me about the keyboard navigation javascript (htdocs/js/keyboardNavigation.js)

Originally, I was going to just add a link for /C/ollection and P/l/ans, but I'm not so sure having had another look I think it needs more thought:
* p is already taken for the Profile page, so the shortcut for Plans becomes a bit sucky (l?);
* Do we perhaps need to make this more translatable? The letter x may not even appear in the $language equivelant for $word.

We could generate the js file with some php, perhaps hooking into the various language strings, but this does seem a little bloaty.

Any opinions or should I stop thinking so hard and just make the changes?

summary: - Add keyboard navigation for collections, plans, etc
+ Keyboard Navigation - translatability
Revision history for this message
Richard Mansfield (richard-mansfield) wrote :

+1 for just making the changes

Revision history for this message
Andrew Nicols (dobedobedoh) wrote :

Okay. I've made the changed:
Collections = gc
Plans = gl

Changed in mahara:
assignee: nobody → Andrew Robert Nicols (dobedobedoh)
status: New → Fix Committed
Changed in mahara:
milestone: none → 1.4.0
status: Fix Committed → Fix Released
importance: Undecided → Low
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.