FF 3.0 errors on master.dev

[Kristina Hoeppner]

Hi Richard,

We've had a tester using FF 3.0.11 on master.dev and he ran across the following error messages while trying to log on. Initially, he could not get to the login page at all (possibly Firewall problem on top of FF 3.0), but even from outside of the firewall, he had problems.

Kristina

---------------

Error: missing } after function body
Source File: http://master.dev.mahara.org/js/MochiKit/Packed.js
Line: 873, Column: 49
Source Code:
var data=MochiKit.Base.flattenArguments(arguments)

Error: addLoadEvent is not defined
Source File: http://master.dev.mahara.org/js/keyboardNavigation.js
Line: 24

Error: addLoadEvent is not defined
Source File: http://master.dev.mahara.org/js/mahara.js
Line: 303

Error: getFirstElementByTagAndClassName is not defined
Source File:
http://master.dev.mahara.org/lib/pieforms/static/core/pieforms.js
Line: 110

Error: createDOM is not defined
Source File: http://master.dev.mahara.org/js/css.js
Line: 24

Error: $ is not defined
Source File: http://master.dev.mahara.org/
Line: 175

[Richard Mansfield (richard-mansfield)]

It looks like that javascript file http://master.dev.mahara.org/js/MochiKit/Packed.js is not being parsed properly by the browser for some reason.

I don't currently have that version of FF available to test, but I used to use versions of FF3.0 all the time with the same version of MochiKit, so I'd be surprised if it was something in that file causing the problem.

However it might be useful if that user could request the javascript directly (http://master.dev.mahara.org/js/keyboardNavigation.js) and send me the resulting page.

Google reveals nothing either I'm afraid.

[Kristina Hoeppner (kris-hoeppner)]

Here's the output:

-----------------------

---------------
/**
* Adds keystroke navigation to Mahara.
* @source: http://gitorious.org/mahara/mahara
*
* @licstart
* Copyright (C) 2006-2010 Catalyst IT Ltd
*
* The JavaScript code in this page is free software: you can
* redistribute it and/or modify it under the terms of the GNU
* General Public License (GNU GPL) as published by the Free Software
* Foundation, either version 3 of the License, or (at your option)
* any later version. The code is distributed WITHOUT ANY WARRANTY;
* without even the implied warranty of MERCHANTABILITY or FITNESS
* FOR A PARTICULAR PURPOSE. See the GNU GPL for more details.
*
* As additional permission under GNU GPL version 3 section 7, you
* may distribute non-source (e.g., minimized or compacted) forms of
* that code without the copy of the GNU GPL normally required by
* section 4, provided you include this license notice and a URL
* through which recipients can access the Corresponding Source.
* @licend
*/

addLoadEvent(function() {
   connect(window,'onkeypress',function(e) {
       var targetType = e.target().nodeName;

       if (
           targetType == 'INPUT'
           || targetType == 'TEXTAREA'
           || targetType == 'SELECT'
           || targetType == 'BUTTON'
       ) {
           return;
       }

       if (config.commandMode) {
           switch(e.key().string) {
               case 'a':
                   document.location.href = config.wwwroot + 'admin/';
                   break;
               case 'h':
                   document.location.href = config.wwwroot;
                   break;
               case 'b':
                   document.location.href = config.wwwroot +
'artefact/blog/';
                   break;
               case 'p':
                   document.location.href = config.wwwroot +
'artefact/internal/';
                   break;
               case 'f':
                   document.location.href = config.wwwroot +
'artefact/file/';
                   break;
               case 'g':
                   document.location.href = config.wwwroot +
'group/mygroups.php';
                   break;
               case 'v':
                   document.location.href = config.wwwroot + 'view';
                   break;
               case '/':
                   document.usf.query.focus();
                   break;
           }
           config.commandMode = false;
       }
       else {
           if (e.key().string == 'g') {
               config.commandMode = true;
           }
       }
   });
});

[Richard Mansfield (richard-mansfield)]

Oops, I realise I asked for the output of keyboardNavigation.js, but I meant MochiKit/Packed.js:
http://master.dev.mahara.org/js/MochiKit/Packed.js
Sorry about that.

I actually doubt it's the problem anyway unless for some reason the browser isn't reading the whole file.

[Richard Mansfield (richard-mansfield)]

It might be a bit too long to paste in here too; probably best to send it in an email.

[Kristina Hoeppner (kris-hoeppner)]

I attached the output file.

[Richard Mansfield (richard-mansfield)]

It looks like the whole file is there, so there goes that theory.

Does the error happen as soon as the user submits the login form on the front page, or is it when the next page loads? Is it only on master.dev.mahara.org or does it also happen on other Mahara sites like demo.mahara.org? Does it happen reliably every time he logs in, or is it intermittent?

[Richard Mansfield (richard-mansfield)]

I've been able to try out two older versions of firefox on Windows (2.0.0.20 and 3.0.19), but I'm still unable to reproduce the error -- I can log into master.dev.mahara.org using both.

[Launchpad Janitor (janitor)]

[Expired for Mahara because there has been no activity for 60 days.]