Please merge radare 1:1.5.2-2 (universe) from Debian unstable (main)

[Niall Creech]

Binary package hint: radare

New debian version.

FFE Request:

The new debian 1.5.2-3 release fixes a number of bugs, 2 of the most critical in the current maverick 1.4.1-1ubuntu1 version are,

* buffer overflow on project save, all work is lost
* segmentation fault on right mouse button click in main window

These bugs leave the current version mostly unusable

Additional ubuntu change is a change in build-deps from libvala-dev to libvala-0.10-dev

Attached to end of bug report,

* i386 pbuilder build log
* 1.4.1-ubuntu1 to 1.5.2-3ubuntu1 Changelog diff
* 1.5.2-3 to 1.5.2-3ubuntu1 debdiff

New package has been tested with disasembling a simple executable, saving/restoring, general testing of gui options.

*********************** ORIGINAL MESSAGE ************************
Previous ubuntu changes:

radare (1:1.4-1ubuntu1)
  * 10_drop-gtkdialog-usage.dpatch:
    - import radare r1204, r1210, r1211 from mercurial repository to remove
    any use of gtkdialog and so allow dropping all gtkdialog dependencies
    altogether (LP: #530496)
[**THIS CHANGE IS INCLUDED IN NEW DEBIAN VERSION**]

  * Move libreadline5-dev build-dep to libreadline-dev to fix conflict with
    lua5.1
[**THIS CHANGE IS INCLUDED IN NEW DEBIAN VERSION**]

New ubuntu changes:

Debian uses a version of python-all-dev that includes 2.5 and 2.6, ubuntu introduces a change that restricts this to python 2.6 only. These 2 patches adapt radare for that change

* Merge from debian testing (LP: #621016), remaining changes:
     - debian/patches/allow-python26-lua-build:
       + Allow lua.so to build when we only have python 2.6
     - debian/radare-common.install:
       + debian python-all-dev uses 2.5 and 2.6 versions, ubuntu restricts
         this to 2.6 only

Fix dependency on libvala-dev as per libvala-dev -> libvala-0.10-dev transition
https://bugs.edge.launchpad.net/ubuntu/+source/radare/+bug/618809

- debian/control:
       + libvala-dev transition to libval-0.10-dev (LP: #618809)

Test Build:
https://edge.launchpad.net/~sevenmachines/+archive/release+1/+packages

radare (1:1.5.2-2ubuntu1) maverick; urgency=low

   * Merge from debian testing (LP: #621016), remaining changes:
     - debian/patches/allow-python26-lua-build:
       + Allow lua.so to build when we only have python 2.6
     - debian/radare-common.install:
       + debian python-all-dev uses 2.5 and 2.6 versions, ubuntu restricts
         this to 2.6 only
     - debian/control:
       + libvala-dev transition to libval-0.10-dev (LP: #618809)
 -- SevenMachines <email address hidden> Fri, 20 Aug 2010 20:47:14 +0100

[Niall Creech (sevenmachines-deactivatedaccount)]

- debian/patches/python2.6-lua-fix:
       + Allow lua.so to build when we only have python 2.6

[Niall Creech (sevenmachines-deactivatedaccount)]

- debian/patches/restrict-python-version:
       + debian python-all-dev uses 2.5 and 2.6 versions, ubuntu restricts
         this to 2.6 only

[Niall Creech (sevenmachines-deactivatedaccount)]

- debian/patches/versioned-vala-fix
       + libvala-dev transition to libval-0.10-dev

[Niall Creech (sevenmachines-deactivatedaccount)]

attached diff of current maverick 1.4.1-ubuntu1 with proposed 1.5.2-2ubuntu1

[Niall Creech (sevenmachines-deactivatedaccount)]

attached diff of debian sid 1.5.2-2 with proposed 1.5.2-2ubuntu1

[Niall Creech (sevenmachines-deactivatedaccount)]

Test Build:
https://edge.launchpad.net/~sevenmachines/+archive/release+1/+packages

radare (1:1.5.2-2ubuntu1) maverick; urgency=low

   * Merge from debian testing (LP: #621016), remaining changes:
     - debian/patches/allow-python26-lua-build:
       + Allow lua.so to build when we only have python 2.6
     - debian/patches/restrict-python26-fix:
       + debian python-all-dev uses 2.5 and 2.6 versions, ubuntu restricts
         this to 2.6 only
     - debian/patches/versioned-vala
       + libvala-dev transition to libval-0.10-dev (LP: #618809)
 -- SevenMachines <email address hidden> Fri, 20 Aug 2010 09:58:11 +0100

[Stefano Rivera (stefanor)]

Please convert debian-changes-1:1.5.2-2ubuntu1 into a neater, better named, and DEP3-headered quilt patch.

We are in feature freeze. This is a new upstream version. Please file for a freeze exception if necessary https://wiki.ubuntu.com/FreezeExceptionProcess and resubscribe ubuntu-sponsors when it has been obtained..

[Niall Creech (sevenmachines-deactivatedaccount)]

Thanks Stefano. Sorry, I missed feature freeze. Might not be justified for an exception so i might try to fix a couple of bugs upstream and maybe in the current package.

Strangely enough debian-changes-1:1.5.2-2ubuntu1 is auto-generated in debian patches and not created by me, the original debian package comes with debian/patches/debian-changes-1:1.5.2-2 too. I'm not sure where they come from to be honest

[Stefano Rivera (stefanor)]

Considering that the new upstream release fixes bugs, I think you'll get an exception. Request one, the relaese team is quite quick.

[Niall Creech (sevenmachines-deactivatedaccount)]

Ok, will do, theres a buffer overflow in the gui patch that would be needed in both the current and the debian sid versions anyway, i'll redo the package start of next week with that fixed up.

[Niall Creech (sevenmachines-deactivatedaccount)]

I've talked to the debian maintainer Sebastian Reichel and he's looking to fix up the buffer overflow and the python versioning problems in debian so thats probably the better version to merge with when it arrives. that should just leave the libvala-0.10 change which needs to be in ubuntu but can't be applied in debian

[Sebastian Reichel (sre)]

Hi,

I just uploaded 1.5.2-3 to sid, which contains your fixes for the buffer overflow and python versioning. The transition to libvala-0.10 will only happen in Debian when squeeze is out, since squeeze is supposed to be delivered with the vala 0.8.x branch.

http://packages.qa.debian.org/r/radare/news/20100822T154718Z.html

-- Sebastian

[Niall Creech (sevenmachines-deactivatedaccount)]

test build:
https://edge.launchpad.net/~sevenmachines/+archive/release+1/+packages

radare (1:1.5.2-3ubuntu1) maverick; urgency=low

  * Merge from debian testing (LP: #621016)
  * debian/control:
       + libvala-dev transition to libval-0.10-dev (LP: #618809)

 -- SevenMachines <email address hidden> Wed, 25 Aug 2010 09:48:48 +0100

[Niall Creech (sevenmachines-deactivatedaccount)]

* dpkg install log

$ sudo dpkg -i radare-*
Selecting previously deselected package radare-common.
(Reading database ... 296224 files and directories currently installed.)
Unpacking radare-common (from radare-common_1.5.2-3ubuntu1_i386.deb) ...
Selecting previously deselected package radare-doc.
Unpacking radare-doc (from radare-doc_1.5.2-3ubuntu1_all.deb) ...
Selecting previously deselected package radare-gtk.
Unpacking radare-gtk (from radare-gtk_1.5.2-3ubuntu1_i386.deb) ...
Setting up radare-common (1:1.5.2-3ubuntu1) ...
Setting up radare-doc (1:1.5.2-3ubuntu1) ...
Processing triggers for man-db ...
Setting up radare-gtk (1:1.5.2-3ubuntu1) ...
Processing triggers for menu ...
Processing triggers for python-support ...

[StefanPotyra (sistpoty)]

ACK to merge 1:1.5.2-3, please go ahead.

[Launchpad Janitor (janitor)]

This bug was fixed in the package radare - 1:1.5.2-3ubuntu1

---------------
radare (1:1.5.2-3ubuntu1) maverick; urgency=low

  * Merge from debian testing (LP: #621016)
  * debian/control:
       + libvala-dev transition to libval-0.10-dev (LP: #618809)

radare (1:1.5.2-3) unstable; urgency=low

  * Update Debian Standards Version to 3.9.1
  * Add patch to always link against libdl,
    this fixes an FTBFS on kfreebsd and hurd
  * add Ubuntu patch to fix buffer overflow
  * add Ubuntu patch to fix building if only python2.6 is available

radare (1:1.5.2-2) unstable; urgency=low

  * cherry pick upstream patch to fix disabled debugger.
    This should fix build on arches not supported by radare debugger.
  * Add patch improving Makefile's clean target
  * Allow DM Upload

radare (1:1.5.2-1) unstable; urgency=low

  * New upstream release
   - drop gtkdialog (Closes: #583888, #560676)
   - lua plugin should build on all arches (Closes: #544829)
   - many upstream bug fixes (Closes: #534700)
   - bashism has been fixed upstream (Closes: #535884)
  * Build-depend on libreadline-dev (Closes: #553833)
  * byte-compile Python files (Closes: #566048)
  * Remove ruby, does not work currently
  * Add watch file for -free version (DFSG compatible source tarball)
  * Switch to DebSrc 3.0
 -- SevenMachines <email address hidden> Tue, 07 Sep 2010 15:44:27 +0200