CredentialsError shouldn't be sent if user doesn't close the window
Bug #620008 reported by
Natalia Bidart
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Ubuntu Single Sign On Client |
Fix Released
|
High
|
Natalia Bidart | ||
ubuntu-sso-client (Ubuntu) |
Fix Released
|
High
|
Ubuntu One Client Engineering team |
Bug Description
The GTK signals from the GUI must sent at closing time.
Related branches
lp:~nataliabidart/ubuntu-sso-client/signal-when-window-closed
- Rodrigo Moya (community): Approve
- John Lenton (community): Approve
-
Diff: 276 lines (+118/-50)2 files modifiedubuntu_sso/gui.py (+14/-7)
ubuntu_sso/tests/test_gui.py (+104/-43)
Changed in ubuntu-sso-client: | |
status: | New → Confirmed |
importance: | Undecided → High |
tags: | added: u1-natty |
tags: | removed: u1-natty |
tags: | added: u1-maverick |
tags: | added: ubuntu-10.10-beta |
Changed in ubuntu-sso-client (Ubuntu): | |
status: | New → Triaged |
importance: | Undecided → High |
assignee: | nobody → Ubuntu One Desktop+ team (ubuntuone-desktop+) |
Changed in ubuntu-sso-client: | |
assignee: | nobody → Naty Bidart (nataliabidart) |
Changed in ubuntu-sso-client (Ubuntu): | |
milestone: | none → ubuntu-10.10-beta |
tags: |
added: desktop+ removed: ubuntu-10.10-beta |
Changed in ubuntu-sso-client: | |
status: | Confirmed → In Progress |
Changed in ubuntu-sso-client: | |
status: | In Progress → Fix Committed |
Changed in ubuntu-sso-client: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
This bug was fixed in the package ubuntu-sso-client - 0.99.2-0ubuntu1
---------------
ubuntu-sso-client (0.99.2-0ubuntu1) maverick; urgency=low
* New upstream release:
[ Natalia Bidart ]
* Ping an URL when the login was successful (LP: #621226).
* Signals propagates the app_name to be later check by the GUI so only those
belonging to it will be processed (LP: #621377).
[ Natalia Bidart ]
* Added modifications to setup.py and a new po/ directory with the file that has
strings that need translation (LP: #616515).
[ Rodrigo Moya ]
* Add clear_token DBus API (LP: #622833).
[ Alejandro J. Cura ]
* Make all the signals return the errors as dictionaries (LP: #616105).
* Credential* signals should return the app_name as well (LP: #621377).
[ Alejandro J. Cura ]
* Use Ubuntu One OAuth credentials if they are already stored in the keyring
(LP: #617355).
[ Natalia Bidart ]
* Final outcome (as signal) is emitted after user closes the main window (LP:
#620008).
-- Natalia Bidart (nessita) <email address hidden> Tue, 24 Aug 2010 12:50:57 -0300