Should Depend: on appropriate xserver-xorg-video-$ABI

Bug #616215 reported by Chris Halse Rogers
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
fglrx-installer (Ubuntu)
Fix Released
Medium
Alberto Milone

Bug Description

Again, same as for nvidia-current.

The dependency system for Xorg changed in 1.7.6.901 (in Debian, 1.8 in Ubuntu). The X server no longer declares a Breaks: against every possible ABI it does not support. Instead, it Provides: a video and input ABI, and drivers are expected to depend on this ABI.

This was also accompanied by a change in where xserver-xorg-core-dev stored its dependency information; it's no longer in /usr/share/xserver-xorg/serverminver.

The relevant fragment from xsfbs.mk is:
# Compute dependencies for drivers
#
VIDEODEP = $(shell cat /usr/share/xserver-xorg/videodrvdep 2>/dev/null)
INPUTDEP = $(shell cat /usr/share/xserver-xorg/xinputdep 2>/dev/null)

# these two can be removed post-squeeze
VIDEOABI = $(shell cat /usr/share/xserver-xorg/videoabiver 2>/dev/null)
INPUTABI = $(shell cat /usr/share/xserver-xorg/inputabiver 2>/dev/null)
VIDDRIVER_PROVIDES = xserver-xorg-video-$(VIDEOABI), xorg-driver-video
INPDRIVER_PROVIDES = xserver-xorg-input-$(INPUTABI), xorg-driver-input

ifeq ($(PACKAGE),)
PACKAGE=$(shell awk '/^Package:/ { print $$2; exit }' < debian/control)
endif

.PHONY: serverabi
serverabi: install
ifeq ($(VIDEODEP),)
        @echo 'error: xserver-xorg-dev >= 1.7.6.901 needs to be installed'
        @exit 1
else
        echo "xviddriver:Depends=$(VIDEODEP)" >> debian/$(PACKAGE).substvars
        echo "xinpdriver:Depends=$(INPUTDEP)" >> debian/$(PACKAGE).substvars
        # the following is there for compatibility...
        echo "xviddriver:Provides=$(VIDDRIVER_PROVIDES)" >> debian/$(PACKAGE).substvars
        echo "xinpdriver:Provides=$(INPDRIVER_PROVIDES)" >> debian/$(PACKAGE).substvars
        echo "xserver:Depends=$(VIDEODEP), $(INPUTDEP)" >> debian/$(PACKAGE).substvars
endif

CVE References

Changed in fglrx-installer (Ubuntu):
status: New → Confirmed
importance: Undecided → Medium
Changed in fglrx-installer (Ubuntu):
assignee: nobody → Alberto Milone (albertomilone)
status: Confirmed → In Progress
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package fglrx-installer - 2:8.780-0ubuntu1

---------------
fglrx-installer (2:8.780-0ubuntu1) maverick; urgency=low

  * New upstream release.
    - Fix build issues with kernel fix for CVE-2010-3081 (LP: #642518).
    - Add compatibility with 2.6.35 kernels (LP: #573748).
    - Add compatibility with xserver 1.9 (LP: #630599).
  * Make the driver Depend on the appropriate xserver-xorg-video-$ABI
    (LP: #616215).
 -- Alberto Milone <email address hidden> Wed, 22 Sep 2010 18:28:32 +0200

Changed in fglrx-installer (Ubuntu):
status: In Progress → Fix Released
Revision history for this message
Alberto Milone (albertomilone) wrote :

Reopening as per Chris' comments on bug #616214

Changed in fglrx-installer (Ubuntu):
status: Fix Released → Confirmed
Changed in fglrx-installer (Ubuntu):
status: Confirmed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.