Show profile icon files in My Files

[Kristina Hoeppner]

Shouldn't the profile icon also sit in "My Files" (maybe in a predefined folder "profile icons")? Somebody may want to use it somewhere else, e.g. a blog post.

(Mahara 1.3; master.dev)

[François Marier (fmarier)]

Sounds like a good idea.

This is related to the suggestion (in bug #605704) of making the contents of certain blocks (e.g. the text block) artefacts.

[Ruslan Kabalin (rkabalin)]

https://reviews.mahara.org/#change,445

[Ruslan Kabalin (rkabalin)]

As I stated in the bug comment, the "profile icons" folder should probably be protected from deletion. If not, then it probably should notify user than the image is in use on the attempt of its deletion (or folder deletion).

[Ruslan Kabalin (rkabalin)]

It also may be confusing for user that the icon title can be changed in the Files section, but not in Profile Images.

What I suggest:
   * "Profile pictures", should remain "profile pictures" - all actions (upload/delete/rename/set default) should be possible to make from "Profile pictures" page (we have a good bug #637026 that may drive this change :). Perhaps we may use modified file browser for that instead of current interface with bigger images, disabled subdirs and "set default" radio.
   * We probably do not need "Profile pictures" folder in the files section, it only causes confusion and make the stuff complicated IMHO. One example of this complication is that it should not be possible to upload non-image in that folder and create subfolders. What we might have instead, is to have "Profile pictures" folder listed in italic in the file selection dialogs only.

[Richard Mansfield (richard-mansfield)]

Ruslan,

I absolutely agree at the very least we need to warn the user before deleting the default profile icon. I also think we should either make the description uneditable in my files, or else make sure that profile icons are clearly displayed differently from ordinary files/images. Probably the former at this stage. I don't have a problem with the user being able to delete & move their profile icons around.

To address your other worries we just need to limit expectations that the 'profile pictures' folder contains all and only profile pictures. I suggested the folder to Eugene, but only as a way to stop automatically created files from cluttering up your root folder. There are some other examples, like 'view files' (created when you copy a view), and 'assessment files' (created when someone attaches a file to feedback on one of your views). So let's just give this folder a more neutral name, like 'Pictures', 'images', 'system', or something. Then people won't make the assumption that moving/uploading an image into that folder will automatically turn it into a profile icon.

Rewriting the profile pictures page to work without js isn't super high priority at this time, so bug #637026 may have to wait a bit...

[Ruslan Kabalin (rkabalin)]

I see your point Richard, OK let it be the way you suggest. But we definitely need a notification when default one is deleted.

[Eugene (eugenev)]

Hi Ruslan and Richard,

Here are the changes I've now made:
* Changed the 'profile icons' folder name to 'images' and updated description
* Made profileicons title italic in filebrowser
* Removed the ability to edit the description of a profile icon file
* Warning on delete of default profileicon

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/534
Committed: http://gitorious.org/mahara/mahara/commit/77e41fb05f39d74a5d0385357991f722d166d995
Submitter: Richard Mansfield (<email address hidden>)
Branch: master

commit 77e41fb05f39d74a5d0385357991f722d166d995
Author: Richard Mansfield <email address hidden>
Date: Fri Jul 29 10:54:53 2011 +1200

    Inform user of profileicon location on upload (bug #605747)

    New profileicons are now added to the user's 'images' folder. The
    user needs to be informed of this when uploading new icons, to avoid
    nasty surprises in case they already have an 'images' folder they're
    using for other purposes.

    Change-Id: I34dee3ea32f2fe5ead568d2055ce58a479a0d51d
    Signed-off-by: Richard Mansfield <email address hidden>

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/538
Committed: http://gitorious.org/mahara/mahara/commit/65a21b0415affc63f3158e0cb3475072af113cbd
Submitter: Hugh Davenport (<email address hidden>)
Branch: master

commit 65a21b0415affc63f3158e0cb3475072af113cbd
Author: Richard Mansfield <email address hidden>
Date: Fri Jul 29 14:43:28 2011 +1200

    Fix upload error when users have two image folders (bug #605747)

    Users cannot upload profileicons if they happen to have two images
    folders in their home folder. This changes the get_folder_by_name
    function to use get_records_sql_array rather than get_record_sql, as
    is done in the search for the admin public folder.

    Change-Id: Iee83c32008d536aa4e7afdfc65e585a8a264cf87
    Signed-off-by: Richard Mansfield <email address hidden>

[Melissa Draper (melissa)]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

status fixreleased
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQEcBAEBAgAGBQJPjqdlAAoJECXBtiziiXdcxeoH/iQi1ljFCaDUrA07cq6IAZga
p3Tw7VRtZBy6Cl5NwOFg1b4/DsqFIM9fQPb+WpJqUAcTVP6B44QElOCtb0ldeZCw
cgWlkkSj1jk/gpCdKhCZ2MMHkRjMao5ZpUyF4vSO26tIiYcvPIhRoF6uWu0Z40xe
1wee4ZKGEEvO13bujMyuu4nEQSd9TK5VWPn+PbIKFEyJgCY19Zw62fWBXoanPbWj
LDuO9AnaQOPyVEx2qtoH8M5LFra2zq+dZ9Ac7oAiLffcWJAB9MqL8o2zbQHpOuVi
Ynrh6BIyUYaqdt1BhALrJ6/MQ0h7mDKGy8CVg0z4e2VHyxecYwc84kwzrItH7I0=
=mdeb
-----END PGP SIGNATURE-----

[Melissa Draper (melissa)]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

 status fixreleased
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQEcBAEBAgAGBQJPjrRzAAoJECXBtiziiXdcggYH/39bWTAPjHe9fUi3ve11K6iW
/R7j+mSc51e/47Cx0Z1Xv1HkDY0ymFLyRU/4CgErzWLWtrlSVhDx/r3gf8aHj+A+
ICmHRmTTCRBij5sKZVZbzZDN/t9drPvJ1u1dWcagGR2DiXoxAa9Kd2LUXKScRvS6
DqhQWj42JiOoo1R1FGFLa8dpPwlzwuLKyQQ6gvdDutva0E3RqktUUBy8w6ieMG6E
UM/K4sdgx7AAhfBxg91349DOjKeHE/69Vb1gbJXE9UtY/xwe+3sgBtAM7aN4e5US
PhBcGckRLkgxpwLwDzTNGuDHFp51OjIdqXaoRAxXx3tgOonY2bs/eqg42RJBcR4=
=dLjM
-----END PGP SIGNATURE-----