core.selectObjectByName clearing function is not working for constellation selection

[Jon Cluck]

core.selectObjectByName("", false);
This should clear the currently selected object(s), but it does not do anything.

OS: Windows XP
Stellarium v0.10.5

[Matthew Gates (matthew-porpoisehead)]

This is weird. I replicated it before... now I can't replicate it on either Linux / development version or Windows Vista / version 0.10.5.

[Matthew Gates (matthew-porpoisehead)]

Jon Cluck: Please can you run this test script and see what it does? I expect it to zoom in on HP85927, and then the selection should toggle on and off a few times (including the selected object information).

core.clear("starchart");
core.selectObjectByName("HP85927",true);
StelMovementMgr.autoZoomIn(0.5);
core.wait(1);
core.selectObjectByName("HP85927", true);
core.wait(0.5);
core.selectObjectByName("", true);
core.wait(0.5);
core.selectObjectByName("HP85927", true);
core.wait(0.5);
core.selectObjectByName("", true);
core.wait(0.5);
core.selectObjectByName("HP85927", true);
core.wait(0.5);
core.selectObjectByName("", true);
core.wait(0.5);

[Jon Cluck (cluckj)]

The script you posted works as expected, I forgot to post on the bug that it
showed up only with constellations. Try the following:

ConstellationMgr.setFlagIsolateSelected(true);
ConstellationMgr.setFlagLines(true);
core.selectObjectByName("Ursa Major",true);
core.wait(1.0);
core.selectObjectByName("", true);
core.wait(1.0);
core.selectObjectByName("Ursa Minor", true);
core.wait(1.0);
core.selectObjectByName("", true);
core.wait(1.0);

On Wed, Jul 7, 2010 at 6:49 PM, Matthew Gates <email address hidden> wrote:

> Jon Cluck: Please can you run this test script and see what it does? I
> expect it to zoom in on HP85927, and then the selection should toggle on
> and off a few times (including the selected object information).
>
> core.clear("starchart");
> core.selectObjectByName("HP85927",true);
> StelMovementMgr.autoZoomIn(0.5);
> core.wait(1);
> core.selectObjectByName("HP85927", true);
> core.wait(0.5);
> core.selectObjectByName("", true);
> core.wait(0.5);
> core.selectObjectByName("HP85927", true);
> core.wait(0.5);
> core.selectObjectByName("", true);
> core.wait(0.5);
> core.selectObjectByName("HP85927", true);
> core.wait(0.5);
> core.selectObjectByName("", true);
> core.wait(0.5);
>
>
>
> ** Changed in: stellarium
> Status: Confirmed => In Progress
>
> --
> core.selectObjectByName clearing function is not working
> https://bugs.launchpad.net/bugs/600889
> You received this bug notification because you are a direct subscriber
> of the bug.
>
> Status in Stellarium: In Progress
>
> Bug description:
> core.selectObjectByName("", false);
> This should clear the currently selected object(s), but it does not do
> anything.
>
> OS: Windows XP
> Stellarium v0.10.5
>
> To unsubscribe from this bug, go to:
> https://bugs.launchpad.net/stellarium/+bug/600889/+subscribe
>

[Matthew Gates (matthew-porpoisehead)]

I see. the

core.selectObjectByName("", true);

doesn't clear single constellation mode selections... ok. Got it :)

[Matthew Gates (matthew-porpoisehead)]

OK, so I think I worked out what is going on.

Firstly, de-selecting the selected object doesn't clear the isolated constellation selection. This is true both in scripting and in interactive mode. I think this behavior makes sense.

I think to clear the single selection, one should simply turn of isolated constellation mode. Currently this doesn't work quite as expected when there is an existing isolated constellation selection. Instead of clearing the current isolated constellation, it makes it so that existing isolated selection constellations are not cleared unless a non-constellation star is selected.

I feel that this behavior is wrong. When isolated constellation selection mode is turned off, isolated constellation selections should be cleared (and all constellations displayed). I will change this in the development version.

In the mean time, you can write a function which will do the clearing, and call this when you want to clear isolated constellation selections:

  function clearSingleConstellationMode() {
        var restoreValue = ConstellationMgr.getFlagIsolateSelected();
        ConstellationMgr.setFlagIsolateSelected(false);
        core.selectObjectByName("HP44504"); // this is just a star which is NOT part of a constellation line
        core.selectObjectByName("");
        ConstellationMgr.setFlagIsolateSelected(restoreValue);
  }

and then just call this when you want to clear isolated selections. Note that this will turn off isolated selection mode...

  clearSingleConstellationMode();