byobu-janitor replaces dashes in status commands, breaks status display

Bug #598488 reported by Gabriel de Perthuis
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
byobu
Fix Released
Medium
Dustin Kirkland 
byobu (Ubuntu)
Fix Released
Medium
Unassigned

Bug Description

When byobu starts, byobu-janitor is invoked and runs sed expressions against ~/.byobu/status. One of these edits makes the status file unreadable in my case, and byobu displays no indicator. The attached patch fixes that by using a stricter sed expression.

FWIW, here is what my status file contains; it uses the shorter codename, and reads /etc/lsb-release which is faster than firing up python to do so.

DISTRO="$(sed -ne 's/DISTRIB_CODENAME=//p' /etc/lsb-release)"

Revision history for this message
Gabriel de Perthuis (g2p) wrote :
Changed in byobu:
status: New → Triaged
importance: Undecided → Medium
Revision history for this message
Gabriel de Perthuis (g2p) wrote :

Dustin, can you please apply this?
The sed expression is easy to review.

Revision history for this message
Dustin Kirkland  (kirkland) wrote :

Sure thing, will get in next release soon!

Changed in byobu:
assignee: nobody → Dustin Kirkland (kirkland)
Changed in byobu:
status: Triaged → In Progress
Changed in byobu:
status: In Progress → Fix Committed
Changed in byobu (Ubuntu):
status: New → Fix Committed
importance: Undecided → Medium
Changed in byobu:
status: Fix Committed → Fix Released
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package byobu - 3.2-0ubuntu1

---------------
byobu (3.2-0ubuntu1) maverick; urgency=low

  * usr/share/byobu/keybindings/f-keys: resize the screen as part of the
    F5/refresh, LP: #619899
  * usr/bin/byobu-launcher: don't launch if in a dumb terminal, LP: #612886
  * usr/lib/byobu/network, usr/share/man/man1/byobu.1: allow for
    configuration of network traffic in [kM]ps, LP: #578377
  * configure.ac: POSIX sed doesn't include -i option, LP: #619328, #622640
  * usr/bin/byobu-janitor: improve dash replacement in status config,
    LP: #598488
  * usr/bin/byobu-janitor: fix upgrades where one's window list might have
    motd+shell, LP: #589715
 -- Dustin Kirkland <email address hidden> Mon, 23 Aug 2010 17:34:33 -0400

Changed in byobu (Ubuntu):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.