Add a 'Quit Orca' button

[Henrik Nilsen Omma]

Orca is primarily designed with blind users in mind who tend to use keyboard shortcuts for computer navigation. The only implemented way of stopping Orca normally (other than 'killall orca') was with the Insert+q keybinding. This is fine for blind users who prefer that, but when we integrate Orca in the main Ubuntu desktop we also need an easily discoverable way for users to close it. This patch creates a 'Quit Orca' button which does that.

The next patch replaces the OK and Cancel buttons with a Close and Apply button. This is more useful because Orca does not use gconf and hence does not have instant apply. Magnification users have requested this change because when they tweak the magnifier settings it is much more useable this way.

(patches by Chris Jones)

[Daniel Holbach (dholbach)]

Need to check for Ubuntu release.

[Daniel Holbach (dholbach)]

Hum, I just checked the Upstream bug and the patches (that were accepted in CVS for 2.17.x - YAY) differ from the ones used in here. Any reason why we shouldn't sync with Upstream?

[Henrik Nilsen Omma (henrik)]

I have some minor UI nits with their solution, but the main thing is that they have added a quit button. I'm happy to sync with them and propose further changes directly to upstream later.

[Daniel Holbach (dholbach)]

 gnome-orca (1.0.0-0ubuntu3) edgy; urgency=low
 .
   * debian/patches/10-quit-button-bug-59531.dpatch:
     - applied patches from Malone: #59531, thanks Chris Jones for working on
       this.

[Henrik Nilsen Omma (henrik)]

Opening back up this old Orca bug from Edgy because we need to apply the same change to Feisty again. Upstream made their own floating Quit button solution which does not fit well with our presentation of these things. Bug 84172 successfully removes that (Fix Released), but we need to put our own patch back in.

Fortunately Chris has prepared a Feisty-compatible patch, that I'll upload here.

[Henrik Nilsen Omma (henrik)]

attached patch

[Duncan Lithgow (duncan-lithgow)]

I'm having a few usability problems with Orca (sighted user) and would like to confirm/ check this bug in Feisty Herd 4. Where should I be able to see these buttons? I can't open Orca as an independent app - I can only get a dialog via 'Control Center'.

[Luke Yelavich (themuso)]

Do we still want this patch included? It fails to patch against the latest gnome-orca source package.

[Henrik Nilsen Omma (henrik)]

The upstream bug is no longer relevant to this issue. Chris, could try making a new patch for Feisty? We should ask Orca to make this a runtime option (having a Quit button)

[Henrik Nilsen Omma (henrik)]

The Orca dialog has been redesigned and this bug is no longer relevant. Shipping stock upstream version.