Context menu causes extra clicks to be required

[Bryce Harrington]

Steps to reproduce:

1. Load gtg 0.3
2. Select a task in the task browser
3. Right click to bring up the context menu
4. Don't select anything from the context item
5. Instead, click on one of the other tasks. It does not highlight, but the context menu disappears.
6. Click on the task a second time. Still the task does not highlight!!!
7. Click on the task a THIRD time. Finally now it highlights. Whew.

It should not take more than two clicks to select a task, and probably should take only one.

I'm not sure what causes this behavior, but it's been around for a while.

[Lionel Dricot (ploum-deactivatedaccount)]

The reason for this bug is in gtk/browser/tasktree.py/on_button_press :

There's a
"self.get_selection().set_select_function(lambda *ignore: False)" that cause the bug.

I've no idea on why there's such a line and what is the goal of the whole function. Bertrand ? Luca ? Who wrote that ?

[Lionel Dricot (ploum-deactivatedaccount)]

Fixed in rev. 801

[Luca Invernizzi (invernizzi)]

It appears km wrote it. I have no idea what it does. You already fixed
it, anyway :D

On Fri, Jun 11, 2010 at 11:19 AM, Lionel Dricot <email address hidden> wrote:
> Fixed in rev. 801
>
> ** Changed in: gtg
>       Status: In Progress => Fix Committed
>
> --
> Context menu causes extra clicks to be required
> https://bugs.launchpad.net/bugs/591636
> You received this bug notification because you are subscribed to Getting
> Things GNOME!.
>
> Status in Getting Things GNOME!: Fix Committed
>
> Bug description:
> Steps to reproduce:
>
> 1. Load gtg 0.3
> 2. Select a task in the task browser
> 3. Right click to bring up the context menu
> 4. Don't select anything from the context item
> 5. Instead, click on one of the other tasks.  It does not highlight, but the context menu disappears.
> 6. Click on the task a second time.  Still the task does not highlight!!!
> 7. Click on the task a THIRD time.  Finally now it highlights.  Whew.
>
> It should not take more than two clicks to select a task, and probably should take only one.
>
> I'm not sure what causes this behavior, but it's been around for a while.
>
>
>

[Bryce Harrington (bryce)]

YAY!

On Fri, Jun 11, 2010 at 10:53:39AM -0000, Luca Invernizzi wrote:
> It appears km wrote it. I have no idea what it does. You already fixed
> it, anyway :D
>
> On Fri, Jun 11, 2010 at 11:19 AM, Lionel Dricot <email address hidden> wrote:
> > Fixed in rev. 801
> >
> > ** Changed in: gtg
> >       Status: In Progress => Fix Committed
> >
> > --
> > Context menu causes extra clicks to be required
> > https://bugs.launchpad.net/bugs/591636
> > You received this bug notification because you are subscribed to Getting
> > Things GNOME!.
> >
> > Status in Getting Things GNOME!: Fix Committed
> >
> > Bug description:
> > Steps to reproduce:
> >
> > 1. Load gtg 0.3
> > 2. Select a task in the task browser
> > 3. Right click to bring up the context menu
> > 4. Don't select anything from the context item
> > 5. Instead, click on one of the other tasks.  It does not highlight, but the context menu disappears.
> > 6. Click on the task a second time.  Still the task does not highlight!!!
> > 7. Click on the task a THIRD time.  Finally now it highlights.  Whew.
> >
> > It should not take more than two clicks to select a task, and probably should take only one.
> >
> > I'm not sure what causes this behavior, but it's been around for a while.
> >
> >
> >
>
> --
> Context menu causes extra clicks to be required
> https://bugs.launchpad.net/bugs/591636
> You received this bug notification because you are a member of Gtg
> contributors, which is subscribed to Getting Things GNOME!.
>
> Status in Getting Things GNOME!: Fix Committed
>
> Bug description:
> Steps to reproduce:
>
> 1. Load gtg 0.3
> 2. Select a task in the task browser
> 3. Right click to bring up the context menu
> 4. Don't select anything from the context item
> 5. Instead, click on one of the other tasks. It does not highlight, but the context menu disappears.
> 6. Click on the task a second time. Still the task does not highlight!!!
> 7. Click on the task a THIRD time. Finally now it highlights. Whew.
>
> It should not take more than two clicks to select a task, and probably should take only one.
>
> I'm not sure what causes this behavior, but it's been around for a while.
>