Where's the good old setThumbnailData in 0.2.X series ?

Bug #587614 reported by manatlan
12
This bug affects 2 people
Affects Status Importance Assigned to Milestone
pyexiv2
Fix Released
Medium
Olivier Tilloy

Bug Description

In 0.2.X series, there is no way to put back a thumbnail in the internal exif thumbnail ;-(
Hope you will add this feature back ;-)

Revision history for this message
Olivier Tilloy (osomon) wrote :

This is indeed a regression. In the 0.2 branch currently, one can access the image previews (read-only), but not the JPEG thumbnail.

Changed in pyexiv2:
importance: Undecided → Medium
status: New → Confirmed
tags: added: regression
Revision history for this message
Olivier Tilloy (osomon) wrote :
Revision history for this message
manatlan (manatlan) wrote :

any news ?

Revision history for this message
Olivier Tilloy (osomon) wrote :

I’ll be getting to this one soon…

Changed in pyexiv2:
assignee: nobody → Olivier Tilloy (osomon)
Revision history for this message
manatlan (manatlan) wrote : Re: [Bug 587614] Re: Where's the good old setThumbnailData in 0.2.X series ?

great !
It could be marvelous if pyexiv2 0.2.X could be upstream, and available in
official repository of ubuntu/debian 10.10

On Sat, Aug 28, 2010 at 11:44, Olivier Tilloy <email address hidden> wrote:

> I’ll be getting to this one soon…
>
> ** Changed in: pyexiv2
> Assignee: (unassigned) => Olivier Tilloy (osomon)
>
> --
> Where's the good old setThumbnailData in 0.2.X series ?
> https://bugs.launchpad.net/bugs/587614
> You received this bug notification because you are a direct subscriber
> of the bug.
>

Revision history for this message
Olivier Tilloy (osomon) wrote :

pyexiv2 0.2.2 is already in debian experimental (http://packages.debian.org/experimental/python-pyexiv2). Unfortunately it won’t make it into Ubuntu 10.10 (http://packages.ubuntu.com/maverick/python-pyexiv2). The issue is that pyexiv2 0.2 isn’t API-compatible with the 0.1 series, and it currently has reverse dependencies in Ubuntu (phatch-cli and lazygal). I know their respective authors are working to support pyexiv2 0.2, I need to synchronize with them to ensure we manage to get 0.2 in Ubuntu 11.04.
Anyway, I’ll keep providing up-to-date packages in pyexiv2-developers’ PPA.

Olivier Tilloy (osomon)
Changed in pyexiv2:
status: Confirmed → In Progress
Revision history for this message
Olivier Tilloy (osomon) wrote :

Implementation committed with revision 333 in the trunk.

Changed in pyexiv2:
status: In Progress → Fix Committed
tags: added: exif
Revision history for this message
manatlan (manatlan) wrote :

great news !
it's a christmas gift for me ;-)

just need to wait for packages now !

thanks a lot

Revision history for this message
Olivier Tilloy (osomon) wrote :

I hope to be able to release a new version very soon.

In the meantime, if you can test the development branch, I’d appreciate feedback on the API I added to access the EXIF thumbnail. Does it cover all your use cases? Is it intuitive enough to use? Does it have bugs?

I added some API documentation and a short section to the tutorial. Of course they are not online yet, but you can easily generate it by invoking `scons doc` in the branch.

Revision history for this message
manatlan (manatlan) wrote :

> In the meantime, if you can test the development branch ...

I'd like to do that, but don't know how to get and build it ...
it's always scons to build it ? the dev branch is in a svn (uri ?)?

Revision history for this message
Olivier Tilloy (osomon) wrote :

The source is versioned using bzr, the build system uses scons, and it’s all documented at http://tilloy.net/dev/pyexiv2/developers.html. Let me know if you need more information or if the information there is not clear enough.

Revision history for this message
manatlan (manatlan) wrote :

Great !
I will try tonight !

On Wed, Nov 24, 2010 at 17:25, Olivier Tilloy <email address hidden> wrote:

> The source is versioned using bzr, the build system uses scons, and it’s
> all documented at http://tilloy.net/dev/pyexiv2/developers.html. Let me
> know if you need more information or if the information there is not
> clear enough.
>
> --
> Where's the good old setThumbnailData in 0.2.X series ?
> https://bugs.launchpad.net/bugs/587614
> You received this bug notification because you are a direct subscriber
> of the bug.
>

Revision history for this message
manatlan (manatlan) wrote :

Great, I pickup the dev branch, build and install !

And implemented what I needed (set/erase thumbnail) (
http://code.google.com/p/jbrout/source/diff?spec=svn321&r=321&format=side&path=/trunk/jbrout/jbrout/pyexiv.py
(pyexiv
is my abstraction class which is able to work with differents releases of
pyexiv2 (0.1.x and 0.2.x), using pyexiv2 v1 api)) for using with a pyexiv2
>= 0.2.2
It works as expected.

But I continue to use "previews" to get the exif thumbnails (should i use
"exif_thumbnail.data" in the future ?)

I ask myself if I should provide this 0.2.2 pyexiv2 release in my
repository, or should I wait for yours.

Revision history for this message
Olivier Tilloy (osomon) wrote :

> And implemented what I needed (set/erase thumbnail) (
> http://code.google.com/p/jbrout/source/diff?spec=svn321&r=321&format=side&path=/trunk/jbrout/jbrout/pyexiv.py
> (pyexiv
> is my abstraction class which is able to work with differents releases of
> pyexiv2 (0.1.x and 0.2.x), using pyexiv2 v1 api)) for using with a pyexiv2
>> = 0.2.2
> It works as expected.

Good to hear!
I had a quick look at the diff for this commit in your wrapper, and I
have the following remark: the check on pyexiv2.version_info should be
stricly greater than (>) 0.2.2, since this functionality will be in the
following release.

> But I continue to use "previews" to get the exif thumbnails (should i use
> "exif_thumbnail.data" in the future ?)

If the EXIF data embeds a thumbnail, it will be listed in the previews.
There may be other types of previews, so if you don’t care about
specifically getting the EXIF thumbnail, you should keep using the
previews, you’ll have more information available.

However previews are read-only, whereas exif_thumbnail allows you to set
or erase the EXIF thumbnail.

> I ask myself if I should provide this 0.2.2 pyexiv2 release in my
> repository, or should I wait for yours.

If possible, you should definitely wait for a proper release. I’ll
communicate about my plans for the next release on the
pyexiv2-developers’ mailing list
(https://launchpad.net/~pyexiv2-developers, the ML archive is public if
you’re not registered).

Olivier Tilloy (osomon)
Changed in pyexiv2:
milestone: none → 0.3
Olivier Tilloy (osomon)
Changed in pyexiv2:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.