Various Exceptions during importing database

[Martin Skurla]

Various exceptions are thrown during importing database from edge list...

How to reproduce this bug:
1. select from menu File/Import Database/Edge List
2.let the connection set to New Configuration without any changes in text fields
3. after the click on the X button in the upper right corner of the window, following exception is thrown:
java.lang.RuntimeException: Failed to connect at jdbc:mysql://:/

4. also the incorrent connection named "jdbc:mysql://:/" is added to connection list
5. when we select again New Configuration the following exception is thrown:
java.lang.NullPointerException

6. when we select again jabc connection the same exception as in step 3 is thrown

Version of Gephi
Gephi 0.7 Alpha 4 with all 19 updates installed

Version of OS
Windows 7 64bit with all updates installed, JDK 1.6 update 20 32bit

How to solve this problem?
Register window listener on the dialog and when nothing is choosen, do not add any database or try to connect to it, so the exception should not be thrown and no corrupted connection will be added to list

[André Panisson (panisson)]

It seems that the dialog return event is not handled correctly. This change should fix the problem.

[Martin Skurla (bujacik)]

OMG,

I have the patch from yesterday, but I don't have time to upload it...

2010/5/25 André Panisson <email address hidden>:
> It seems that the dialog return event is not handled correctly. This
> change should fix the problem.
>
> ** Patch added: "584958.patch"
>   http://launchpadlibrarian.net/49073181/584958.patch
>
> --
> Various Exceptions during importing database
> https://bugs.launchpad.net/bugs/584958
> You received this bug notification because you are a direct subscriber
> of the bug.
>
> Status in Gephi - Network exploration and manipulation: New
>
> Bug description:
> Various exceptions are thrown during importing database from edge list...
>
>
> How to reproduce this bug:
> 1. select from menu File/Import Database/Edge List
> 2.let the connection set to New Configuration without any changes in text fields
> 3. after the click on the X button in the upper right corner of the window, following exception is thrown:
> java.lang.RuntimeException: Failed to connect at jdbc:mysql://:/
>
> 4. also the incorrent connection named "jdbc:mysql://:/" is added to connection list
> 5. when we select again New Configuration the following exception is thrown:
> java.lang.NullPointerException
>
> 6. when we select again jabc connection the same exception as in step 3 is thrown
>
>
> Version of Gephi
> Gephi 0.7 Alpha 4 with all 19 updates installed
>
> Version of OS
> Windows 7 64bit with all updates installed, JDK 1.6 update 20 32bit
>
>
> How to solve this problem?
> Register window listener on the dialog and when nothing is choosen, do not add any database or try to connect to it, so the exception should not be thrown and no corrupted connection will be added to list
>
> To unsubscribe from this bug, go to:
> https://bugs.launchpad.net/gephi/+bug/584958/+subscribe
>

[Martin Skurla (bujacik)]

Actually your patch is not working well, I will upload my in the evening...

2010/5/25 Martin Skurla <email address hidden>:
> OMG,
>
> I have the patch from yesterday, but I don't have time to upload it...
>
> 2010/5/25 André Panisson <email address hidden>:
>> It seems that the dialog return event is not handled correctly. This
>> change should fix the problem.
>>
>> ** Patch added: "584958.patch"
>>   http://launchpadlibrarian.net/49073181/584958.patch
>>
>> --
>> Various Exceptions during importing database
>> https://bugs.launchpad.net/bugs/584958
>> You received this bug notification because you are a direct subscriber
>> of the bug.
>>
>> Status in Gephi - Network exploration and manipulation: New
>>
>> Bug description:
>> Various exceptions are thrown during importing database from edge list...
>>
>>
>> How to reproduce this bug:
>> 1. select from menu File/Import Database/Edge List
>> 2.let the connection set to New Configuration without any changes in text fields
>> 3. after the click on the X button in the upper right corner of the window, following exception is thrown:
>> java.lang.RuntimeException: Failed to connect at jdbc:mysql://:/
>>
>> 4. also the incorrent connection named "jdbc:mysql://:/" is added to connection list
>> 5. when we select again New Configuration the following exception is thrown:
>> java.lang.NullPointerException
>>
>> 6. when we select again jabc connection the same exception as in step 3 is thrown
>>
>>
>> Version of Gephi
>> Gephi 0.7 Alpha 4 with all 19 updates installed
>>
>> Version of OS
>> Windows 7 64bit with all updates installed, JDK 1.6 update 20 32bit
>>
>>
>> How to solve this problem?
>> Register window listener on the dialog and when nothing is choosen, do not add any database or try to connect to it, so the exception should not be thrown and no corrupted connection will be added to list
>>
>> To unsubscribe from this bug, go to:
>> https://bugs.launchpad.net/gephi/+bug/584958/+subscribe
>>
>

[Mathieu Bastian (mathieu.bastian)]

Interesting, two patches for a single bug, congrats :-)

Martin what is not working in Andre's patch?

[Martin Skurla (bujacik)]

His patch will not work, because he replaces the Cancel to OK, so in his patch if you click on OK button, no other actions will be executed, which is definitely not what we want to do.

The right patch should include Closed window and if this event occurs, ignore other code execution...

[Mathieu Bastian (mathieu.bastian)]

Martin's patch merged with his branch on rev 1433