The dialog to to select partition mount point should automatically select the current partition type

[Kishore]

Binary package hint: ubiquity

In the kubuntu installer, in the manual partitioning page the mount point selection dialog should automatically preselect the current file system type of the partition.

I recently tried installing kubuntu 10.04 on a friends computer which had a two partitions (one for / and one for home) which were both of ext4 type. During the installation i was less cautious (I do kubuntu installation very often that I did not pay too much attention) and did not notice that the dialog had ext3 selected. I edited the mount point as /home and went ahead with the rest of the installation. Later on first boot i realized what i had done.

I believe the tool should caution stronger when a partition is to be formatted. Such as by changing the background color to say, red when it is to be formatted.

[Kishore (kitts)]

I went through the installation process again and realized that the reason for my error was not correctly described above. Let me explain here.

By default, the ui for partition edit dialog (as defined by the file gui/qt/partition_edit_dialog.ui) has the combo box for "use as" set to "do not use this partition". This is fine however, it is the format check box that is not behaving right. This is how i think the check box state should be defined:

1) unchecked and disabled when the combo box is set to "do not use this partition"
2) checked and disabled when the combo box is set to any fs type other than the one that it is already formatted as. An addition qlabel below the checkbox should inform the user that the format is required in order to change the fs type.
3) unchecked and enabled when the combo box is set to a fs which matches the fs type currently on the partition.

I looked at the code to to make these changes but unfortunately the code is in python that i do not understand very well. I could have helped with c++.

[Kishore (kitts)]

The attached patch automatically checks the format checkbox when the file system chosen is something other than what is currently on the partition. The text "(Format required)" needs translation.

[Kishore (kitts)]

Any update on this? I just tried installing maverick alpha 1 and this is not yet fixed. Is there something more i need to do with the patch to make it acceptable?