".." takes to list of drives instead of one up level directory structure

Bug #582924 reported by Au Nguy
22
This bug affects 5 people
Affects Status Importance Assigned to Milestone
Mixxx
Fix Released
Medium
Albert Santoni
1.8
Fix Released
Medium
Albert Santoni

Bug Description

Select 'Browse" and keep go down several subdirectories and then select ".." to go up one directory, it will take you back completely to the list of drives. This is Mixxx 1.8.0~beta1 running Windows XP SP3.

Tags: browse

Related branches

RJ Skerry-Ryan (rryan)
Changed in mixxx:
milestone: none → 1.8.0
Changed in mixxx:
status: New → Confirmed
milestone: 1.8.0 → 1.7.3
tags: added: browse
Revision history for this message
Albert Santoni (gamegod) wrote : Re: [Bug 582924] Re: ".." takes to list of drives instead of one up level directory structure

I can confirm this bug but I can't find the cause. All we have is
BrowseTableModel.cpp and BrowseFilter.cpp, did I miss anything?
Besides the filtering we do, this is almost a plain
QFileSystemModel...

On Fri, Jul 2, 2010 at 10:40 PM, Pegasus <email address hidden> wrote:
> ** Also affects: mixxx/1.8
>   Importance: Undecided
>       Status: New
>
> ** Changed in: mixxx/1.8
>       Status: New => Confirmed
>
> ** Changed in: mixxx
>       Status: New => Confirmed
>
> ** Changed in: mixxx/1.8
>    Milestone: None => 1.8.0
>
> ** Changed in: mixxx
>    Milestone: 1.8.0 => 1.7.3
>
> ** Tags added: browse
>
> --
> ".." takes to list of drives instead of one up level directory structure
> https://bugs.launchpad.net/bugs/582924
> You received this bug notification because you are a member of Mixxx
> Development Team, which is subscribed to Mixxx.
>

Changed in mixxx:
milestone: 1.7.3 → none
Revision history for this message
RJ Skerry-Ryan (rryan) wrote :

We change directories by appending '..' to the path. This might not be portable. Maybe we need to use QDir::cdUp().

Albert Santoni (gamegod)
Changed in mixxx:
importance: Undecided → Medium
Revision history for this message
Albert Santoni (gamegod) wrote :

I just committed a potential fix for this in r2583 in trunk (sorry).

Changed in mixxx:
assignee: nobody → Albert Santoni (gamegod)
status: Confirmed → Fix Committed
Revision history for this message
Sean M. Pappalardo (pegasus-renegadetech) wrote :

It works fine in trunk. The only remaining problem is that on Windows, there's no ".." entry at the root of a drive so you are now unable to get to the list of drives. (In Linux it's fine, and even shows a no-op ".." entry when you're at / .)

RJ Skerry-Ryan (rryan)
Changed in mixxx:
status: Fix Committed → Fix Released
Revision history for this message
Swiftb0y (swiftb0y) wrote :

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/5396

lock status: Metadata changes locked and limited to project staff
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.