selftest fails to reports errors involving unicode

[Vincent Ladeuil]

.. and that's needed by subunit to report test failures (so the content is quite arbitrary).

Anyway, I see no good reason to *not* support it either

[Vincent Ladeuil (vila)]

meh, s/subunit/bzr itself via testtools/ :

Traceback (most recent call last):
  File "/home/vila/src/bzr/experimental/conflict-manager/bzrlib/commands.py", line 907, in exception_to_return_code
    return the_callable(*args, **kwargs)
  File "/home/vila/src/bzr/experimental/conflict-manager/bzrlib/commands.py", line 1111, in run_bzr
    ret = run(*run_argv)
  File "/home/vila/src/bzr/experimental/conflict-manager/bzrlib/commands.py", line 685, in run_argv_aliases
    return self.run(**all_cmd_args)
  File "/home/vila/src/bzr/experimental/conflict-manager/bzrlib/commands.py", line 700, in run
    return self._operation.run_simple(*args, **kwargs)
  File "/home/vila/src/bzr/experimental/conflict-manager/bzrlib/cleanup.py", line 122, in run_simple
    self.cleanups, self.func, *args, **kwargs)
  File "/home/vila/src/bzr/experimental/conflict-manager/bzrlib/cleanup.py", line 156, in _do_with_cleanups
    result = func(*args, **kwargs)
  File "/home/vila/src/bzr/experimental/conflict-manager/bzrlib/builtins.py", line 3626, in run
    result = selftest(**selftest_kwargs)
  File "/home/vila/src/bzr/experimental/conflict-manager/bzrlib/tests/__init__.py", line 3444, in selftest
    result_decorators=result_decorators,
  File "/home/vila/src/bzr/experimental/conflict-manager/bzrlib/tests/__init__.py", line 2978, in run_suite
    result = runner.run(suite)
  File "/home/vila/src/bzr/experimental/conflict-manager/bzrlib/tests/__init__.py", line 648, in run
    test.run(result)
  File "/home/vila/src/bzr/experimental/conflict-manager/bzrlib/tests/__init__.py", line 3089, in run
    return super(CountingDecorator, self).run(result)
  File "/home/vila/src/bzr/experimental/conflict-manager/bzrlib/tests/__init__.py", line 3078, in run
    test.run(result)
  File "/home/vila/src/bzr/experimental/conflict-manager/bzrlib/tests/TestUtil.py", line 84, in run
    tests.pop().run(result)
  File "/home/vila/lib/python/testtools/testcase.py", line 361, in run
    return self.__RunTest(self, self.exception_handlers).run(result)
  File "/home/vila/lib/python/testtools/runtest.py", line 64, in run
    return self._run_one(actual_result)
  File "/home/vila/lib/python/testtools/runtest.py", line 78, in _run_one
    return self._run_prepared_result(ExtendedToOriginalDecorator(result))
  File "/home/vila/lib/python/testtools/runtest.py", line 89, in _run_prepared_result
    self._run_core()
  File "/home/vila/lib/python/testtools/runtest.py", line 106, in _run_core
    self.case._run_test_method, self.result):
  File "/home/vila/lib/python/testtools/runtest.py", line 140, in _run_user
    handler(self.case, self.result, e)
  File "/home/vila/lib/python/testtools/testcase.py", line 341, in _report_failure
    result.addFailure(self, details=self.getDetails())
  File "/home/vila/lib/python/testtools/testresult/real.py", line 406, in addFailure
    return self.decorated.addFailure(test, err)
  File "/home/vila/src/bzr/experimental/conflict-manager/bzrlib/tests/__init__.py", line 341, in addFailure
    self.report_failure(test, err)
  File "/home/vila/src/bzr/experimental/conflict-manager/bzrlib/tests/__init__.py", line 500, in report_failure
    err[1],
  File "/home/vila/src...

[Vincent Ladeuil (vila)]

While ui.note() doesn't support unicode, my concern here is selftest failing to report failures or errors.
See https://code.edge.launchpad.net/~vila/bzr/563997-selftest-unicode-reporting that fixes selftest.

[Martin Pool (mbp)]

I think it should take Unicode, but it's also questionable if the tests are
using this for anything but talking to the user or testing ui code.

- Martin

On 16/04/2010 2:41 AM, "Vincent Ladeuil"
<<email address hidden><v.ladeuil%<email address hidden>>>
wrote:

Public bug reported:

.. and that's needed by subunit to report test failures (so the content
is quite arbitrary).

Anyway, I see no good reason to *not* support it either

** Affects: bzr
    Importance: High
        Status: Confirmed

** Tags: babune ui

--
ui.note doesn't support unicode
https://bugs.launchpad.net/bugs/563997
You received this bug notification because you are a member of bzr-qa,
which is subscribed to Bazaar.

[Robert Collins (lifeless)]

the test are using this to report errors - its in the test reporting code