xmlrpc client API doesn't use proxy settings

[Ashley Holman]

in api/xmlrpc/client.php: function send():

this doesn't ever use proxy settings, hence was timing out for me because my web server MUST go through a proxy.

I was able to fix it by adding these lines:

        if($proxy_address = get_config('proxyaddress')) {
          curl_setopt($ch, CURLOPT_PROXY, $proxy_address);
        }

Thanks

[François Marier (fmarier)]

We need to review every bit of code which uses curl.

I suppose we should write a curl wrapper so that developers don't have to remember to set the proxy stuff.

[Nigel McNie (nigel-mcnie)]

On 26 July 2010 18:36, François Marier <email address hidden> wrote:

> We need to review every bit of code which uses curl.
>

They should all be using mahara_http_request() iirc. I don't recall ever
converting the xmlrpc stuff to that though.

--
Regards,
Nigel McNie
http://nigel.mcnie.name/ | [phone] | http://twitter.com/nigelmcnie
My latest blog post:
http://nigel.mcnie.name/blog/howto-convert-from-it-geek-to-entrepreneur-part-5-getting-started

[Hugh Davenport (hugh-davenport)]

https://reviews.mahara.org/431

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/431
Committed: http://gitorious.org/mahara/mahara/commit/9331c2291bdc6cbe0e5dd5dac1d60324794d57f9
Submitter: Richard Mansfield (<email address hidden>)
Branch: master

commit 9331c2291bdc6cbe0e5dd5dac1d60324794d57f9
Author: Hugh Davenport <email address hidden>
Date: Mon Jul 4 16:13:13 2011 +1200

    Make xmlrpc client use mahara_http_request

    The xmlrpc client was still using curl directly. This patch
    converts this to use mahara_http_request instead.

    This fixes bug #562699

    Change-Id: I6f775275f193132031e334e456867cc137308c0e
    Signed-off-by: Hugh Davenport <email address hidden>