diff colorization fails with deleted lines starting with --
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Launchpad itself |
Fix Released
|
Medium
|
Tim Penhey |
Bug Description
If a line starting with '--' has been removed, it is not colored red on the merge proposal page as it should be. https:/
=== removed file 'database/
111 --- database/
112 +++ database/
113 @@ -1,885 +0,0 @@
114 --- Copyright 2009 Canonical Ltd. This software is licensed under the
115 --- GNU Affero General Public License version 3 (see the file LICENSE).
116 -
117 --- Generated by:
118 --- pg_dump --format=p --schema-only --no-owner --no-privileges \
119 --- --table=Account --table=
120 --- --table=
121 --- --table=
122 --- --table=
123 --- --table=
124 -
125 ---
126 --- PostgreSQL database dump
127 ---
Related branches
- Stuart Bishop (community): Approve
-
Diff: 504 lines (+241/-207)3 files modifiedlib/canonical/launchpad/webapp/tests/test_tales.py (+0/-205)
lib/lp/app/browser/stringformatter.py (+10/-2)
lib/lp/app/browser/tests/test_stringformatter.py (+231/-0)
tags: | added: code-review confusing-ui |
Changed in launchpad-code: | |
status: | New → Triaged |
importance: | Undecided → Medium |
summary: |
- diff colorization fails with deleted SQL comments + diff colorization fails with deleted lines starting with -- |
Changed in launchpad-code: | |
status: | Triaged → Fix Committed |
tags: |
added: qa-ok removed: qa-needstesting |
Changed in launchpad-code: | |
status: | Fix Committed → Fix Released |
So, uh, how do I tell when this code has gone live, at least on 'edge'?