telepathy-butterfly crashed with ValueError in __parse()

[J.Gabriels]

Binary package hint: telepathy-butterfly

While running in the background, empathy messenger crashed.

ProblemType: Crash
DistroRelease: Ubuntu 10.04
Package: telepathy-butterfly 0.5.7-0ubuntu1
ProcVersionSignature: Ubuntu 2.6.32-19.28-generic 2.6.32.10+drm33.1
Uname: Linux 2.6.32-19-generic i686
NonfreeKernelModules: nvidia
Architecture: i386
Date: Thu Apr 8 17:52:25 2010
ExecutablePath: /usr/lib/telepathy/telepathy-butterfly
InstallationMedia: Ubuntu 10.04 "Lucid Lynx" - Beta i386 (20100318)
InterpreterPath: /usr/bin/python2.6
PackageArchitecture: all
ProcCmdline: /usr/bin/python /usr/lib/telepathy/telepathy-butterfly
ProcEnviron:
 SHELL=/bin/bash
 LANG=en_US.utf8
PythonArgs: ['/usr/lib/telepathy/telepathy-butterfly']
SourcePackage: telepathy-butterfly
Title: telepathy-butterfly crashed with ValueError in __parse()
UserGroups: adm admin cdrom dialout lpadmin plugdev sambashare

[Sebastien Bacher (seb128)]

The bug has been opened on https://bugs.launchpad.net/ubuntu/+source/telepathy-butterfly/+bug/558493

"While running in the background, empathy messenger crashed.

telepathy-butterfly 0.5.7-0ubuntu1

Traceback (most recent call last):
  File "/usr/lib/pymodules/python2.6/papyon/switchboard_manager.py", line 370, in _sb_message_received
    handler._on_message_received(message)
  File "/usr/lib/pymodules/python2.6/papyon/conversation.py", line 353, in _on_message_received
    TextFormat.parse(message_formatting),
  File "/usr/lib/pymodules/python2.6/papyon/conversation.py", line 186, in parse
    text_format.__parse(format)
  File "/usr/lib/pymodules/python2.6/papyon/conversation.py", line 231, in __parse
    for p in property.split('=', 1)]
ValueError: need more than 1 value to unpack"

[Jonny-lamb (jonny-lamb)]

I need the butterfly log for just before this traceback.

[Sebastien Bacher (seb128)]

Thanks for your bug report. This bug has been reported to the developers of the software. You can track it and make comments here: https://bugs.freedesktop.org/show_bug.cgi?id=27556

[Sebastien Bacher (seb128)]

If you get the issue again could you open the empathy help menu, debug dialog, select butterfly in the combo and get the debug log coressponding to the crash. Check for informations you don't want to share and add the log or the 15 lines before the crash to the bug, those informations would be useful to work on the issue

[William Grant (wgrant)]

This happens every time I receive a message from a particular contact at the moment. Said contact is using eBuddy right now.

This is an example message:

<<< MSG <redacted email> <redacted name> 160

 X-MMS-IM-Format: 'FN=Arial; EF=; CO=000000; CS=0; PF=00; RL=0;'\r\n
 Content-Type: 'text/plain; charset=UTF-8'\r\n
 MIME-Version: '1.0'\r\n
 \r\n
 <redacted plaintext message body>

I suspect that the trailing semicolon on X-MMS-IM-Format is to blame -- adding an emptiness check like this fixes it:

    def __parse(self, format):
        for property in format.split(';'):
            if not property:
                continue
            key, value = [p.strip(' \t|').upper() \
                    for p in property.split('=', 1)]

[Jonny-lamb (jonny-lamb)]

Good catch, thanks! I merged your patch to master:

http://git.collabora.co.uk/?p=papyon.git;a=commitdiff;h=ffb93617a

[William Grant (wgrant)]

As I posted on the upstream bug:

This happens every time I receive a message from a particular contact at the
moment. Said contact is using eBuddy right now.

This is an example message:

<<< MSG <redacted email> <redacted name> 160

 X-MMS-IM-Format: 'FN=Arial; EF=; CO=000000; CS=0; PF=00; RL=0;'\r\n
 Content-Type: 'text/plain; charset=UTF-8'\r\n
 MIME-Version: '1.0'\r\n
 \r\n
 <redacted plaintext message body>

I suspect that the trailing semicolon on X-MMS-IM-Format is to blame -- adding
an emptiness check like this fixes it:

    def __parse(self, format):
        for property in format.split(';'):
            if not property:
                continue
            key, value = [p.strip(' \t|').upper() \
                    for p in property.split('=', 1)]

[William Grant (wgrant)]

My patch was accepted upstream: http://bazaar.launchpad.net/~wgrant/papyon/master/revision/740

[Launchpad Janitor (janitor)]

This bug was fixed in the package papyon - 0.4.6-0ubuntu2

---------------
papyon (0.4.6-0ubuntu2) lucid; urgency=low

  * debian/patches/93_git_trailing_semicolons_crash.patch:
    - upstream change to not on messages with trailing semicolons
      (lp: #558493)
 -- Sebastien Bacher <email address hidden> Wed, 14 Apr 2010 23:56:49 +0200