Terminator

After setting text color in Profiles>Colors, text color defaults to black automaticly when changes are made in Profiles.

Bug #554440 reported by illumin8
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Terminator
Fix Released
Medium
Chris Jones

Bug Description

After chaging text color settings in Profiles>Colors, the text automaticly changes back to default black whenever changes are made to settings under Profiles. I can consitently reproduce the bug by changing text color to white, then unchecking show title bar.

Revision history for this message
Chris Jones (cmsj) wrote :

Could you attach ~/.config/terminator/config and the output of running terminator -d, please?

Changed in terminator:
status: New → Incomplete
Revision history for this message
illumin8 (illumin8media) wrote :

Here is ~/.config/terminator/config....

[global_config]
  title_transmit_fg_color = "#d0d0d0d0d0d0"
  title_inactive_fg_color = "#821082108210"
  title_receive_bg_color = "#d0d0d0d0d0d0"
  title_transmit_bg_color = "#222222222222"
  title_receive_fg_color = "#222222222222"
  title_inactive_bg_color = "#222222222222"
[keybindings]
  full_screen = <Ctrl><Shift>F11
[profiles]
  [[default]]
    scrollbar_position = hidden
    background_darkness = 0.77
    scrollback_lines = 2000
    background_type = transparent
    foreground_color = "#d0d0d0d0d0d0"
    icon_bell = False
    show_titlebar = False
    color_scheme = custom
    cursor_blink = False
[layouts]
  [[default]]
    [[[child1]]]
      type = Terminal
      parent = window0
    [[[window0]]]
      type = Window
      parent = ""
[plugins]

Revision history for this message
illumin8 (illumin8media) wrote :
Download full text (12.1 KiB)

And output of terminator -d...

[aaron@zion ~]$ terminator -d
noclass::parse_options: OptionParse::parse_options: command line options: {'dummy': None, 'execute': None, 'layout': 'default', 'fullscreen': None, 'geometry': None, 'debug': 1, 'debug_methods': None, 'maximise': None, 'debug_classes': None, 'version': None, 'working_directory': None, 'borderless': None, 'forcedtitle': None, 'command': None, 'hidden': None, 'role': None}
Factory::__init__: Borg::__init__: Preparing borg state for Factory
Terminator::__init__: Borg::__init__: Preparing borg state for Terminator
ConfigBase::load: ConfigBase::load: config already loaded
noclass::get_pid_cwd: Using Linux get_pid_cwd
Terminator::attempt_gnome_client: GNOME session support enabled and registered
ConfigBase::get_item: ConfigBase::get_item: handle_size found in globals: -1
Factory::make: Factory::make: created a Window
Warning: python-keybinder is not installed. This means the hide_window shortcut will be unavailable
Terminator::register_window: Terminator::register_window: registering 168684396:<class 'terminatorlib.window.Window'>
ConfigBase::load: ConfigBase::load: config already loaded
Unable to bind hide_window key, another instance/window has it.
ConfigBase::get_item: ConfigBase::get_item: window_state found in globals: normal
ConfigBase::get_item: ConfigBase::get_item: window_state found in globals: normal
ConfigBase::get_item: ConfigBase::get_item: window_state found in globals: normal
ConfigBase::get_item: ConfigBase::get_item: borderless found in globals: False
Window::set_real_transparency: setting rgba colormap
Factory::make: Factory::make: created a Terminal
Terminator::register_terminal: Terminator::register_terminal: registering 169224828:<class 'terminatorlib.terminal.Terminal'>
ConfigBase::load: ConfigBase::load: config already loaded
Terminal::__init__: composite_support: True
ConfigBase::get_item: ConfigBase::get_item: try_posix_regexp found in globals: False
Terminal::update_url_matches: Terminal::update_url_matches: Trying GNU URL regexps
PluginRegistry::__init__: Borg::__init__: Preparing borg state for PluginRegistry
PluginRegistry::prepare_attributes: PluginRegistry::prepare_attributes: Plugin path: ['/usr/lib/python2.6/site-packages/terminatorlib/plugins', '/home/aaron/.config/terminator/plugins']
ConfigBase::load: ConfigBase::load: config already loaded
PluginRegistry::load_plugins: PluginRegistry::load_plugins: Importing plugin url_handlers.py
ConfigBase::get_item: ConfigBase::get_item: disabled_plugins found in globals: ['TestPlugin', 'CustomCommandsMenu']
ConfigBase::get_item: ConfigBase::get_item: disabled_plugins found in globals: ['TestPlugin', 'CustomCommandsMenu']
ConfigBase::get_item: ConfigBase::get_item: disabled_plugins found in globals: ['TestPlugin', 'CustomCommandsMenu']
PluginRegistry::load_plugins: PluginRegistry::load_plugins: Importing plugin testplugin.py
ConfigBase::get_item: ConfigBase::get_item: disabled_plugins found in globals: ['TestPlugin', 'CustomCommandsMenu']
PluginRegistry::load_plugins: PluginRegistry::load_plugins: Importing plugin terminal_menu.py
PluginRegistry::load_plugins: PluginRegistry::load_plugins: Importing plugin custom_...

Revision history for this message
illumin8 (illumin8media) wrote :

After reading through the output of terminator -d,
I installed python-keybind, to enable the hide_window shortcut,
 and rather than trying to modify the default profile, I created a new profile.
After creating the new profile and selecting it, the font color no longer reverts to #000000 when changing settings in profiles.

However, after closing closing terminator, it reverts to the default profile when restarted. I attempted to delete the default profile, to see if that would be a work around, but that option is not allowed.

Revision history for this message
Chris Jones (cmsj) wrote :

Annoyingly I'm totally failing to reproduce this. Perhaps you could remove ~/.config/terminator/config and walk through exactly the steps required to produce the bug? If you're feeling particularly keen and have bzr installed, running the test with trunk would be useful ("bzr branch lp:terminator" gets you a copy of trunk which will shortly become 0.92)
Thanks for your help!

Revision history for this message
illumin8 (illumin8media) wrote : Re: [Bug 554440] Re: After setting text color in Profiles>Colors, text color defaults to black automaticly when changes are made in Profiles.

Odd.

Im currently running 0.91 -bzr but built it from Arch AUR. I didnt examine
the build files very closely last install.
So...
I deleted ~/.config/terminator/config, and removed terminator-bzr.
I reviewed PKGBUILD and terminator.install when re-installing to see if
anything jumped out...

After the re-install, the text no longer reverts to black when editing
profiles.
What i did notice is that when I start the preferences dialog from the
terminator right click menu,
it seems to kick the profile color settings out of "custom" and revert back
to whatever built in color profile was selected previously.
So it looks to me like the text color thing was only a symptom.
The actual bug, for me at least, is that the Preferences dialog doesnt honor
the selection "custom" when launched from the terminator right-click menu.
Could just be a weird single user bug. It really is not a big deal for me.
Once Im aware of it, i can set the profile accordingly.
Could be 0.92 will erase whatever is causing it.

On Wed, Apr 7, 2010 at 4:54 AM, Chris Jones <email address hidden>wrote:

> Annoyingly I'm totally failing to reproduce this. Perhaps you could remove
> ~/.config/terminator/config and walk through exactly the steps required to
> produce the bug? If you're feeling particularly keen and have bzr installed,
> running the test with trunk would be useful ("bzr branch lp:terminator" gets
> you a copy of trunk which will shortly become 0.92)
> Thanks for your help!
>
> --
> After setting text color in Profiles>Colors, text color defaults to black
> automaticly when changes are made in Profiles.
> https://bugs.launchpad.net/bugs/554440
> You received this bug notification because you are a direct subscriber
> of the bug.
>
> Status in Terminator: Incomplete
>
> Bug description:
> After chaging text color settings in Profiles>Colors, the text automaticly
> changes back to default black whenever changes are made to settings under
> Profiles. I can consitently reproduce the bug by changing text color to
> white, then unchecking show title bar.
>
> To unsubscribe from this bug, go to:
> https://bugs.launchpad.net/terminator/+bug/554440/+subscribe
>

Revision history for this message
Chris Jones (cmsj) wrote :

ok thanks for letting me know. I'll mark this as Invalid for now, but if you do find it coming back reproducibly, please re-open this bug :)

Changed in terminator:
status: Incomplete → Invalid
Revision history for this message
flex (frostynova) wrote :

In termator 0.92, i also found this bug.
Reproduce:

1. change the two "built-in schemes" at preferences->profiles->colors to custom
2. change the background color and color palette, press close.

Then you will find terminator and its config file changed as you wish.

3. open preferences->profiles->colors menu again, you will find the built-in schemes return to the default, after pressing close, both terminator and the config file return to default color.

ps: I found that only after you changing the built-in schemes to custom, it will return to default. If you change it to other, such as linux, it will stay as you wish.

Revision history for this message
illumin8 (illumin8media) wrote :

Yeah thats pretty much what i figured out as well.
It wont stay set on a custom scheme. When you open the preferences dialog
from the terminator right click menu, it kicks the built in scheme setting
out of custom.

On Wed, Apr 7, 2010 at 11:26 PM, flex <email address hidden> wrote:

> In termator 0.92, i also found this bug.
> Reproduce:
>
> 1. change the two "built-in schemes" at preferences->profiles->colors to
> custom
> 2. change the background color and color palette, press close.
>
> Then you will find terminator and its config file changed as you wish.
>
> 3. open preferences->profiles->colors menu again, you will find the
> built-in schemes return to the default, after pressing close, both
> terminator and the config file return to default color.
>
> ps: I found that only after you changing the built-in schemes to custom,
> it will return to default. If you change it to other, such as linux, it
> will stay as you wish.
>
> --
> After setting text color in Profiles>Colors, text color defaults to black
> automaticly when changes are made in Profiles.
> https://bugs.launchpad.net/bugs/554440
> You received this bug notification because you are a direct subscriber
> of the bug.
>
> Status in Terminator: Invalid
>
> Bug description:
> After chaging text color settings in Profiles>Colors, the text automaticly
> changes back to default black whenever changes are made to settings under
> Profiles. I can consitently reproduce the bug by changing text color to
> white, then unchecking show title bar.
>
> To unsubscribe from this bug, go to:
> https://bugs.launchpad.net/terminator/+bug/554440/+subscribe
>

Revision history for this message
flex (frostynova) wrote :

At line 384-385 in file terminatorlib/prefseditor.py:

        if palette not in self.palettevalues:
            palette = 'rxvt'

Terminator will read palette from config file, but the custom palette has no value matched with it in the dict

    palettes = {'tango': '#000000000000:#CCCC00000000:#4E4E9A9A0606:\
#C4C4A0A00000:#34346565A4A4:#757550507B7B:#060698209A9A:#D3D3D7D7CFCF:\
#555557575353:#EFEF29292929:#8A8AE2E23434:#FCFCE9E94F4F:#72729F9FCFCF:\
#ADAD7F7FA8A8:#3434E2E2E2E2:#EEEEEEEEECEC',
                'linux': '#000000000000:#AAAA00000000:#0000AAAA0000:\
#AAAA55550000:#00000000AAAA:#AAAA0000AAAA:#0000AAAAAAAA:#AAAAAAAAAAAA:\
#555555555555:#FFFF55555555:#5555FFFF5555:#FFFFFFFF5555:#55555555FFFF:\
#FFFF5555FFFF:#5555FFFFFFFF:#FFFFFFFFFFFF',
                'xterm': '#000000000000:#CDCB00000000:#0000CDCB0000:\
#CDCBCDCB0000:#1E1A908FFFFF:#CDCB0000CDCB:#0000CDCBCDCB:#E5E2E5E2E5E2:\
#4CCC4CCC4CCC:#FFFF00000000:#0000FFFF0000:#FFFFFFFF0000:#46458281B4AE:\
#FFFF0000FFFF:#0000FFFFFFFF:#FFFFFFFFFFFF',
                'rxvt': '#000000000000:#CDCD00000000:#0000CDCD0000:\
#CDCDCDCD0000:#00000000CDCD:#CDCD0000CDCD:#0000CDCDCDCD:#FAFAEBEBD7D7:\
#404040404040:#FFFF00000000:#0000FFFF0000:#FFFFFFFF0000:#00000000FFFF:\
#FFFF0000FFFF:#0000FFFFFFFF:#FFFFFFFFFFFF',
                'ambience': '#2E2E34343636:#CCCC00000000:#4E4E9A9A0606:\
#C4C4A0A00000:#34346565A4A4:#757550507B7B:#060698209A9A:#D3D3D7D7CFCF:\
#555557575353:#EFEF29292929:#8A8AE2E23434:#FCFCE9E94F4F:#72729F9FCFCF:\
#ADAD7F7FA8A8:#3434E2E2E2E2:#EEEEEEEEECEC'}

So it will be set to rxvt...

Revision history for this message
Chris Jones (cmsj) wrote :

flex: thanks for the reproduction steps, I guess my logic for checking if the Custom settings match one of the pre-defined entries, is buggy!

Changed in terminator:
status: Invalid → Confirmed
importance: Undecided → Medium
Revision history for this message
Chris Jones (cmsj) wrote :

This is now fixed in trunk.

Changed in terminator:
status: Confirmed → Fix Committed
assignee: nobody → Chris Jones (cmsj)
Chris Jones (cmsj)
Changed in terminator:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.