[5.0] : Overdue report shows amounts on wrong side and sign.Report needs a layout change.

[Dukai Gábor]

Hi!
5.0 latest bzr.
The overdue payments report prints some of the amounts on the wrong side and with the wrong sign. For example customer invoices are on the debit side with positive sign, while supplier invoices are on the credit side with negative sign. This means if we have a customer invoice 1000EUR and a supplier invoice 1000EUR for the same partner, the partner's due balance will be 2000EUR instead of 0.

I've attached a patch that fixes this problem.

[JMA(Open ERP) (jma-openerp)]

Hello Dukai Gabor,

I created a customer invoice as well as a supplier invoice with the same amount for the same partner.

When I generated the overdue report it worked fine with me and showed me 0 balance.

Could you please provide me more information or screenshot regarding the problem you facing so that I can assist you better.

Thank you.

[Dukai Gábor (gdukai)]

The accounting entries of the customer invoice:
partner receivables acc debit: 1000
income acc credit: 1000

The accounting entries of the supplier invoice:
partner payables acc credit: 1000
expenses acc debit: 1000

See the report output attached.

[Jay Vora (Serpent Consulting Services) (jayvora)]

Hello Dukai,

I would like to suggest a little patch that would resolve all the dissimilarities for Maturity amount.

The root cause was, Debit and credit amounts have worked with signs, but the maturity amount(debit-credit) have to be well-managed.

Would you please let me know whether the patch is appropriate or not?

Thank you for pointing.

[Dukai Gábor (gdukai)]

Hello Jay,

The patch you supplied doesn't solve the problem.

But I have already uploaded a patch with a fix, why don't you use that?

[Jay Vora (Serpent Consulting Services) (jayvora)]

Hello Dukai,

As such, there is no big problem using your patch, I did not use that patch as it uses the condition of receivable(which can be avoided).

However, your patch uses formatLang() and its very much appreciated.

As I mentioned earlier, the only problem is with the maturity amount. It mismanages signs.

Let me know,what part does my patch dissatisfy?

Thanks for your response.

[Dukai Gábor (gdukai)]

Hello Jay,

3 screenshots are attached to this test case:
-wrong.jpeg: the original overdue report
-with_jays_patch.jpeg: the overdue report with your patch (looks the same as the original)
-corrected.jpeg: IMHO the overdue report for the test case described should look like this

[Jay Vora (Serpent Consulting Services) (jayvora)]

Hello Dukai,

Layout-wise I completely agree with you. Thank you for the corrected.jpeg.

I guess ,we need to ask accounting experts as this change leads to a change in report layout(different from what is called convention for now).

Thanks.

[Dukai Gábor (gdukai)]

Attached additional screenshots that show the resulting reports if payments are made, too.

[Jan Verlaan (jan-verlaan)]

Convention? An outstanding supplier invoice listed as "Paid" as is now is not correct.
The proposed correction is needed to reflect the real situation, I can agree to that.
I see it as bugsolving, not a convention change.

[Nhomar - Vauxoo (nhomar)]

I Think.

If you take literally like the link is called:

"Overdue report"

Like Jan Verlaan said:
There are a little problem with conventions:
It means An outstanding supplier invoice listed as "Paid" shouldn't appear
on this report. in other hand this report is factible if the link was
called "Partner Balance".

++ 1 Jan comentary.

2010/3/29 Jan Verlaan (Veritos) <email address hidden>

> Convention? An outstanding supplier invoice listed as "Paid" as is now is
> not correct.
> The proposed correction is needed to reflect the real situation, I can
> agree to that.
> I see it as bugsolving, not a convention change.
>
> --
> [5.0] : Overdue report shows amounts on wrong side and sign.Report needs a
> layout change.
> https://bugs.launchpad.net/bugs/546004
> You received this bug notification because you are subscribed to
> OpenObject.
>
> Status in OpenObject Addons Modules: Confirmed
>
> Bug description:
> Hi!
> 5.0 latest bzr.
> The overdue payments report prints some of the amounts on the wrong side
> and with the wrong sign. For example customer invoices are on the debit side
> with positive sign, while supplier invoices are on the credit side with
> negative sign. This means if we have a customer invoice 1000EUR and a
> supplier invoice 1000EUR for the same partner, the partner's due balance
> will be 2000EUR instead of 0.
>
> I've attached a patch that fixes this problem.
>
>

[Jay Vora (Serpent Consulting Services) (jayvora)]

Hello Experts,

Would you please post your opinion here,so we plan for its solution asap?

Thanks to Dukai, Jan and Nhomar.

[JMA(Open ERP) (jma-openerp)]

Hello Dukai Gabor,

I have changed the layout of the overdue report as per the discussion.

Could you please apply the patch and notify us whether these changes work fine for you.

Thank you.

[Dukai Gábor (gdukai)]

No, I couldn't apply it because I got
patch: **** malformed patch at line 64:

But why did you modify my patch if it was already agreed on by the accounting experts? Why don't you just use it?

[Jay Vora (Serpent Consulting Services) (jayvora)]

Hi Dukai,

We are about to use your patch and will clean(if needed).
Coming back to you soon.

Thanks.

[Jay Vora (Serpent Consulting Services) (jayvora)]

It has been fixed by revision 2729 <email address hidden>.
Thanks.