openshot crashes with cairo development version 1.9.6

[Dr_ST]

I'm providing the Mandriva package for openshot.

Although openshot works fine in latest stable Mandriva 2010 edition, the latest developpment edition known as "cooker" for the future 2010 Spring exhibits an openshot crash at the beginning.

The only reason is the migration from cairo 1.8.10 to 1.9.6 (dev branch).

I have provided a complete description of the version/os and a backtrace on mandriva's bugzilla (https://qa.mandriva.com/show_bug.cgi?id=57815).

The package (rpm) is provided by the distribution (openshot-1.1.1-1mdv2010.1.src.rpm), the distribution is Mandriva Linux 2010 Spring edition (cooker), and openshot is at version 1.1.1 (the same crash appeared with version 1.0 and 1.1).

Just to let you know upstream cairo needs adjustments for openshot (i'm not sure if cairo or openshot is at fault there).

Let me know if you need more info (and great work for giving us another good video editor !).

[Olivier Girard (eolinwen)]

Hum I ve just discovered some few minutes before reading this post than Openshot is in Mandriva in Cooker. It was the last big distribution at not having Openshot. And with the normal version of cair- dock (=stable version and not developpement version) Openshot works well. Great. This is perhaps the developpement version of cairo-dock who crash Openshot.
To be sure that not Openshot, could you try that : http://openshotusers.com/forum/viewtopic.php?f=12&t=180&p=853&hilit=gdb#p853
With gdb, i'm thinking that we could know if the problem comes from Openshot or not and which is the problem too.(if it's a segfault!!).
In all cases, Thanks for all.

[Olivier Girard (eolinwen)]

Aie I have seen the link that you have given and there is already a backstrace by gdb. Sorry for this mistake. and Thanks for the feedback.

[Jonathan Thomas (jonoomph)]

Could you test if the MLT framework works correctly. Give this a try, and
let me know what happens:

$ python
>> import mlt
>> f = mlt.Factory()
>> f.init()

Also, you might want to be sure the "melt" command does not return an error:
$ melt

If any errors are returned, then there is likely a problem with MLT and / or
the Python Swig bindings for MLT. If that works with no errors, then I
would be curious what gdb would return.

Thanks!
-Jonathan

On Mon, Mar 22, 2010 at 1:29 PM, cenwen <email address hidden> wrote:

> Hum I ve just discovered some few minutes before reading this post than
> Openshot is in Mandriva in Cooker. It was the last big distribution at not
> having Openshot. And with the normal version of cair- dock (=stable version
> and not developpement version) Openshot works well. Great. This is perhaps
> the developpement version of cairo-dock who crash Openshot.
> To be sure that not Openshot, could you try that :
> http://openshotusers.com/forum/viewtopic.php?f=12&t=180&p=853&hilit=gdb#p853
> With gdb, i'm thinking that we could know if the problem comes from
> Openshot or not and which is the problem too.(if it's a segfault!!).
> In all cases, Thanks for all.
>
> --
> openshot crashes with cairo development version 1.9.6
> https://bugs.launchpad.net/bugs/544308
> You received this bug notification because you are a member of OpenShot
> Developers, which is subscribed to OpenShot Video Editor.
>
> Status in OpenShot Video Editor: New
>
> Bug description:
> I'm providing the Mandriva package for openshot.
>
> Although openshot works fine in latest stable Mandriva 2010 edition, the
> latest developpment edition known as "cooker" for the future 2010 Spring
> exhibits an openshot crash at the beginning.
>
> The only reason is the migration from cairo 1.8.10 to 1.9.6 (dev branch).
>
> I have provided a complete description of the version/os and a backtrace on
> mandriva's bugzilla (https://qa.mandriva.com/show_bug.cgi?id=57815).
>
> The package (rpm) is provided by the distribution
> (openshot-1.1.1-1mdv2010.1.src.rpm), the distribution is Mandriva Linux 2010
> Spring edition (cooker), and openshot is at version 1.1.1 (the same crash
> appeared with version 1.0 and 1.1).
>
> Just to let you know upstream cairo needs adjustments for openshot (i'm not
> sure if cairo or openshot is at fault there).
>
> Let me know if you need more info (and great work for giving us another
> good video editor !).
>
>
>
> _______________________________________________
> Mailing list: https://launchpad.net/~openshot.developers<https://launchpad.net/%7Eopenshot.developers>
> Post to : <email address hidden>
> Unsubscribe : https://launchpad.net/~openshot.developers<https://launchpad.net/%7Eopenshot.developers>
> More help : https://help.launchpad.net/ListHelp
>

[Jonathan Thomas (jonoomph)]

Haha, I just saw the backtrace also. It looks like the problem is not with
MLT or OpenShot, but rather the cairo-based canvas widget we use: goocanvas
(pygoocanvas). It looks like the solution will probably come from that
project. Good luck!

Here is a link to the goocanvas bug tracker:
https://bugzilla.gnome.org/browse.cgi?product=goocanvas

-Jonathan

On Mon, Mar 22, 2010 at 1:48 PM, cenwen <email address hidden> wrote:

> Aie I have seen the link that you have given and there is already a
> backstrace by gdb. Sorry for this mistake. and Thanks for the feedback.
>
> --
> openshot crashes with cairo development version 1.9.6
> https://bugs.launchpad.net/bugs/544308
> You received this bug notification because you are a member of OpenShot
> Developers, which is subscribed to OpenShot Video Editor.
>
> Status in OpenShot Video Editor: New
>
> Bug description:
> I'm providing the Mandriva package for openshot.
>
> Although openshot works fine in latest stable Mandriva 2010 edition, the
> latest developpment edition known as "cooker" for the future 2010 Spring
> exhibits an openshot crash at the beginning.
>
> The only reason is the migration from cairo 1.8.10 to 1.9.6 (dev branch).
>
> I have provided a complete description of the version/os and a backtrace on
> mandriva's bugzilla (https://qa.mandriva.com/show_bug.cgi?id=57815).
>
> The package (rpm) is provided by the distribution
> (openshot-1.1.1-1mdv2010.1.src.rpm), the distribution is Mandriva Linux 2010
> Spring edition (cooker), and openshot is at version 1.1.1 (the same crash
> appeared with version 1.0 and 1.1).
>
> Just to let you know upstream cairo needs adjustments for openshot (i'm not
> sure if cairo or openshot is at fault there).
>
> Let me know if you need more info (and great work for giving us another
> good video editor !).
>
>
>
> _______________________________________________
> Mailing list: https://launchpad.net/~openshot.developers<https://launchpad.net/%7Eopenshot.developers>
> Post to : <email address hidden>
> Unsubscribe : https://launchpad.net/~openshot.developers<https://launchpad.net/%7Eopenshot.developers>
> More help : https://help.launchpad.net/ListHelp
>

[Dr_ST (steletch)]

Well, if i revert the cairo version to 1.8.8 everything is back so i'm not sure pygoocanvas is at fault. At least be warned that the devel version has problems. I'll try to gid further and provide more info, but the pygoocanvas does not seem to reference segfaults. More info later.

[Jonathan Thomas (jonoomph)]

We do not use cairo directly in OpenShot. However, the reason I suspect it
is the goocanvas widget, is because it is directly based on cairo.
Pygoocanvas is the Python bindings for goocanvas. Thanks!

On Mon, Mar 22, 2010 at 3:15 PM, Dr_ST <email address hidden> wrote:

> Well, if i revert the cairo version to 1.8.8 everything is back so i'm
> not sure pygoocanvas is at fault. At least be warned that the devel
> version has problems. I'll try to gid further and provide more info, but
> the pygoocanvas does not seem to reference segfaults. More info later.
>
> --
> openshot crashes with cairo development version 1.9.6
> https://bugs.launchpad.net/bugs/544308
> You received this bug notification because you are a member of OpenShot
> Developers, which is subscribed to OpenShot Video Editor.
>
> Status in OpenShot Video Editor: New
>
> Bug description:
> I'm providing the Mandriva package for openshot.
>
> Although openshot works fine in latest stable Mandriva 2010 edition, the
> latest developpment edition known as "cooker" for the future 2010 Spring
> exhibits an openshot crash at the beginning.
>
> The only reason is the migration from cairo 1.8.10 to 1.9.6 (dev branch).
>
> I have provided a complete description of the version/os and a backtrace on
> mandriva's bugzilla (https://qa.mandriva.com/show_bug.cgi?id=57815).
>
> The package (rpm) is provided by the distribution
> (openshot-1.1.1-1mdv2010.1.src.rpm), the distribution is Mandriva Linux 2010
> Spring edition (cooker), and openshot is at version 1.1.1 (the same crash
> appeared with version 1.0 and 1.1).
>
> Just to let you know upstream cairo needs adjustments for openshot (i'm not
> sure if cairo or openshot is at fault there).
>
> Let me know if you need more info (and great work for giving us another
> good video editor !).
>
>
>
> _______________________________________________
> Mailing list: https://launchpad.net/~openshot.developers<https://launchpad.net/%7Eopenshot.developers>
> Post to : <email address hidden>
> Unsubscribe : https://launchpad.net/~openshot.developers<https://launchpad.net/%7Eopenshot.developers>
> More help : https://help.launchpad.net/ListHelp
>

[Dr_ST (steletch)]

Hi folks, thanks to our dear developper at Mandriva (aka as the great Teuf), there is a simple fix for this bug (and it will affect all users with a recent cairo version).

The problem comes from the size of the initial window claimed by openhost, it is of 50 000 and the cairo check does not allow a value of more than 32k. Full details are there:
https://qa.mandriva.com/show_bug.cgi?id=57815

Git commit:
http://cgit.freedesktop.org/cairo/commit/?id=67d40e5c7300c4082484dbda5c81808737bb2ac5
(added between 1.9.2 and 1.9.4)

A simple patch is:

--- openshot/windows/MainGTK.py 2010-04-12 05:38:29.000000000 +0200
+++ openshot/windows/MainGTK.py 2010-04-14 17:10:07.853844262 +0200
@@ -98,7 +97,7 @@

                self.MyCanvas = goocanvas.Canvas()
                self.MyCanvas.connect("scroll-event", self.on_scrolledwindow_Right_scroll_event)
- self.MyCanvas.set_bounds (0, 0, 50000, 5000)
+ self.MyCanvas.set_bounds (0, 0, 30000, 5000)
                hboxTimeline.set_border_width(0)
                self.MyCanvas.show()

@@ -106,7 +105,7 @@
                self.TimelineCanvas_Left = goocanvas.Canvas()
                self.TimelineCanvas_Left.connect("scroll-event", self.on_scrolledwindow_Left_scroll_event)
                self.TimelineCanvas_Left.set_size_request (160, 0)
- self.TimelineCanvas_Left.set_bounds (0, 0, 50000, 80) #l, t, r, b
+ self.TimelineCanvas_Left.set_bounds (0, 0, 30000, 80) #l, t, r, b
                self.TimelineCanvas_Left.show()

                self.TimelineCanvas_Right = goocanvas.Canvas()

Applying the fix works in our development tree (cooker) and render openshot usable again.

Time for a 1.1.4 relelase?

[Christophe Fergeau (teuf-gnome)]

The fact that it crashes was also a cairo bug, see https://bugzilla.gnome.org/show_bug.cgi?id=599574#c8 and it was fixed in cairo git. With the cairo patch and with no openshot change, openshot starts up fine too. And I have no idea whether what openshot is doing is a bug or not :-/

[Jonathan Thomas (jonoomph)]

We use a really large goocanvas widget, to allow for many tracks (I think
around 90+ tracks). Goocanvas uses cairo to render. So, reducing the
number from 50,0000 to 30,000 will cause issues for people with lots of
different tracks / composites. I suppose I could have a canvas only the
size of the screen, and then I could handle the scrolling myself... moving
items up and down as you scroll. But that will take time, and I'm not sure
how well that would work.

Thanks,
-Jonathan

On Thu, Apr 15, 2010 at 4:11 AM, Christophe Fergeau <email address hidden> wrote:

> The fact that it crashes was also a cairo bug, see
> https://bugzilla.gnome.org/show_bug.cgi?id=599574#c8 and it was fixed in
> cairo git. With the cairo patch and with no openshot change, openshot
> starts up fine too. And I have no idea whether what openshot is doing is
> a bug or not :-/
>
> ** Bug watch added: GNOME Bug Tracker #599574
> https://bugzilla.gnome.org/show_bug.cgi?id=599574
>
> --
> openshot crashes with cairo development version 1.9.6
> https://bugs.launchpad.net/bugs/544308
> You received this bug notification because you are a member of OpenShot
> Developers, which is subscribed to OpenShot Video Editor.
>
> Status in OpenShot Video Editor: New
>
> Bug description:
> I'm providing the Mandriva package for openshot.
>
> Although openshot works fine in latest stable Mandriva 2010 edition, the
> latest developpment edition known as "cooker" for the future 2010 Spring
> exhibits an openshot crash at the beginning.
>
> The only reason is the migration from cairo 1.8.10 to 1.9.6 (dev branch).
>
> I have provided a complete description of the version/os and a backtrace on
> mandriva's bugzilla (https://qa.mandriva.com/show_bug.cgi?id=57815).
>
> The package (rpm) is provided by the distribution
> (openshot-1.1.1-1mdv2010.1.src.rpm), the distribution is Mandriva Linux 2010
> Spring edition (cooker), and openshot is at version 1.1.1 (the same crash
> appeared with version 1.0 and 1.1).
>
> Just to let you know upstream cairo needs adjustments for openshot (i'm not
> sure if cairo or openshot is at fault there).
>
> Let me know if you need more info (and great work for giving us another
> good video editor !).
>
>
>
> _______________________________________________
> Mailing list: https://launchpad.net/~openshot.developers<https://launchpad.net/%7Eopenshot.developers>
> Post to : <email address hidden>
> Unsubscribe : https://launchpad.net/~openshot.developers<https://launchpad.net/%7Eopenshot.developers>
> More help : https://help.launchpad.net/ListHelp
>

[Dr_ST (steletch)]

Ok, this is an upstream bug on cairo, with latest commits on the cairo git openshot works as usual, no need to alter the code.
Closing this one since this is not an openshot problem but an upstream one (and solved upstream now too).

Sorry for the noise, but at least you'll have the info that Mandriva has a fully working openshot package starting with last september 2010 Mandriva release :-)

Cheers,

Stef

[Dr_ST (steletch)]

Well, the bug is not really closed in fact, the 32k limitation is *imposed* in cairo, so using a larger value (50k) renders openshot unusable (see mandriva bug https://qa.mandriva.com/show_bug.cgi?id=59251).

The default size cannot be above the limit, or strange effects appear.
See the XLIB_COORD_MAX parameter (default is 32767) in http://cgit.freedesktop.org/cairo/tree/src/cairo-xlib-surface.c

Cheers,

Stef