Warning apear in selecting product from sales order line

[Sohan Solanki(sos-Axelor)]

With stable version of addons when i select product from sales order line, it gives message like.
"Conversion from Product UoM Hour to Default UoM PCE is not possible as they both belong to different Category!"
This warning apear only when there are products in database having uom from different categories.(like PC1 has PCE and DEV has day) and there is already uom selected in this sales order line.Warrining apear at the time of searching means before we select any product.

[Jay Vora (Serpent Consulting Services) (jayvora)]

Hello Guys,

Would you please try and apply this patch?

Thanks.

[Stephane Wirtel (OpenERP) (stephane-openerp)]

Jay,

I checked the patch,

1. You add the 'uom' key in the dict but there is already this key with a different value
2. You will pass the same uom.id for the source uom and dest uom.

Now, I have a question, how is it possible to convert some hours in PCE ?

[Jay Vora (Serpent Consulting Services) (jayvora)]

Hi,

The Problem is,the loop checks the value of uom with the instant product_id and it compares its uom with hours(the selected one).

If you generate the situation,you will come to know the issue.

Let me know if you find any trouble.

Thanks.

[Sohan Solanki(sos-Axelor) (sos-axelor)]

Hi,
Patch is working fine and problem get solved
Thanks

[Jay Vora (Serpent Consulting Services) (jayvora)]

Hello Guys,

We may apply this patch currently.

We need more elegant solution for this.

Thanks.

[Michel Loos (loos-michel-external)]

I saw this patch.
1) It did not resolve my problem
2) It has a harmful taste since it seems to talk about the Default UOM and Product UoM which effectively should be the same.
  It is the product UoS that can be different

It feels to me that this should be a fully different subroutine (UoM -> UoS) used only by the sales module
compared to Purchase UoM -> Default UoM (which by the way works fine) used by purchase/stock modules.

Michel Loos
Integration Engineer LATAM South
Phones: [phone] / [phone]
Mobile: [phone]
Fax: [phone]
Av. das Nacoes Unidas, 12495 - 8º andar
CEP 04571-011 - Brooklin - São Paulo
<email address hidden>
www.gemalto.com

________________________________________
From: <email address hidden> [<email address hidden>] On Behalf Of Jay (Open ERP) [<email address hidden>]
Sent: Monday, May 24, 2010 6:31
To: MICHEL-EXTERNAL loos
Subject: [Bug 543976] Re: Warning apear in selecting product from sales order line

Hello Guys,

We may apply this patch currently.

We need more elegant solution for this.

Thanks.

** Patch added: "UoM_Conversion.patch"
   http://launchpadlibrarian.net/49008548/UoM_Conversion.patch

--
Warning apear in selecting product from sales order line
https://bugs.launchpad.net/bugs/543976
You received this bug notification because you are a direct subscriber
of a duplicate bug.

Status in OpenObject Addons Modules: In Progress

Bug description:
With stable version of addons when i select product from sales order line, it gives message like.
"Conversion from Product UoM Hour to Default UoM PCE is not possible as they both belong to different Category!"
This warning apear only when there are products in database having uom from different categories.(like PC1 has PCE and DEV has day) and there is already uom selected in this sales order line.Warrining apear at the time of searching means before we select any product.

To unsubscribe from this bug, go to:
https://bugs.launchpad.net/openobject-addons/+bug/543976/+subscribe

[Jay Vora (Serpent Consulting Services) (jayvora)]

Hello Michel Loos,

This patch prevents the warning to be raised everytime and skips the conversion. It must work.

It is applied on the method which is responsible for conversion.

Does it still throw a warning to you? Kindly make sure you have applied it properly.

Thanks.

[Raphaël Valyi - http://www.akretion.com (rvalyi)]

Hello,

let me comment that this is an important regression on a basic functional scope, I personally don't really understand how this can be considered only "medium" priority, IMHO such regressions should be flagged as "high" at least. I mean there is no point in trying to add features in the "stable" version if the cost is such regressions on the basic scope.

In particular, this regression has been introduced when trying to fix that bug https://bugs.launchpad.net/openobject-addons/+bug/504353
The mentioned patch here is the equivalent of roll-backing the fix for bug #504353, I'm in favor of that as it's better not fixing a bug rather than creating new code that fixes a bug but breaks such a basic feature (at the end of the story you have a bug that is more frequent, you frighten the users who don't expect such a regression on the "stable" version and you have more obscure code to maintain).

[Jay Vora (Serpent Consulting Services) (jayvora)]

It has been fixed by revision 2745 <email address hidden>.
The patch for https://bugs.launchpad.net/openobject-addons/+bug/504353 has been reverted back.
Thanks.