dh_xul-ext fails in dh7 when adding any option

[Alexander Sack]

Binary package hint: mozilla-devscripts

not exactly sure if i am doing something wrong, but adding options to dh $@ seems to make dh_xul-ext become unhappy.

I think we should just consume options we dont really support.

make[1]: Leaving directory `/home/asac/Development/ubuntu/mozillateam/enigmail/builds/enigmail-1.0.1'
   dh_install -O--builddirectory=/home/asac/Development/ubuntu/mozillateam/enigmail/builds/enigmail-1.0.1/objdir-enigmail
   dh_xul-ext -O--builddirectory=/home/asac/Development/ubuntu/mozillateam/enigmail/builds/enigmail-1.0.1/objdir-enigmail
option -O not recognized
Usage: dh_xul-ext [options]

Options:
  -p, --package=<value> calculate substvars only for the specified package

General options:
  -h, --help display this help and exit
  -v, --verbose print more information

See dh_xul-ext(1) for more info.
make: *** [binary] Error 1
dpkg-buildpackage: error: fakeroot debian/rules binary gave error exit status 2
debuild: fatal error at line 1340:
dpkg-buildpackage -rfakeroot -D -us -uc -b failed

[Alexander Sack (asac)]

kinda blocks enigmail ... can we get this fixed quick or do i need to drop --builddirectory for the time being?

[Benjamin Drung (bdrung)]

Should it just ignore all unknown options? Should it warn or only print an information on verbose mode?

[Alexander Sack (asac)]

i dont know. I would think it can safely ignore options it doesnt support. If it invokes a dh_ helper on its own it should append the opts though ...

[Alexander Sack (asac)]

well.. unless dh_xul-ext needs to know about builddir ... which isnt the case i would think.

[Benjamin Drung (bdrung)]

Please test the committed fix.

[Launchpad Janitor (janitor)]

This bug was fixed in the package mozilla-devscripts - 0.21

---------------
mozilla-devscripts (0.21) unstable; urgency=low

  [ Micah Gersten <email address hidden> ]
  * xulapp.mk:
    - add testing and tools directory to clean target for xulrunner-1.9.2
      build system
      - update src/xulapp.mk.in

  [ Benjamin Drung <email address hidden> ]
  * add new xpi-repack script
    - add man/xpi-repack.1
    - add src/xpi-repack
    - update src/Makefile
  * Install extensions into xul-ext subdirectory; thanks to Daniel Kahn Gillmor
    for the patch.
    - update src/install-xpi
  * Use optparse instead of getopts and ignore unknown options (LP: #543862).
    - update man/dh_xul-ext.1
    - update src/dh_xul-ext
  * Use optparse instead of getopts.
    - update src/install-xpi
  * install-xpi will create a system preference file in /etc; add
    --disable-system-prefs to disable the new behavior (Closes: #558490,
    LP: #535544)
    - update man/install-xpi.1
    - update src/install-xpi
    - update src/xpi.mk
 -- Benjamin Drung <email address hidden> Mon, 12 Apr 2010 12:05:33 +0100