Translation template jobs should keep history
Bug #536819 reported by
Jeroen T. Vermeulen
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Launchpad itself |
Fix Released
|
High
|
Jeroen T. Vermeulen |
Bug Description
There is no "build" property in IBuildFarmJob, but somehow some things in Soyuz do seem to rely on it—notably builder-index.pt (see bug 536797).
Related branches
lp:~jtv/launchpad/buildfarmjob-getspecificjob-translationtemplatesbuild
- Michael Nelson (community): Approve (code)
-
Diff: 77 lines (+26/-0)3 files modifiedlib/lp/translations/configure.zcml (+6/-0)
lib/lp/translations/model/translationtemplatesbuild.py (+10/-0)
lib/lp/translations/tests/test_translationtemplatesbuild.py (+10/-0)
lp:~jtv/launchpad/536819-display
- Paul Hummer (community): Approve (ui)
- Henning Eggers (community): Approve (ui*)
- Graham Binns (community): Approve (code)
-
Diff: 1574 lines (+860/-253)18 files modifieddatabase/sampledata/current-dev.sql (+160/-100)
database/sampledata/current.sql (+170/-100)
database/schema/patch-2208-13-0.sql (+1/-1)
lib/lp/buildmaster/interfaces/buildfarmjob.py (+10/-1)
lib/lp/buildmaster/interfaces/packagebuild.py (+0/-6)
lib/lp/buildmaster/model/buildfarmjob.py (+4/-1)
lib/lp/code/browser/branch.py (+14/-0)
lib/lp/registry/interfaces/productseries.py (+1/-10)
lib/lp/soyuz/browser/configure.zcml (+0/-7)
lib/lp/translations/browser/configure.zcml (+18/-1)
lib/lp/translations/browser/tests/test_translationtemplatesbuild.py (+84/-0)
lib/lp/translations/browser/translationtemplatesbuild.py (+63/-0)
lib/lp/translations/interfaces/translationtemplatesbuild.py (+11/-1)
lib/lp/translations/model/translationtemplatesbuild.py (+46/-10)
lib/lp/translations/model/translationtemplatesbuildjob.py (+5/-1)
lib/lp/translations/stories/buildfarm/xx-build-summary.txt (+89/-4)
lib/lp/translations/templates/translationtemplatesbuild-index.pt (+133/-0)
lib/lp/translations/tests/test_translationtemplatesbuild.py (+51/-10)
Changed in soyuz: | |
status: | New → Triaged |
importance: | Undecided → High |
tags: |
added: qa-ok removed: qa-needstesting |
Changed in rosetta: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
How to refactor the UI to present multiple build types has not yet been thought through thoroughly. Adding IBuildFarmJob.build is probably not the right way to do it, since TTBJs don't have a build.