Builder pages break for job without build

[Jeroen T. Vermeulen]

On my dev system, after trying to dispatch a TranslationTemplatesBuildJob (which does not have a "build" attribute) to a buildd slave, the builders index and the index for Bob the builder oops out.

The problem in both cases happens in a piece of TAL in builder-index.pt that accesses job/specific_job/build. AFAIK there's nothing in the interfaces to say that specific_job needs to have a build attribute. We should add it to the right interface, and either allow it to be None or abstract away its UI so we can show different but sensible information for different job types.

[Julian Edwards (julian-edwards)]

This is a dupe I think, we know that the UI needs fixing.

[Jeroen T. Vermeulen (jtv)]

This probably falls under a wider existing bug, but this is a very specific problem: two pages that oops out as I try to integration-test our buildfarm work. It's easy enough to make them not oops out, even if that doesn't change the fact that UI needs fixing.

AFAICS a minimal, ugly fix that would let me continue my work would involve:
 * Providing a "build" property in BuildFarmJob, defaulting to None.
 * Making the first part of builder-index.pt that depends on job/specific_job/build conditional on there being one.
 * Making the second part, which shows the logs, conditional on something else than the user's viewing rights for the build (or bypassing the access check for buildless jobs).

[Michael Nelson (michael.nelson)]

I think the latter two options for the moment. This will allow the builder to display current translation jobs too. Jeroen has a branch that does this:

09:52 < noodles775> jtv: so you've got a branch that ensures the builder-index doesn't oops for jobs without builds?
09:52 < jtv> noodles775: yes

But long-term, we need to remove the builder history dependency on builds, as otherwise we will have no history of such translation jobs that have run on the builders.

Currently the builders rely on build records to display the history of activity. I'm guessing we'll need to update that to instead use BuildFarmJobs for the history, and ensure that we keep those around for some time. That is a separate bug 491330.

[Ursula Junque (ursinha)]

Fixed in stable r10536 <http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/10536>