Implement an IHasBugHeat interface

[Deryck Hodge]

I've done a hackish fix to have a method return None on max_bug_heat for IPerson to fix a failing test, but this needs a proper fix. This bug is a reminder that this should be done ASAP after 10.02.

Updated: We should create an IHasBugHeat interface per the comment suggestions on this bug.

[Tim Penhey (thumper)]

On Mon, 01 Mar 2010 17:17:09 Deryck Hodge wrote:
> Public bug reported:
>
> I've done a hackish fix to have a method return None on max_bug_heat for
> IPerson, but this needs a proper fix with a DB patch. This bug is a
> reminder that this should be done ASAP after 10.02.

I strongly suggest that you don't do this unless there is a really good reason
for a person or team to have a max_bug_heat.

Instead change the interface of IHasBugs as mentioned in the code review.

[Björn Tillenius (bjornt)]

On Mon, Mar 01, 2010 at 08:21:18AM -0000, Tim Penhey wrote:
> On Mon, 01 Mar 2010 17:17:09 Deryck Hodge wrote:
> > Public bug reported:
> >
> > I've done a hackish fix to have a method return None on max_bug_heat for
> > IPerson, but this needs a proper fix with a DB patch. This bug is a
> > reminder that this should be done ASAP after 10.02.
>
> I strongly suggest that you don't do this unless there is a really
> good reason for a person or team to have a max_bug_heat.

I agree. Think of the UI if this is done. You look at your listing and
see a bug that looks really hot. Now you click on it, go to the bug
page, and suddenly it's not hot anymore, because it's not hot in the
project context?

[Graham Binns (gmb)]

I'm not convinced that an IPerson should have a max_heat value; it
doesn't make sense to have a Person as a heat context.

It would make more sense to me (and wouldn't required a DB patch) to
have an IHasBugHeat interface which carries the max_heat field.
IProduct, IDistribution, IDistributionSeries and
IDistributionSourcePackage(?) would descend from IHasBugHeat; IPerson
shouldn't.

[Jonathan Lange (jml)]

On Mon, Mar 1, 2010 at 5:03 AM, Graham Binns <email address hidden> wrote:
> I'm not convinced that an IPerson should have a max_heat value; it
> doesn't make sense to have a Person as a heat context.
>
> It would make more sense to me (and wouldn't required a DB patch) to
> have an IHasBugHeat interface which carries the max_heat field.
> IProduct, IDistribution, IDistributionSeries and
> IDistributionSourcePackage(?) would descend from IHasBugHeat; IPerson
> shouldn't.

Why descend? Why not adapt?

jml

[Graham Binns (gmb)]

On 1 March 2010 10:12, Jonathan Lange <email address hidden> wrote:
> Why descend? Why not adapt?

Actually, no reason at all that I can think of. I was just thinking
out loud; adapting should do the job fine.

[Deryck Hodge (deryck)]

In the cold light or morning, I realize this is a bad idea. I was originally going back and forth on if a person should have heat, and filed the bug more as a "fix this right" bug than a "make person have heat" bug, even though the bug gives no indication of this. I agree, though, that the interface should change for all the reasons cited here.

[Eleanor Berger (intellectronica)]

When this bug is fixed, there's a related XXX we need to fix in lip/lp/bugs/browser/bugtask.py#BugListingBatchNavigator._getListingItem

[Ursula Junque (ursinha)]

Fixed in stable r10580 <http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/10580>