eid prompt /<regexp> functionality broken

[Bruce Edge]

Binary package hint: id-utils

$> eid MAX_NUM_DEVICE_EEPROM
MAX_NUM_DEVICE_EEPROM ../dev_common_defines.h ../dev_test_eeprom_impl.c
edit? [y1-9^S/nq] /test
edit? [y1-9^S/nq] /dev
edit? [y1-9^S/nq] q

The above "/test" should have opened vi on dev_test_eeprom_impl.c
The "/dev" should have opened the first file.
The "/" syntax stated that it will edit the first file that matches the following regex.
Instead it just re-issues the prompt.
This has been broken a long time in debian and ubuntu.

Here's a patch:

--- src/lid.c.orig 2006-02-28 15:06:27.000000000 -0800
+++ src/lid.c 2006-02-28 15:14:11.000000000 -0800
@@ -1069,11 +1069,18 @@
   char const *s1p;
   char const *s2p;
   char const *s1last;
+ char a, b;

- for (s1last = &s1[strlen (s1) - strlen (s2)]; s1 <= s1last; s1++)
- for (s1p = s1, s2p = s2; TOLOWER (*s1p) == TOLOWER (*s2p); s1p++)
- if (*++s2p == '\0')
- return (char *) s1;
+ for (s1last = &s1[strlen (s1) - strlen (s2)]; s1 <= s1last; s1++) {
+ s1p = s1;
+ s2p = s2;
+ for (a = TOLOWER(*s1p), b = TOLOWER(*s2p); a == b; s1p++) {
+ a = TOLOWER(*s1p);
+ b = TOLOWER(*s2p);
+ if (*++s2p == '\0')
+ return (char *) s1;
+ }
+ }
   return 0;
 }

[Vassilis Pandis (pandisv)]

Forwarded to Debian ... Thanks for reporting this.

[Vassilis Pandis (pandisv)]

Is this your own patch or taken from upstream ? If you wrote it, we could forward it upstream as they'll surely be interested in it ...

[Bruce Edge (bruce-edge)]

It's mine.

Thanks, Bruce

On 9/8/06, Vassilis Pandis <email address hidden> wrote:
>
> Is this your own patch or taken from upstream ? If you wrote it, we
> could forward it upstream as they'll surely be interested in it ...
>
> --
> eid prompt /<regexp> functionality broken
> https://launchpad.net/bugs/52655
>

[Jérôme Guelfucci (jerome-guelfucci-deactivatedaccount)]

Do you still have this issue with the latest stable release of Ubuntu ?

[Bruce Edge (bruce-edge)]

Unfortunatey, yes:

0 %> eid STATUS_OK
STATUS_OK ../../Common/Include/ssp_errno.h
../../SAC/PTSac/soap/PAMAuth.h
../../Apps/SOAP/{authMgr,soapUtil,soapXML}.cpp
../../SAC/PTSac/soap/PAMAuth.cpp
edit? [y1-9^S/nq] /Auth
edit? [y1-9^S/nq] /PAMA
edit? [y1-9^S/nq]

On 7/3/07, Jérôme Guelfucci <email address hidden> wrote:
>
> Do you still have this issue with the latest stable release of Ubuntu ?
>
> ** Changed in: id-utils (Ubuntu)
> Importance: Undecided => Low
> Status: New => Incomplete
>
> --
> eid prompt /<regexp> functionality broken
> https://bugs.launchpad.net/bugs/52655
> You received this bug notification because you are a direct subscriber
> of the bug.
>

[Jérôme Guelfucci (jerome-guelfucci-deactivatedaccount)]

This should be fixed in Gutsy.