regression: wild copy of context that can actually be None in ir_model.py

[Raphaël Valyi - http://www.akretion.com]

Hello,

In commit #1963 of server 5.0, you changed code inside the ir.model#create method.
Now you do a brutal context.copy() while by default the optional context argument is set to None in the create method signature (around line 83).
One of the examples where it breaks existing code is the Magento Connector magentoerpconnect module , but it's easy to imagine it could easily break in many other cases.
So please do a defensive check of the context before assuming it's not None or either set it to {} by default, I don't know what is better, but the current code is flawed, that's for sure.

Hope this helps

[Jay Vora (Serpent Consulting Services) (jayvora)]

You were right Raphael.
Its rare, but it was needed to be fixed.
Fixed by revision 1985 <email address hidden>.
Thank you.

[Raphaël Valyi - http://www.akretion.com (rvalyi)]

Thanks

On Tue, Feb 23, 2010 at 3:06 AM, Jay (Open ERP) <email address hidden> wrote:

> You were right Raphael.
> Its rare, but it was needed to be fixed.
> Fixed by revision 1985 <email address hidden>.
> Thank you.
>
>
> ** Changed in: openobject-server
> Status: Confirmed => Fix Released
>
> --
> regression: wild copy of context that can actually be None in ir_model.py
> https://bugs.launchpad.net/bugs/525962
> You received this bug notification because you are a direct subscriber
> of the bug.
>
> Status in OpenObject Server: Fix Released
>
> Bug description:
> Hello,
>
> In commit #1963 of server 5.0, you changed code inside the ir.model#create
> method.
> Now you do a brutal context.copy() while by default the optional context
> argument is set to None in the create method signature (around line 83).
> One of the examples where it breaks existing code is the Magento Connector
> magentoerpconnect module , but it's easy to imagine it could easily break in
> many other cases.
> So please do a defensive check of the context before assuming it's not None
> or either set it to {} by default, I don't know what is better, but the
> current code is flawed, that's for sure.
>
> Hope this helps
>
> To unsubscribe from this bug, go to:
> https://bugs.launchpad.net/openobject-server/+bug/525962/+subscribe
>