Menus updated at runtime aren't rendered correctly

[Travis B. Hartwell]

(This information is a copy of a recent mail I sent)

I still am having problems with Gnome Bluetooth. I would guess the
problem is somehow in an interaction with app indicators, since the
menus are created just fine in the GtkStatusIcon version.

A picture is probably the best description of what is wrong, so I'll
attach screenshots showing the correct rendering (from
bluetooth-applet using a GtkStatusIcon) and the rendering that app
indicators currently use.

In parts of the code, it hides various menu entries for the
devices as they are discovered not to have certain capabilities, but
for some reason this isn't being reflected in the indicator applet.

Ted suggested I see what dbusmenu-dumper is showing, so I ran the
following command:

usr/lib/libdbusmenu/dbusmenu-dumper
--dbus-name=org.gnome.Bluetooth.applet
--dbus-object=/org/ayatana/NotificationItem/bluetooth_manager/Menu

I'll attach the output of this command. From the output, I can see
the menu is certainly displaying what it got, so there is something
going on before it is transferred across dbus.

I'll attach my current patch for Gnome Bluetooth, which is against
version 2.29.91, which is what is currently in Lucid. The executable
to test is applet/bluetooth-applet. The code that is important to
look at:

applet/notify.c
applet/main.c

All of the menu related stuff is in main.c.

Let me know if there is anything I can do to help out or give you
further information.

I'll attach additional information (screenshots, patches, and
debugging output) after creating the bug.

[David Barth (dbarth)]

Cody, can you help unblock Travis on this one? Thanks

[Cody Russell (bratsche)]

Yeah, looks fine although I don't have time to test it. Presumably the same thing should happen with the "add" and "remove" callbacks that are set in app_indicator_set_menu()? Right now it's just rebuilding the whole menu, which was a quick hack thrown in there.

[Jan Arne Petersen (jpetersen)]

Additionally fixes setting the visibility property correctly.

[Jan Arne Petersen (jpetersen)]

Seems to be fixed now.