rdiff-backup crashed with NameError in test_connection()

[Matthew Paul Thomas]

Binary package hint: rdiff-backup

Apport says:

ProblemType: Crash
Architecture: i386
Date: Thu Feb 18 18:25:03 2010
DistroRelease: Ubuntu 10.04
ExecutablePath: /usr/bin/rdiff-backup
InterpreterPath: /usr/bin/python2.6
LiveMediaBuild: Ubuntu 10.04 "Lucid Lynx" - Alpha i386 (20100113)
NonfreeKernelModules: wl
Package: rdiff-backup 1.2.8-5ubuntu1
ProcAttrCurrent: unconfined (enforce)
ProcCmdline: /usr/bin/python /usr/bin/rdiff-backup --remote-schema ssh\ -i\ /var/lib/millbackup/sshid\ -C\ %s\ rdiff-backup\ --server --test-server <email address hidden>::/srv/backups/matthew.paul.thomas//home
ProcEnviron:
 SHELL=/bin/sh
 PATH=(custom, no user)
 LANG=en_GB.UTF-8
 LANGUAGE=en_GB:en
ProcVersionSignature: Ubuntu 2.6.32-13.18-generic
PythonArgs: ['/usr/bin/rdiff-backup', '--remote-schema', 'ssh -i /var/lib/millbackup/sshid -C %s rdiff-backup --server', '--test-server', '<email address hidden>::/srv/backups/matthew.paul.thomas//home']
SourcePackage: rdiff-backup
Title: rdiff-backup crashed with NameError in test_connection()
Uname: Linux 2.6.32-13-generic i686
UserGroups:

[Andreas Olsson (andol)]

I can confirm this problem using rdiff-backup 1.2.8-5ubuntu1 with the parameter --test-server.

[Andreas Olsson (andol)]

Haven taken a closer look at the issue I think I have got it pinned down.

In rdiff-backup 1.2.7-1ubuntu2 (jaunty) the patch 01_fix_restricted_test-server_option.dpatch was added, to fix bug #349072.

In the Debian version rdiff-backup 1.2.8-4 a reimplemented version of the same patch was included, with the minor difference of it also removing the line "version = conn.Globals.get('version')" from the end of rdiff_backup/SetConnections.py. When rdiff-backup 1.2.8-5ubuntu1 was merged from Debian the modified version of the patch was used, resulting in this issue.

Rebuilding rdiff-backup 1.2.8-5ubuntu1, with the original patch, solves this bug.

Before I upload a debdiff I'll check with the Debian maintainer if that line removal was a mistake, or if it actually has a purpose.

[Andreas Olsson (andol)]

Yes, this was an accidental line removal in Debian. I'm uploading a debdiff which restores 01_fix_restricted_test-server_option.dpatch to its proper state.

This debdiff also modifies XSBC-Original-Maintainer, to reflect the current Debian maintainer.

Note that Debian has fixed this issue in rdiff-backup 1.2.8-5+b2. Future Ubuntu merges/syncs should be able to discard this delta.

[StefanPotyra (sistpoty)]

looks good, uploading. Thanks!

[Launchpad Janitor (janitor)]

This bug was fixed in the package rdiff-backup - 1.2.8-5ubuntu2

---------------
rdiff-backup (1.2.8-5ubuntu2) lucid; urgency=low

  * Restoring proper 01_fix_restricted_test-server_option.dpatch (LP: #524070)
 -- Andreas Olsson <email address hidden> Sat, 20 Feb 2010 13:41:56 +0100