Get rid of the vim mode lines at the end of each file
Bug #522708 reported by
Numérigraphe
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Odoo Addons (MOVED TO GITHUB) |
Invalid
|
Undecided
|
Unassigned | ||
Odoo Server (MOVED TO GITHUB) |
Invalid
|
Undecided
|
Unassigned |
Bug Description
Wishlist: Remove the VIM directives at the end of each file:
# vim:expandtab:
To my knowledge, the only use for this is to render the file properly in the VIM editor.
We shouldn't do that: it's not the source code's concern to configure the text editor.
This is a practice of another age.
If you can't get VIM to show the source properly, then you should use another editor.
Lionel.
summary: |
- Get rid of the vim directives at the end of each file + Get rid of the vim mode lines at the end of each file |
Changed in openobject-addons: | |
status: | New → Won't Fix |
To post a comment you must log in.
I don't believe it hurts anything (or anyone) to have these directives, and they're useful to vim users. What's the problem exactly?
> We shouldn't do that: it's not the source code's concern to configure the text editor.
Actually, these hints are very useful as they ensure a modicum of respect for the project's conventions, even for people who might have different conventions on other projects (and have configured their editor for those settings).
> If you can't get VIM to show the source properly, then you should use another editor.
I believe it's more about ensuring non-broken edits than about properly showing files, I'd certainly expect VI to display python files correctly even without any hint.