Please upgrade source-highlight-qt to 0.2.1-0ubuntu1

[Angel Abad]

The upstream author advises to update to 0.2.1. The source can be downloaded from: http://sourceforge.net/projects/srchiliteqt/files/

I attach a diff.gz with the upgrade, please upload it.

Thanks!

[Cesare Tirabassi (norsetto)]

1. There is no need to move the Name field in copyright
2. You should add a short list of the new features of this release in changelog
3. Versions for source-highlight and libsource-highlight-dev should be bumped in control
4. Pls. make sure that Copyright entries in copyright are properly aligned
5. Few files in this release are missing a copyright header. You should inform upstream.
6. There is at least a new copyright owner to be listed in copyright, there is also at least a new file which is not licensed under the GPL
7. Upstream updated its copyright date to 2010 (at least in one file)
8. Current Standards-Version is 3.8.4
9. I don' t think you have you done any testing of the package? There are plenty of test cases in the tarball and perhaps you will find some problems ...

[Angel Abad (angelabad)]

Hi Cesare, thanks for your care.

1. There is no need to move the Name field in copyright

Sorry, this was an error, fixed

2. You should add a short list of the new features of this release in changelog

According Debian/Ubuntu Policy[1] this file is for changes in package, not for changes in the
upstream source, for this purpose is the upstream's changelog file.

3. Versions for source-highlight and libsource-highlight-dev should be bumped in control

Why this? It depends on the same version PKG_CHECK_MODULES(SRCHILITE, [source-highlight >= 3.1.1])

4. Pls. make sure that Copyright entries in copyright are properly aligned

Ok, Fixed

5. Few files in this release are missing a copyright header. You should inform upstream.

Ok, I will inform him.

6. There is at least a new copyright owner to be listed in copyright, there is also at least a new file which is not licensed under the GPL

I ran licensecheck and I dont find any files with other license than GPL or with other owners.
And the AUTHORS file only list one upstream author

7. Upstream updated its copyright date to 2010 (at least in one file)

Ok, Fixed

8. Current Standards-Version is 3.8.4

Ok Fixed

9. I don' t think you have you done any testing of the package? There are plenty of test cases in the tarball and perhaps you will find some problems ...

I passed standard checks with make check tests and I have this output:

==================
All 5 tests passed
==================

[1] http://people.canonical.com/~cjwatson/ubuntu-policy/policy.html/ch-source.html#s-dpkgchangelog

Best Regards,

[Cesare Tirabassi (norsetto)]

>According Debian/Ubuntu Policy[1] this file is for changes in package, not for changes in the
>upstream source, for this purpose is the upstream's changelog file.

When you have an upstream update to a package, it is a good practice to list its highlight in the changelog. Remember that the Debian/Ubuntu changelog is the only thing visible to an user before deciding to install.
Also, it will be good to have it for traceability.

>Why this? It depends on the same version PKG_CHECK_MODULES(SRCHILITE, [source-highlight >= 3.1.1])

Thats indeed why, build-depends have to be in accordance to the need of the source package (otherwise, amongst other things, you screw up backports).

>I ran licensecheck and I dont find any files with other license than GPL or with other owners.

Never only rely on licensecheck or any other tool. If you actually take the time to check all the sources (or the diff w.r.t. the previous release) you will find the file I'm talking about. Beside, you REALLY need to check the diff w.r.t. a previous release to do a proper update. How can you update the packaging if you don' t know what was changed upstream!?

>I passed standard checks with make check tests

Is somebody using this package doing a make check or actually using it? A make check can spot problems due to a different build environment, not the problems that an eventual user may be facing.

BTW, you also need to add a closure tag for this bug in the changelog.

[Angel Abad (angelabad)]

Hi Cesare, sorry for my delay, my laptop crashed. I will try to fix this issues soon.

Thanks!

[Cesare Tirabassi (norsetto)]

Its too late Angel, we are past the freeze date now.

[Angel Abad (angelabad)]

Opps! Sorry, is true, I will try for the next release :-D