Fraction of second in time counter

[Irwin J. Céspedes B]

I think that it would be nice to integrate Fraction of second to the time counter, it would bring more precision to the cue search.
Also it is a nice addon for the interface

[RJ Skerry-Ryan (rryan)]

Maybe this could be packaged into a point release for 1.8.x but 1.8.0 is past feature freeze. This is a good starter project for someone to get involved in Mixxx programming.

[Sean M. Pappalardo (pegasus-renegadetech)]

Would we want to display hundredths of a second (h:MM:SS.HH e.g. 04:35.89) or frames (for some definition of frame...on CDs, there are 75 frames per second, e.g. the above value becomes 04:35:67 in MM:SS:FF format.)
It makes sense to perhaps use the size of the sound buffers as the frame size (so the number of frames/sec would vary with the latency setting, but would be sensible for stutter cueing, see bug #365388.)

[Irwin J. Céspedes B (cespedesbirwin)]

There it is, I wait for you wether this is succesful, or it needs more polishment :-)

[Irwin J. Céspedes B (cespedesbirwin)]

Sorry because I have never worked with BZR, but now I do BZR. This is the patch.

[RJ Skerry-Ryan (rryan)]

Hey Irwin,

Thanks for the patch. I'll try to get to it sometime before our feature freeze this weekend. (It hasn't been committed yet, so marking it 'In Progress')

Regards,
RJ

[Irwin J. Céspedes B (cespedesbirwin)]

Repatched. Now, I changed the letters. Instead of print "Pos:, Rem:, Dur:" it says "E: (Elapsed); R: (Remain) and T: (Total Time)"

A screenshot will clarify this :-)

[Irwin J. Céspedes B (cespedesbirwin)]

This is the patch

[Irwin J. Céspedes B (cespedesbirwin)]

Sorry, a Typo. This "is" the patch2

[Albert Santoni (gamegod)]

Hi Irwin,

The labels get cut off for me (see screenshot).

Did you patch the skin.xml for outlineNetbook?

I checked CPU usage against trunk and it's about the same on Ubuntu.

Thanks,
Albert

[Irwin J. Céspedes B (cespedesbirwin)]

I exactly did that. I had to patch "skin.xml" in order to fix the timers
position.

On Tue, Nov 16, 2010 at 6:43 PM, Albert Santoni <email address hidden> wrote:

> Hi Irwin,
>
> The labels get cut off for me (see screenshot).
>
> Did you patch the skin.xml for outlineNetbook?
>
> I checked CPU usage against trunk and it's about the same on Ubuntu.
>
> Thanks,
> Albert
>
> ** Attachment added: "Screenshot-Mixxx mixxx.png"
>
> https://bugs.launchpad.net/mixxx/+bug/517779/+attachment/1735538/+files/Screenshot-Mixxx%20mixxx.png
>
> --
> Fraction of second in time counter
> https://bugs.launchpad.net/bugs/517779
> You received this bug notification because you are a direct subscriber
> of the bug.
>
> Status in Mixxx: In Progress
> Status in Mixxx 1.9 series: In Progress
>
> Bug description:
> I think that it would be nice to integrate Fraction of second to the time
> counter, it would bring more precision to the cue search.
> Also it is a nice addon for the interface
>
> To unsubscribe from this bug, go to:
> https://bugs.launchpad.net/mixxx/+bug/517779/+subscribe
>

--

*No violence, gentlemen -- no violence, I beg of you! Consider the
furniture! ~ Sherlock Holmes*

[Irwin J. Céspedes B (cespedesbirwin)]

Yes, I had to patch "skin.xml" in order to fix the timers position.

[Albert Santoni (gamegod)]

Can you please attach a patch for the outlineNetbook skin.xml?

If we want this to go in 1.9, we have to update the skin.xml files for
all the other skins too...

Thanks,
Albert

On Tue, Nov 16, 2010 at 12:21 PM, Irwin Céspedes B
<email address hidden> wrote:
> I exactly did that. I had to patch "skin.xml" in order to fix the timers
> position.
>
> On Tue, Nov 16, 2010 at 6:43 PM, Albert Santoni <email address hidden>
> wrote:
>
>> Hi Irwin,
>>
>> The labels get cut off for me (see screenshot).
>>
>> Did you patch the skin.xml for outlineNetbook?
>>
>> I checked CPU usage against trunk and it's about the same on Ubuntu.
>>
>> Thanks,
>> Albert
>>
>> ** Attachment added: "Screenshot-Mixxx mixxx.png"
>>
>> https://bugs.launchpad.net/mixxx/+bug/517779/+attachment/1735538/+files/Screenshot-Mixxx%20mixxx.png
>>
>> --
>> Fraction of second in time counter
>> https://bugs.launchpad.net/bugs/517779
>> You received this bug notification because you are a direct subscriber
>> of the bug.
>>
>> Status in Mixxx: In Progress
>> Status in Mixxx 1.9 series: In Progress
>>
>> Bug description:
>> I think that it would be nice to integrate Fraction of second to the time
>> counter, it would bring more precision to the cue search.
>> Also it is a nice addon for the interface
>>
>> To unsubscribe from this bug, go to:
>> https://bugs.launchpad.net/mixxx/+bug/517779/+subscribe
>>
>
>
> --
>
> *No violence, gentlemen -- no violence, I beg of you! Consider the
> furniture! ~ Sherlock Holmes*
>
> --
> Fraction of second in time counter
> https://bugs.launchpad.net/bugs/517779
> You received this bug notification because you are a member of Mixxx
> Development Team, which is subscribed to Mixxx.
>

[Irwin J. Céspedes B (cespedesbirwin)]

In that case, the skins that need to be fixed are the official ones. At least, in my Workstation, official skins are almost completely patched. Now, when is exactly the "Feature Freeze"? in order to fix the skins and attach the patch.

[Irwin J. Céspedes B (cespedesbirwin)]

I patched the Official skins. This is the patch. Just, I discovered that trunk's skins are kind different of the ones I use, which are the ones packaged by you. But, they work OK.

[Albert Santoni (gamegod)]

Thanks Irwin! I've just committed a tweaked version of your first patch to trunk.

Jus is going to check the skin adjustments and review those before 1.9.

[Albert Santoni (gamegod)]

Also, for the record, when I tested performance of this code against trunk, I did not have the <NumberPos> ---> visual_playposition changes in my skin.xml. I should retest this...

[jus (jus)]

Tested with trunk.

The caption shows always "E:" no matter what you have in preferences (Remaining/Position).

Also the duration shows always ".00" for milliseconds even if tracks have a different duration (tested with VLC/iTunes).
Maybe Mixxx doing some rounding here?

[Irwin J. Céspedes B (cespedesbirwin)]

Well, according to some Math stuff that I saw, yes Mixxx do round the audio into Cents. So, no matter what song you put it always will show 00:00.00, Dunno why this happens. But I have my ideas. One maybe "math.cpp" or "mixxxutils.cpp". But, both are looking good. Secondly, The "E:" stuff, do work well on my Build, but I will download the new revision of trunk and I will check it.

[Irwin J. Céspedes B (cespedesbirwin)]

I've changed the "E:" thing because the "E:" and "R:" captions have been changed for an unified timer. This is better, I suppose. With this patch, the "E:" is replaced by a "T:" standing for "Time"

BTW, the skins bundled here are not working well, so maybe I thing the need to change the "playposition" for "visual_playposition" in the Timer code in skin.xml. If you need it, I will patch it or wait for jus instructions.

[Albert Santoni (gamegod)]

I've just removed the "E:" in trunk, because it's maybe not the
easiest thing to localize.

On Mon, Nov 22, 2010 at 2:14 PM, Irwin Céspedes B
<email address hidden> wrote:
> I've changed the "E:" thing because the "E:" and "R:" captions have been
> changed for an unified timer. This is better, I suppose.  With this
> patch, the "E:" is replaced by a "T:" standing for "Time"
>
> BTW, the skins bundled here are not working well, so maybe I thing the
> need to change the "playposition" for "visual_playposition" in the Timer
> code in skin.xml. If you need it, I will patch it or wait for jus
> instructions.
>
> ** Patch added: "T: patch"
>   https://bugs.launchpad.net/mixxx/1.9/+bug/517779/+attachment/1742008/+files/patch.diff
>
> --
> Fraction of second in time counter
> https://bugs.launchpad.net/bugs/517779
> You received this bug notification because you are a member of Mixxx
> Development Team, which is subscribed to Mixxx.
>

[Irwin J. Céspedes B (cespedesbirwin)]

All right. Now, according to the Time stuff, I think that Mixxx math rounds time by default, because of its mathematical "algo" . I was considering "wnumberpos.cpp" and where I correct the timer, the Formula tends to round every single input. Maybe needs a little refinement, or, an intelligent "algo" You'll decide.

So for me, the mission is accomplished, though I'll continue watching/checking the code. Thanks to everybody here. This is a remarkable experience, for a ESL Teacher, who tried to code as you do.

[Swiftb0y (swiftb0y)]

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/5306