banshee helper reloading / recreating icon too much

[Chris S.]

I was debugging some other code, and I added a debug line right before we create a new pixbuf from a file. I also happen to be using the banshee helper, and was playing music when I started docky. I noticed that every ~1s docky was loading a new file (which includes all of the overhead of creating a new pixbuf) at /tmp/docky_.._banshee_helper.png.

I briefly looked over the banshee helper, and it seems that "def get_album_art_overlay_path(self, picfile):" is creating the overlay pixbuf. This is all good and fine, but this is also callled every second in "def update_icon(self):". We should just be updating the badge text here, not reloading the icon every second.

[Rico Tzschichholz (ricotz)]

I can't confirm this behaviour.
Banshee and Rhythmbox helper only update and rebuild the cover if needed and it's only updated if the cover-art-url given from the player has changed.
If the icon image is reloading this much, this must be a bug updating this pixbuf inside docky.

[Rico Tzschichholz (ricotz)]

The handling of icon buffer needs to be changed to solve this problem.
Now, a badge change results in a rebuild and reload of the items icon. Therefore icon and badge should be handled and drawn in two different layers and these pixbuffers are joined/composited to present the final iconsurface.