missing build requirement dkms in control template for mkdeb

[Gerald Dachs]

Binary package hint: dkms

in the file /etc/dkms/template-dkms-mkdeb/debian/control the build requirement for dkms is missing . Without it, builds of packages made with mkdeb or mkdsc in launchpad will fail because the file /usr/lib/dkms/common.postinst is not found.

Gerald

[Mario Limonciello (superm1)]

Can you please elaborate (maybe show this failure, a log would be great)?

dkms is already a depends:
Package: DEBIAN_PACKAGE-dkms
Architecture: all
Depends: dkms (>= 1.95), ${misc:Depends}
Description: DEBIAN_PACKAGE driver in DKMS format.

[Gerald Dachs (gda-dachsweb)]

No I can't currently provide a log, because of lack of time. I am not a native english speaker, but I think my explanation made it clear that I didn't talk about the "Depends:" tag, but the " Build-Depends:" tag. What sense would make the "Depends:" tag during a build on launchpad? I totally disagree about the status incomplete.

Gerald

[Mario Limonciello (superm1)]

Ah, I see now. This changed because common.postinst gets copied in by default. I'll add the build-depends.
Fixed in 7854ede88599649a36bf71fbbb9915cb0cbf281c

[Launchpad Janitor (janitor)]

This bug was fixed in the package dkms - 2.1.1.1-0ubuntu1

---------------
dkms (2.1.1.1-0ubuntu1) lucid; urgency=low

  [ Mario Limonciello ]
  * dkms_common.postinst: Add some missing quotes around strings used in comparisons
    to make sure that this is safe on more shells.
  * Makefile, debian/rules: Only copy the init script in for redhat targets.
  * kernel_postinst.d: Make sure that dkms_autoinstaller is executable (LP: #480055)
  * Move the architecture mapping logic out of the DKMS template and into
    common.postinst for Ubuntu only. (LP: #497149)
  * template-dkms-mkdeb/debian/control: Build-depends on dkms (LP: #506959)

  [ Thomas Chenault ]
  * Fix parsing in find_external_dependencies(). The existing code behaves improperly
    when a driver disk module has more than two dependencies.
 -- Mario Limonciello <email address hidden> Mon, 25 Jan 2010 17:42:40 -0600