Timeline marker is reset after specific operations

[markba]

Sometimes, the timeline marker is reset to the start.

Steps to reproduce:
- place marker somewhere (not at the start)
- edit properties of a clip
- move the marker by cursor keys (left/right) or by using the speed buttons on the preview window
- the marker will be rest to the start

This happens on a few other operations:
- removing a transition
- adding a transition
- edit properties of a clip (already mentioned above)

This list is far from complete, but maybe there's a generic cause.

[Andy Finch (fincha)]

Here's a patch for this - issue was caused by the refreshxml method losing the current timeline position.

[Jonathan Thomas (jonoomph)]

Thanks Andy! I will apply this patch tonight.

On Thu, Jan 7, 2010 at 3:09 PM, Andy Finch <email address hidden>wrote:

> Here's a patch for this - issue was caused by the refreshxml method
> losing the current timeline position.
>
> ** Attachment added: "499790.patch"
> http://launchpadlibrarian.net/37584687/499790.patch
>
> --
> Timeline marker is reset after specific operations
> https://bugs.launchpad.net/bugs/499790
> You received this bug notification because you are a member of OpenShot
> Developers, which is subscribed to OpenShot Video Editor.
>
> Status in OpenShot Video Editor: In Progress
>
> Bug description:
> Sometimes, the timeline marker is reset to the start.
>
> Steps to reproduce:
> - place marker somewhere (not at the start)
> - edit properties of a clip
> - move the marker by cursor keys (left/right) or by using the speed buttons
> on the preview window
> - the marker will be rest to the start
>
> This happens on a few other operations:
> - removing a transition
> - adding a transition
> - edit properties of a clip (already mentioned above)
>
> This list is far from complete, but maybe there's a generic cause.
>
>
>
> _______________________________________________
> Mailing list: https://launchpad.net/~openshot.developers<https://launchpad.net/%7Eopenshot.developers>
> Post to : <email address hidden>
> Unsubscribe : https://launchpad.net/~openshot.developers<https://launchpad.net/%7Eopenshot.developers>
> More help : https://help.launchpad.net/ListHelp
>

[Jonathan Thomas (jonoomph)]

Andy,
While I was looking at your patch, it occurred to me that this code should probably live in the RefreshXML() method, instead of everywhere we call RefreshXML(). Does that make sense? So, I gave it a try just in the RefreshXML method, and it seems to work great. I'm going to go ahead and commit my version, but let me know if you disagree.

Thanks!
-Jonathan

[markba (mark-baaijens)]

Yes, that's what I meant with a 'probably a generic cause'...
Keep up the good work guys.