Unable to subscribe team to branch that I'm not a member of
Bug #497501 reported by
Cody A.W. Somerville
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Launchpad itself |
Fix Released
|
High
|
Tim Penhey |
Bug Description
I'm unable to subscribe a team to branch that I'm not a member of. This is problematic since subscriptions double as access control for private branches.
Related branches
lp:~thumper/launchpad/branch-subscription-subscribed-by
- Stuart Bishop (community): Approve (db)
- Curtis Hovey (community): Approve (release-critical code)
- Björn Tillenius: Pending (db) requested
-
Diff: 1649 lines (+395/-226)50 files modifieddatabase/sampledata/current-dev.sql (+4/-4)
database/sampledata/current.sql (+4/-4)
database/schema/patch-2207-60-0.sql (+18/-0)
lib/canonical/launchpad/mail/commands.py (+3/-1)
lib/canonical/launchpad/scripts/tests/test_garbo.py (+0/-2)
lib/canonical/launchpad/security.py (+1/-23)
lib/lp/app/errors.py (+18/-0)
lib/lp/bugs/interfaces/bug.py (+0/-7)
lib/lp/bugs/model/bug.py (+2/-1)
lib/lp/code/browser/branch.py (+0/-12)
lib/lp/code/browser/branchsubscription.py (+7/-24)
lib/lp/code/browser/codeimport.py (+2/-1)
lib/lp/code/configure.zcml (+1/-0)
lib/lp/code/doc/branch-merge-proposal-notifications.txt (+4/-4)
lib/lp/code/doc/branch-notifications.txt (+23/-39)
lib/lp/code/doc/branch-visibility.txt (+1/-1)
lib/lp/code/doc/branch.txt (+4/-4)
lib/lp/code/doc/codeimport.txt (+1/-1)
lib/lp/code/doc/codereviewcomment.txt (+1/-1)
lib/lp/code/interfaces/branch.py (+11/-3)
lib/lp/code/interfaces/branchsubscription.py (+12/-1)
lib/lp/code/mail/tests/test_branch.py (+1/-1)
lib/lp/code/mail/tests/test_branchmergeproposal.py (+3/-3)
lib/lp/code/mail/tests/test_codehandler.py (+1/-1)
lib/lp/code/mail/tests/test_codereviewcomment.py (+2/-2)
lib/lp/code/model/branch.py (+14/-5)
lib/lp/code/model/branchnamespace.py (+4/-2)
lib/lp/code/model/branchsubscription.py (+12/-1)
lib/lp/code/model/tests/test_branch.py (+14/-9)
lib/lp/code/model/tests/test_branchcollection.py (+9/-5)
lib/lp/code/model/tests/test_branchjob.py (+8/-4)
lib/lp/code/model/tests/test_branchmergeproposals.py (+20/-16)
lib/lp/code/model/tests/test_branchsubscription.py (+115/-0)
lib/lp/code/scripts/tests/test_scan_branches.py (+2/-1)
lib/lp/code/scripts/tests/test_sendbranchmail.py (+4/-2)
lib/lp/code/security.py (+37/-0)
lib/lp/code/stories/branches/xx-branch-edit.txt (+1/-1)
lib/lp/code/stories/branches/xx-branchmergeproposals.txt (+2/-2)
lib/lp/code/stories/branches/xx-person-branches.txt (+1/-1)
lib/lp/code/stories/branches/xx-subscribing-branches.txt (+7/-24)
lib/lp/code/stories/webservice/xx-branchsubscription.txt (+2/-0)
lib/lp/code/tests/test_branch.py (+1/-1)
lib/lp/codehosting/scanner/tests/test_bzrsync.py (+1/-1)
lib/lp/codehosting/scanner/tests/test_email.py (+6/-3)
lib/lp/codehosting/tests/test_jobs.py (+1/-1)
lib/lp/registry/browser/tests/packaging-views.txt (+1/-1)
lib/lp/registry/browser/tests/private-team-creation-views.txt (+1/-1)
lib/lp/registry/doc/private-team-roles.txt (+2/-2)
lib/lp/registry/model/distroseries.py (+1/-1)
lib/lp/testing/factory.py (+5/-2)
affects: | launchpad-registry → launchpad-code |
Changed in launchpad-code: | |
status: | Incomplete → New |
Changed in launchpad-code: | |
status: | Triaged → In Progress |
Changed in launchpad-code: | |
status: | In Progress → Fix Committed |
tags: |
added: qa-ok removed: qa-needstesting |
Changed in launchpad-code: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
This behaviour is correct since I do not think you want rivial to subscribe to your private branches. The owners of the branch are correct parties to add you.