Support py.in for intltool-update -m

[fujiwara]

Currently a lot of sources provide "foo.py.in" files to convert to "foo.py" with configure so I think it would be useful to support "py.in" file extension when you run "intltool-update -m"

To reproduce:
% mkdir po
% cd po
% cat >> ../foo.py.in <<_EOF
#!/usr/bin/python

            # Translators: %(name)s and %(value)s should not be translated:
            # it's a way to identify a string, so just handle them like %s
            print _("%(name)s: %(value)s") % infos_dict

_EOF

% touch POTFILES.in
% intltool-update -m

Then the file is not detected by 'intltool-update -m'.

I'm attaching the patch.

[Данило Шеган (danilo)]

Thanks for the patch. While it seems good, I wonder what those "lot of sources" are that would benefit from it?

Also, there is one concern I have: you are listing this format as having builtin support in gettext: does xgettext correctly pick up python-format as the syntax for such files?

[Данило Шеган (danilo)]

Ok, I've confirmed that xgettext correctly extracts strings even from .py.in files. Now fixed in lp:intltool r710.

[fujiwara (takao-fujiwara)]

Apologize. I found a regression in the previous attachment.

The previous patch fixes to detect .py.in file but it fails to detect .py file.

% cd po
% intltool-update -m

Could you please replace the commit the new attachment?

Thanks.

[Данило Шеган (danilo)]

Fixed, thanks again.

[fujiwara (takao-fujiwara)]

Thanks for your commit.

Just now I noticed comment #2. Oops sorry, it seems I didn't receive email during the new year vacation.

> I wonder what those "lot of sources" are that would benefit from it?

Some of .py config file includes the build parameters with py.in
E.g.

foo.py.in:
datadir="@datadir@"
localedir="@datadir@/locale"
N_ = lambda x: x
FOO_A = N_("test")
FOO_B = N_("test2")

> does xgettext correctly pick up python-format as the syntax for such files?

Yes, I think so.
gettext/gettext-tools/src/xgettext.c:

...
          /* Remove a trailing ".in" - it's a generic suffix. */
          if (strlen (reduced) >= 3
              && memcmp (reduced + strlen (reduced) - 3, ".in", 3) == 0)
            reduced[strlen (reduced) - 3] = '\0';

          /* Work out what the file extension is. */
          extension = strrchr (reduced, '.');
          if (extension)
            ++extension;
          else
            extension = "";

          language = extension_to_language (extension);
...

gettext/gettext-tools/src/x-python.h:
#define EXTENSIONS_PYTHON \
  { "py", "Python" }, \

Thanks.