Ubuntuone-Nautilus should not update file modification time to refresh the emblems
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Ubuntu One Client |
Fix Released
|
Medium
|
Roman Yepishev | ||
ubuntuone-client (Ubuntu) |
Fix Released
|
Medium
|
Roman Yepishev |
Bug Description
Binary package hint: ubuntuone-client
static void ubuntuone_
...
new_path = g_strdup_printf ("%s/%s", uon->managed, path);
if (local && server && strcmp (local, server) == 0)
g_hash_
else
g_hash_
utime (new_path, NULL);
}
This means that every time Nautilus visits the directory managed by ubuntuone all file modifications time are updated so that nautilus refreshes the emblems (this does not happen every time for the same directory, I suspect Nautilus caches the view somehow)
This is bad because of two issues arising from this:
1. The file modification times may be of some use to the applications performing simple checks 'reread-
2. Which results from 1 - once file is "changed", Nautilus refreshes not only the emblem but the thumbnail as well. In case folder is full of "thumbnailable" files, the user experiences the following:
1. Enter directory
2. See all files with thumbnails and "synchronized" emblems
3. Everything flickers
4. All thumbnails are gone, emblems are updated
5. Thumbnails start to pop-up gradually.
Since thumbnails dictate the size of the entry sometimes, such behavior results in file icons running back and forth until all the thumbnails are extracted. If user attempted to click file a he might click b instead, since there is a noticeable delay between initial folder display and thumbnail-free state.
I will attach the screencast displaying the problem once it gets to YouTube.
Additionally utime(path, NULL) is also called for every file that was mentioned in UploadStarted, UploadFinished, DownloadStarted and DownloadFinished signals.
This was not reported earlier because thumbnail support is broken in all versions including current PPA (See bug #479475). Once emblems processing is fixed, the bug reports describing the issue in question will start to appear.
Related branches
- Rick McBride (community): Approve
- dobey (community): Approve
-
Diff: 172 lines (+73/-6)1 file modifiednautilus/ubuntuone-nautilus.c (+73/-6)
tags: | added: nautilus-emblems |
Changed in ubuntuone-client (Ubuntu): | |
status: | New → Triaged |
tags: | added: desktop+ |
Changed in ubuntuone-client (Ubuntu): | |
importance: | Undecided → Medium |
importance: | Medium → Undecided |
assignee: | nobody → Rodney Dawes (dobey) |
Changed in ubuntuone-client: | |
status: | New → Triaged |
importance: | Undecided → Medium |
assignee: | nobody → Rodney Dawes (dobey) |
Changed in ubuntuone-client (Ubuntu): | |
importance: | Undecided → Medium |
Changed in ubuntuone-client: | |
status: | Triaged → Fix Committed |
Changed in ubuntuone-client (Ubuntu): | |
assignee: | Rodney Dawes (dobey) → Roman Yepishev (rye) |
Changed in ubuntuone-client: | |
assignee: | Rodney Dawes (dobey) → Roman Yepishev (rye) |
Changed in ubuntuone-client (Ubuntu): | |
status: | Triaged → Fix Committed |
Changed in ubuntuone-client: | |
status: | Fix Committed → Fix Released |
Changed in ubuntuone-client (Ubuntu): | |
status: | Fix Committed → Fix Released |
The screencast displaying the problem is here: http:// www.youtube. com/watch? v=ydb6KvfCKbM