lookup email target on the target branch not the submitted branch

[Robert Collins]

 affects bzr-pqm
 status confirmed
 importance high

This will make sheparding a little easier.

e.g. one can configure in lcoations.conf
[http://bazaar.launchpad.net/~bzr-pqm/bzr/bzr.dev]
pqm_email = <email address hidden>

and then do
bzr pqm-submit --ignore-local --submit-branch \
 http://bazaar.launchpad.net/~bzr-pqm/bzr/bzr.dev --public-location = \
 THING_TO_lAND

-Rob

[Andrew Bennetts (spiv)]

I think this makes sense.

FWIW, I remembered why I chose to make --ignore-local look up pqm_email on the source, rather than the target: because that seemed more consistent with the normal logic, which looks it up on the local source branch.

So I wonder if perhaps the non ignore-local logic should also use the target location (or branch)?

[Robert Collins (lifeless)]

On Wed, 2009-11-25 at 00:12 +0000, Andrew Bennetts wrote:
>
> So I wonder if perhaps the non ignore-local logic should also use the
> target location (or branch)?

Very much so (perhaps checking the branch to submit, and falling through
to the target).

-Rob

[Jelmer Vernooij (jelmer)]

It seems like this is the functionality provided by the child_pqm_email option. You can set:

[http://bazaar.launchpad.net/~bzr-pqm/bzr/bzr.dev]
child_pqm_email = <email address hidden>

and bzr-pqm will use that email address for all PQM submissions merging into bzr.dev.

It will also look at the remote branch if necessary.