Failsafe X stuff shouldn't be stored in /etc/gdm

Bug #480744 reported by Mario Limonciello
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
xorg (Ubuntu)
Fix Released
Wishlist
Bryce Harrington

Bug Description

Binary package hint: xorg

x11-common: 1:7.4+3ubuntu10

Since everything in /etc/ is treated as conffiles, it's more easily possible to run into a scenario where someone modifies or removes the failsafe X stuff. It should be stored elsewhere on the system.

Related branches

Revision history for this message
Bryce Harrington (bryce) wrote :

Hi superm1,

Please attach the output of `lspci -vvnn` and `dmesg`, and attach your /var/log/Xorg.0.log (and maybe Xorg.0.log.old) file from after reproducing this issue. If you're using a custom /etc/X11/xorg.conf please attach that as well.

[This is an automated message. Apologies if it has reached you inappropriately; please just reply to this message indicating so.]

tags: added: needs-xorglog
tags: added: needs-lspci-vvnn
Changed in xorg (Ubuntu):
status: New → Incomplete
Revision history for this message
Mario Limonciello (superm1) wrote :

Logs aren't needed for this type of bug.

Revision history for this message
Bryce Harrington (bryce) wrote :

The files are stored under /etc for historical reasons + laziness.

Really, by Karmic these no longer even have anything to do with gdm, so there's little reason they should remain where they are. However, since they are in /etc/, if we move them we also need rules to safely remove the files from /etc during upgrades.

At this point given a few of the other failsafe-x bugs, it might make sense to break these scripts out into a standalone package, rewrite it in python, and provide both ncurses and gui frontends.

Changed in xorg (Ubuntu):
importance: Undecided → Wishlist
status: Incomplete → Triaged
Revision history for this message
Bryce Harrington (bryce) wrote :

Actually it probably is not a requirement to remove them from /etc during upgrades; it won't hurt anything, just be cruft.

So the question just becomes, where to move them to...

Revision history for this message
Flávio Etrusco (etrusco) wrote :

/usr/lib/failsafe-x? ;)

Bryce Harrington (bryce)
Changed in xorg (Ubuntu):
assignee: nobody → Bryce Harrington (bryce)
Revision history for this message
Launchpad Janitor (janitor) wrote :
Download full text (3.5 KiB)

This bug was fixed in the package xorg - 1:7.6+7ubuntu1

---------------
xorg (1:7.6+7ubuntu1) oneiric; urgency=low

  * Merge from Debian unstable, remaining changes:
    - Add apport hook
    - Demote xfonts-{75DPI,100DPI} to Suggests. Demote xfonts-scalable to
      Recommends.
    - debian/local/Xsession:
      Truncate xsession-errors on startup if too big
    - debian/local/Xsession.d/20x11-common_process-args:
      Add support for session command containing args.
    - debian/local/Xsession.d/60x11-common_localhost:
      Authorise all processes running with the user's credentials to connect
      to the server.
    - debian/rules, debian/control:
      Add dependencies on x11-common, and symlink /usr/share/doc directories
      of all packages to x11-common's.
    - debian/scripts/vars.*:
      + Don't drop wacom from input-all.
      + Add -vmmouse to input-all for amd64 and i386.
      + Add -qxl to video-all for amd64 and i386.
      + Add -geode to video-all for i386.
      + Drop video drivers that are likely irrelevant for ARM.
    - debian/xserver-xorg.postinst.in: Also migrate users from psb → vesa.

  [ Bryce Harrington ]
  * apport/source_xorg.py:
    - Move Failsafe-X out of the xorg package to xdiagnose
      (LP: #480744)
    - Simplify answers for bug reporters filing post-release reports.
      (LP: #778758)
    - Remove attach_drm_info(). This is useful info but we use it very
      infrequently, and it is already available in other log files. But the
      call makes bug reports a bit cluttered since it adds a lot of lines to
      the report itself.

  [ Timo Aaltonen ]
  * rules: A stampfile generation was commented out by mistake, uncomment
    it.
  * Rework the x11-common.{postinst,postrm,preinst} failsafe conffile
    handling, the previous ones added in 1:7.6+4ubuntu1 were wrong too.
  * scripts/vars.{amd64,i386,powerpc}: Remove apm, ark, chips, i128, i740,
    rendition, s3virge, tseng, voodoo from xserver-xorg-video-all
    dependencies. They are unmaintained and obsolete.

xorg (1:7.6+7) unstable; urgency=low

  * Remove long obsolete XF86Config-4 on purge (Closes: #610450). Thanks,
    Bernhard R. Link!
  * Add support for armhf (Closes: #605841), Thanks, Konstantinos
    Margaritis! Keep wacom in Recommends rather than in Depends, though.
  * Set the same permissions on all debian/scripts/vars.* files: no need
    to have them +x.
  * Remove debian/scripts/validate-posix-sh, unused.
  * Address description-synopsis-starts-with-article lintian tag.
  * Bump Standards-Version (no changes needed).
  * Merge xsf-docs up to the f920810e8f commit:
    - Add: reference/experimental
    - Add: reference/git-usage
    - Update: faq/general (firmware for ATI)
    - and other minor updates.

xorg (1:7.6+6) unstable; urgency=low

  * Merge xsf-docs up to the bd39472b0c commit:
    - Conversion from markdown to asciidoc.
  * Tweak the Makefile accordingly to stop trying to build and install PDF
    documents, since wkhtmltopdf fails on several architectures. Let's
    enable them again later, once bugs are fixed.
  * Adjust build system and build-dependencies accordingly:
    - Add asciidoc build-dep.
    - Remove m...

Read more...

Changed in xorg (Ubuntu):
status: Triaged → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.