[queue tool] Please accept multiple queue IDs to act on

[Matt Zimmerman]

It would be much more convenient (and faster, to avoid connecting to the queue many times) to be able to act on multiple queue IDs in a batch, e.g.:

queue accept 123 456 789 190
queue fetch 123 789 190

etc.

[Christian Reis (kiko)]

Because Matt asked.

[Celso Providelo (cprov)]

Currently queue supports another way to batch operations, a file containing one action per line, something like:

{{{
accept 123
fetch 456
reject 789
override 654 source universe/python
}}}

Use queue -f commands (-N for dry-run if you want to test stuff)
I
t's not as intuitive as your suggestion but I hope it helps ...

[Colin Watson (cjwatson)]

Yeah, I use 'queue -f /dev/fd/0' a lot. (Incidentally, supporting 'queue -f -' to read from standard input would be nice, and more standard.) It works, but is a bit clunky.

[Celso Providelo (cprov)]

Matt,

Looks like we have a new suggestion:
{{{
(09:46:23) Kamion: it would be quite nice if 'queue' without any non-option arguments would start a queue console, a bit like the python shell
(09:46:43) Kamion: then you could just type commands at it, without having to worry about what happens if the third-from-last command in your sequence fail
(09:46:46) Kamion: s
}}}

I like it and AFAICT the implementation would be much cleaner than the former (full of corner cases)

A Twisted based console (same used already in scripts/ftpmaster-tools/buildd-monitor.py) and the current queue.CommandRunner association would do a great job with much less code.

[Matt Zimmerman (mdz)]

On Tue, Oct 03, 2006 at 12:56:22PM -0000, Celso Providelo wrote:
> Matt,
>
> Looks like we have a new suggestion:
> {{{
> (09:46:23) Kamion: it would be quite nice if 'queue' without any non-option arguments would start a queue console, a bit like the python shell
> (09:46:43) Kamion: then you could just type commands at it, without having to worry about what happens if the third-from-last command in your sequence fail
> (09:46:46) Kamion: s
> }}}
>
> I like it and AFAICT the implementation would be much cleaner than the
> former (full of corner cases)

What corner cases? It seems incredibly simple to me; hundreds of other
programs work this way and it makes intuitive sense.

> A Twisted based console (same used already in scripts/ftpmaster-tools
> /buildd-monitor.py) and the current queue.CommandRunner association
> would do a great job with much less code.

Why is any more code required than a for loop?

--
 - mdz

[Colin Watson (cjwatson)]

FWIW, my suggestion was intended as a separate wishlist request, not as an alternative to Matt's suggestion.

[Celso Providelo (cprov)]

Matt,

It's not simple to deal with heterogeneous arguments anywhere, but it doesn't mean it is impossible. I was just looking for something better than just hammering the current code to suport an additional feature which collides with the current code model.
Nevermind, will implement it.

[Christian Reis (kiko)]

On Tue, Oct 03, 2006 at 08:19:29PM -0000, Celso Providelo wrote:
> Nevermind, will implement it.

Hey -- this bug is assigned to me!

[Celso Providelo (cprov)]

oops, sorry. All yours.

[Celso Providelo (cprov)]

Kiko,

Any progress on this task ?

[Christian Reis (kiko)]

Optional for 1.1.7 to accomodate commercial component work.

[Celso Providelo (cprov)]

1.1.8 is more appropriate

[Julian Edwards (julian-edwards)]

As discussed with pitti, I will change the way the command line works for using "override".

Instead of:
    queue override <filter> [override_stanza*]

    Where override_stanza is one of:
    source [<component>]/[<section>]
    binary [<component>]/[<section>]/[<priority>]

I will change this so that there are command line options instead:
-c or --component
-x or --section
-p or --priority
and change the order of the <filter> and <source/binary> stanza.

This does two things:
1. Makes it consistent with change-override.py
2. Makes it possible to process multiple overrides as per the bug requirement.

example:
queue override -c universe source 5 10 667

[Julian Edwards (julian-edwards)]

Fixed in RF 4657.

When this is released, please take note of the new syntax for overriding.