Group search results by TTH by default

[Jairaj]

Suggestions
-> Group search results by TTH by default
-> Display one of the file names (the first one maybe) as group name, size, etc (so that it can be sorted)
-> Download from the user having unused slots when double click on group name.
-> Resolve bug: https://bugs.launchpad.net/linuxdcpp/+bug/308683

[Razzloss (razzloss)]

There was a blueprint written about this as a feature request.

But let's repeat the comments in here:
1) I'm pretty much againts any default grouping, as filtering isn't anymore enabled with grouping it would make it more annoying to filter the results. However search could remember the previous settings so setting grouping once would make it a default. To remain consistent all the other search options should also be remembered.

2) This was already implemented, but Steven didn't like it. I don't really see the point in displaying the TTH in filename column, as it is pretty much useless information compared to other grouping criteria. But to have this changed, we need Steven's input.

3 & 4) I'd rather fix this in the core. It can already be done in the GUI with checks if the tth is already queued and then calling addSource instead of download. Easier way (and would make more sense IMO) is the change the QueueManager in core so that if appropriate settings are set QueueManager would add it as a source instead discarding the download request.

--RZ

[Jairaj (ursjai)]

But isnt 1) a feature that is present by default in DC++?

[Steven Sheehy (steven-sheehy)]

I'm okay with filename instead of tth for tth grouping.

[Lain_13 (lain-halfbit)]

Suggestion: show first row from group instead of TTH. When user chose to download this group add all users from this group as sources.

[Charles M. (charlesmalias-launchpad)]

I'd suggest that, when grouping, you use the most frequently occurring filename in the group as the value in the Filename column. When frequency for a name is tied, choose the most frequent-appearing name with the earliest returned result.

This would produce more consistent results when the majority of sharers are following a standard naming convention, but various other naming conventions are in minority use.

Using a "first result returned" method produces group names using the various naming convention based their relative prevalence. Which just looks messy.

It would be more coding to use the frequency-based approach, but it would look much slicker in most cases I see.

[Steven Sheehy (steven-sheehy)]

I believe #2-4 are implemented now with the fix to bug #308683. Razzloss has said he is against grouping search results by TTH by default, but yet he marked this bug as confirmed. :)

I differ with my colleague in that I'm actually for grouping by TTH as default. In fact I would like to go further and remove all grouping and make TTH grouping the only option since grouping adds unnecessary complexity and does not work with filtering. Though Razzloss said he is against this as well.