Close icon on gaim conversation tab is zoomed out of proportion

[Steven DeWitt]

Binary package hint: gaim

Dapper Drake RC:

Ever since the updates I got very recently about 11:30 PM on May 26th in Detroit, MI time, I noticed a new close icon, and it also appears in Gaim conversation tabs, but the icon does not fit on the close button.

[Steven DeWitt (halflife28)]

http://img89.imageshack.us/img89/2839/screenshotclosebutton3th.png

Here's a screenshot of the problem.

[Richard Laager (rlaager)]

I assume we're not dealing with that icon properly. Here's some code from gtkconv.c:

        /* Close button. */
        gtkconv->close = gtk_button_new();
        gtk_icon_size_lookup(GTK_ICON_SIZE_MENU, &close_button_width, &close_button_height);
        if (gtk_check_version(2, 4, 2) == NULL) {
                /* Need to account for extra padding around the gtkbutton */
                gtk_widget_style_get(GTK_WIDGET(gtkconv->close),
                                     "focus-line-width", &focus_width,
                                     "focus-padding", &focus_pad,
                                     NULL);
                close_button_width += (focus_width + focus_pad) * 2;
                close_button_height += (focus_width + focus_pad) * 2;
        }
        gtk_widget_set_size_request(GTK_WIDGET(gtkconv->close),
                                    close_button_width, close_button_height);

I have no idea why we're doing that, but that's probably the source of it. :)

[Richard Laager (rlaager)]

Disabling the limiting code appears to correct the display issue, but you end up with excess padding.

[Steven DeWitt (halflife28)]

I have little experience with C++, so I really couldn't do nothing in the source code. Just reporting a problem for the devs to fix.

[Richard Laager (rlaager)]

Heh. It's not even C++. ;)

Anyway, I'm a Gaim dev. I think I'm closing in on a solution. Hopefully I'll have a patch shortly, but I wanted to document my findings as I went in case I gave up half-way through. That way, someone else could pick up where I left off. :)

[Richard Laager (rlaager)]

Here's a proposed patch. It's the code from epiphany. I notice that despite being the same code, I'm seeing more padding in Gaim than in Epiphany. However, I actually think that the slightly more padding looks better.

My main concern with this is whether or not it works with old versions of GTK+. I'm likely going to commit it and see what happens.

I recommend applying this to the Gaim package in Dapper.

Also, this same bug is appearing in pop-ups from rhythmbox in the gnome-panel. Any help on which package to file against would be great.

[Richard Laager (rlaager)]

Committed to upstream SVN HEAD.

[Sebastien Bacher (seb128)]

opening ubuntu-artwork task, now is not the right moment to push changes that will require patching apps all over the desktop