notifier icon does not start gksu with startup notification

Bug #46258 reported by James Henstridge
8
Affects Status Importance Assigned to Milestone
update-notifier (Ubuntu)
Fix Released
Wishlist
Michael Vogt

Bug Description

The update notifier icon should use startup notification when launching update-notifier. Without this, the update-manager window may get placed below active windows by metacity when it starts up.

Related branches

Revision history for this message
Michael Vogt (mvo) wrote :

Thanks for your bugreport.

Are you using the latest version of gksu? update-notifier runs its commands via gksu and the latest gksu has startup notification build-in so it shouldn't open windows behind others.

Thanks
 Michael

Changed in update-notifier:
assignee: nobody → mvo
status: Unconfirmed → Needs Info
Revision history for this message
James Henstridge (jamesh) wrote :

Yeah, I'm running the latest gksu.

As I understand it, the gksu changes only really help if the launching application is startup notification aware, and sets the environment variables appropriately (usually using libstartup-notification) to pass the timestamp for the launch action through to the new process. So it works great for launches from the panel or applications menu.

The update-notifier applet seems to just do a plain g_spawn() call, which doesn't do the necessary setup.

Revision history for this message
Michael Vogt (mvo) wrote :

Thanks for this update.

I misunderstood the problem then. gksu itself is invoked without startup notification, but the applications launched by gksu done with startup notificatin. The problem is that there is no simple way to say "gnome_invoke_with_startup_notification()" but a lot of legwork has to be done.

Changed in update-notifier:
status: Needs Info → Confirmed
Michael Vogt (mvo)
Changed in update-notifier:
importance: Medium → Wishlist
Revision history for this message
Martin Mai (mrkanister-deactivatedaccount-deactivatedaccount) wrote :

 We were wondering if this is still an issue for you. Can you try with the latest Ubuntu release? Thanks in advance.

Changed in update-notifier:
status: Confirmed → Incomplete
Revision history for this message
James Henstridge (jamesh) wrote :

The code has not changed since my last comment. You can see the relevant source code in http://bazaar.launchpad.net/~ubuntu-core-dev/update-notifier/ubuntu/annotate/head:/src/update-notifier.c

Neither the invoke() or invoke_with_gksu() methods do anything to pass on the event time for when the user clicked the icon.

Changed in update-notifier:
status: Incomplete → Confirmed
Michael Vogt (mvo)
Changed in update-notifier (Ubuntu):
status: Confirmed → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package update-notifier - 0.86

---------------
update-notifier (0.86) karmic; urgency=low

  [ Sebastien Bacher ]
  * debian/rules:
    - build using --as-needed to reduce the depends

  [ Dustin Kirkland ]
  * debian/update-notifier-common.dirs: update-notifier-common
    needs /etc/update-motd.d, rather than /etc/update-motd.d/hourly;
    causes this directory to *not* be removed on update-motd package
    removal/upgrade

  [ Michael Vogt ]
  * src/update-notifier.c:
    - if display can not be opened, show a propper error message
      and do not crash (LP: #317745)
  * src/apt_check.py:
    - count security updates correctly even when they are "shadowed"
      by a regular update (LP: #394958)
    - fix typo (thanks to Hew McLachlan)
  * data/update-motd-updates-available, debian/99update-notifier:
    - move updates available from /var/run to /var/lib/update-notifier
      to make it persistent over reboots
  * src/update-notifier.c:
    - make the timeout for no-activity from apt bigger (LP: #274001)
  * data/update-notifier.desktop.in:
    - better description for the auto startup (LP: #146918)
  * src/update-notifier.c:
    - use GAppInfo/GAppLaunchContext to provide startup notification
      support (LP: #46258)

 -- Michael Vogt <email address hidden> Tue, 14 Jul 2009 16:50:46 +0200

Changed in update-notifier (Ubuntu):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.