Segfault when importing multiple images

[Zoubidoo]

Importing multiple images causes a segmentation fault.

To reproduce:
   File -> Import
   Select several images (holding down ctrl) or a range (hold down shift).
   Click Add.

$ openshot
Added /usr/share/openshot to system path
--------------------------------
   OpenShot (version 0.9.52)
--------------------------------
/usr/share/openshot/windows/SimpleGladeApp.py:340: GtkWarning: gtk_toolbar_set_icon_size: assertion `icon_size != GTK_ICON_SIZE_INVALID' failed
  return gtk.glade.XML(self.glade_path, root, domain)
A new frmMain has been created
on_tlbImportFiles_clicked called with self.tlbImportFiles
Segmentation fault

openshot 0.9.52
openshot-x264 0.67.1173-1
openshot-mlt 0.4.3-1
openshot-ffmpeg git-2623d8f-1
openshot-frei0r 1.1.22-1
Ubuntu 9.04 32-bit

[Helen McCall (wildnfree)]

Hello Zoubidoo,

I have tried to replicat this, but have been unable to crash openshot 0.9.52 on any multiple file import.

I have tried it with many combinations of differing types of video and images and invalid files as well, but no crash.

Are you able to import individual clips and images?

Helen

[Olivier Girard (eolinwen)]

Hello Helen
How are you ?
Could you tell us what are you versions of your external librairies ? (ie x264, mlt, ffmpeg ) Perhaps the problem could be here.
@+
Olivier/Cenwen

[Zoubidoo (zoubidoo)]

Hello Helen, Olivier,

I have encountered no problems with importing clips and *some* images work fine. I suspected I might have corrupt images, so I checked their integrity with Jhove http://hul.harvard.edu/jhove/ but they're fine.

The peculiar thing is that I can import them individually, the problem only arises when selecting multiple files.

I am still trying to narrow it down further and will write with any progress.

I would post the images but they are of a commercially sensitive nature so I'll also look for some other images that also cause the segfault.

If you have any tips on troubleshooting the python code (I'm not a python expert) please let me know.

Cheers,
Z..

[Helen McCall (wildnfree)]

Hello Olivier,

I am recovering fast. :-)

I have the full set of dependencies from the ppa

x264 1:076+git031e25d8cc-0ubuntu1~tj~ppa1j
libmlt++2 0.4.4+git20090927-0ubuntu3~tj~ppa1j
libmlt-data 0.4.4+git20090927-0ubuntu3~tj~ppa1j
libmlt1 0.4.4+git20090927-0ubuntu3~tj~ppa1j
melt 0.4.4+git20090927-0ubuntu3~tj~ppa1j
python-mlt 0.4.4+git20090927-0ubuntu3~tj~ppa1j
ffmpeg 4:0.5+svn20090926-0ubuntu1~tj~ppa1j
frei0r-plugins 1.1.22git20090914-0ubuntu1~tj~ppa1j

and I have the standard Ubuntu mlt for kdenlive
libmlt++1 0.3.8-0ubuntu1

With this set I have kdenlive, VLC, Blender etc all running on Ubuntu 9.04 (64bit)
At present I am only running one version of ffmpeg because I have found this version serves all!

I hope this helps

[Helen McCall (wildnfree)]

Zoubidoo

If these are commercially sensitive images, are they encrypted or copy protected or read-only? What format are they?

Helen

[Zoubidoo (zoubidoo)]

I have just repeated the result with jpegs downloaded at random from google images. I have tarred them up and attached them (770k).

To reproduce:
1. download and untar the attached tarball
2. start openshot
3. Click File -> Import files
4. Navigate to the images
5. Click on the first image, then, holding down shift click on the last image.
6. Click Add

This reliably gives me a segfault.

Can anyone reproduce this?

Z.
PS: Usual disclaimer: as with any images found on the web, they may be copyrighted.

[Olivier Girard (eolinwen)]

Hello Helen and Zoubidoo
Sorry i'm in late(like always!)

@Zoubidoo Have you tried with another sorts of pictures (ie take with a camera) ? What are they their format (jpeg, jpg, png svg perhaps Hdr ?) Have you tried with differents formats ? Personnally i can't reproduced it.
I'm thinking perhaps they could be protected by ...a copyright, a protection.
try this command on a picture :
identify -verbose mypicture.jpg

@Helen Thanks to your precisions. We have done a lot of tests (and differentes versionsof the dependencies) that it will be difficult to know exactly where are the problemes now. Personnaly, i'm waiting Karmic for my knew configuration and my knew Hard Drive and ....my radeon 4850 (i have some problemes with compiz).For Zoubidoo, he have a different version of mlt and x264 and ffmpeg. For me it 's mlt the problem if it's not the picture themselves. Before that i want to know more about the pictures. See you perhaps tonight on pidgin or perhaps irc if i have the time to go it (and think it also)

@+

Olivier/Cenwen

[Zoubidoo (zoubidoo)]

@Olivier: I have run the identify command over the images. It produces a lot of information but I'm not sure what I'm looking for. If the images are protected in some way, surely other applications would also have difficulty viewing them too? The images are straight off the web from google image search so they are from a variety of sources. Also I have found no evidence that jpg protection even exists. If you know otherwise please send a link.

If the problem is indeed mlt, it would be good to have a way of checking this. I tried debugging the executable with pdb but it doesn't even supply a stack trace, so not very helpful.

As I understand it, no one has attempted to reproduce this bug with the set up being distributed on the openshot website. I think this would be a good idea.

For now openshot remains unusable for me when it comes to making slideshows.

Cheers
Z.

[Andy Finch (fincha)]

I've tried to reproduce this using the latest version 0.9.54 and the images import without a problem. Are you able to try again using the latest version?

[Zoubidoo (zoubidoo)]

@Andy: I reported this bug a month ago and as far as I can see nobody tried to reproduce it using the same configuration despite it being the stable configuration advertised on the website. Under these conditions, I see little point making any further effort on this bug.

[Francesco Mognato (francesco-mognato)]

the behaviour is strange: sometimes happens and sometimes doesn't happen. These are my tests

Hardy 8.04 - Kernel 2.6.24-26-generic
Gnome 2.22.3
on hardware Pentium IV - 2.8 Ghz 512MB Ram

I open the terminal and write: openshot

Added /usr/share/openshot to system path
--------------------------------
   OpenShot (version 0.9.54)
--------------------------------
A new frmMain has been created

I had 3 png images
1^ test: Add single image one at a time: OK . Close Openshot and re-open
2^ test: Add three images: click on the first and Shift+click on the third: OK. Close Openshot and re-open
3^ test: Add single image. Remove single image. Then add the images like the 2^ test: segmentation fault

Restart the machine

4^ test: add 6 jpeg images: click on the first and Shift+click on the third: OK. Close Openshot and re-open
5^ test: add 6 jpeg images (the same above): click on the first and Shift+click on the third:

on_tlbImportFiles_clicked called with self.tlbImportFiles
Segmentation fault

[Francesco Mognato (francesco-mognato)]

I want to add more info about my previous comment:
After the precedent crash I:
- logout the user
- login the user
- open the terminal
- Start openshot
- Import the 6 jpeg images in multiple mode (click on the 1st and shift+click on the 6th).
- Put them on the tracks, add track, play with openshot.
- close openshot without saving the project
- restart openshot
- Import again the 6 images together and ...

on_tlbImportFiles_clicked called with self.tlbImportFiles
Segmentation fault

Bye.

[Zoubidoo (zoubidoo)]

I have changed platform (upgraded to Karmic) and installed from the PPA. The problem no longer occurs.

I am however getting segfaults for other operations. This program is very buggy, crashing regularly with segfaults. But what is worse is that the segfaults don't give any helpful information for troubleshooting.

This project could use some guidelines from the developers on how to troubleshoot and report bugs in a useful way. strace, debug symbols etc.

[Zoubidoo (zoubidoo)]

OK, here is how to get a backtrace when a segfaults occurs within a python app:

http://wiki.python.org/moin/DebuggingWithGdb

[Francesco Mognato (francesco-mognato)]

Hello! Thanks Zoubidoo!.
I installed python2.5-dbg
Then I followed the instruction
a) gdb python
b) run /usr/bin/openshot

and this is the result! I

Starting program: /usr/bin/python /usr/bin/openshot
[Thread debugging using libthread_db enabled]
Added /usr/share/openshot to system path
[New Thread 0xb7d8b8c0 (LWP 6133)]
--------------------------------
   OpenShot (version 0.9.54)
--------------------------------
[New Thread 0xb6b1cb90 (LWP 6142)]
A new frmMain has been created
[New Thread 0xb51e1b90 (LWP 6145)]
[New Thread 0xb49e0b90 (LWP 6146)]
[New Thread 0xb3ebdb90 (LWP 6147)]
[New Thread 0xb36bcb90 (LWP 6148)]
[New Thread 0xb267eb90 (LWP 6149)]
[New Thread 0xb1b79b90 (LWP 6150)]
on_tlbImportFiles_clicked called with self.tlbImportFiles
[New Thread 0xb116db90 (LWP 6151)]
[Thread 0xb1b79b90 (LWP 6150) exited]
[Thread 0xb3ebdb90 (LWP 6147) exited]
[Thread 0xb267eb90 (LWP 6149) exited]
[Thread 0xb36bcb90 (LWP 6148) exited]
[New Thread 0xb36bcb90 (LWP 6152)]

Program received signal SIGSEGV, Segmentation fault.
[Switching to Thread 0xb36bcb90 (LWP 6152)]
0xb6e669e8 in mlt_event_unblock () from /usr/local/lib/libmlt.so.2
(gdb)

I hope this info will be useful to the developers.
Bye. Openshot is a great software

[Zoubidoo (zoubidoo)]

@Andy: Re-opened because it's not invalid. Perhaps WONTFIX is more appropriate if the bug is not in openshot but in the libraries.

@Francesco, glad to hear that helped you. You might also want to add a backtrace (bt in the debugger after the segfault). Also could you try running pystack and pystackv to help locate the problem in openshot.

[Olivier Girard (eolinwen)]

@Francesco
great work, exactly i don't know now but the problem looks come of
mlt(exactly ibmlt.so.2) and not openshot

@Zoobidoo
Great help. TJ initialy , the last time we have received some news want to
create a howto about use this tools and i should traduced it in french but
unfortunatly we have none news, and sign of living since severals mouths
about him. This tips is precious for us same if we don't know him. But i
think it will be very precious.
Thanks

2009/12/17 Zoubidoo <email address hidden>

> @Andy: Re-opened because it's not invalid. Perhaps WONTFIX is more
> appropriate if the bug is not in openshot but in the libraries.
>
> @Francesco, glad to hear that helped you. You might also want to add a
> backtrace (bt in the debugger after the segfault). Also could you try
> running pystack and pystackv to help locate the problem in openshot.
>
> ** Changed in: openshot
> Status: Invalid => New
>
> --
> Segfault when importing multiple images
> https://bugs.launchpad.net/bugs/459051
> You received this bug notification because you are a member of OpenShot
> Developers, which is subscribed to OpenShot Video Editor.
>
> Status in OpenShot Video Editor: New
>
> Bug description:
> Importing multiple images causes a segmentation fault.
>
> To reproduce:
> File -> Import
> Select several images (holding down ctrl) or a range (hold down shift).
> Click Add.
>
> $ openshot
> Added /usr/share/openshot to system path
> --------------------------------
> OpenShot (version 0.9.52)
> --------------------------------
> /usr/share/openshot/windows/SimpleGladeApp.py:340: GtkWarning:
> gtk_toolbar_set_icon_size: assertion `icon_size != GTK_ICON_SIZE_INVALID'
> failed
> return gtk.glade.XML(self.glade_path, root, domain)
> A new frmMain has been created
> on_tlbImportFiles_clicked called with self.tlbImportFiles
> Segmentation fault
>
>
>
> openshot 0.9.52
> openshot-x264 0.67.1173-1
> openshot-mlt 0.4.3-1
> openshot-ffmpeg git-2623d8f-1
> openshot-frei0r 1.1.22-1
> Ubuntu 9.04 32-bit
>
>
>
> _______________________________________________
> Mailing list: https://launchpad.net/~openshot.developers<https://launchpad.net/%7Eopenshot.developers>
> Post to : <email address hidden>
> Unsubscribe : https://launchpad.net/~openshot.developers<https://launchpad.net/%7Eopenshot.developers>
> More help : https://help.launchpad.net/ListHelp
>

--
Cenwen un elfe sur la banquise/ an elve on the ice
Mon blog perso sur le multimédia, Ubuntu, Linux et OpenShot :
http://linuxevolution.wordpress.com/
http://openshotusers.com/
http://openshotusers.com/forum/index.php

[Francesco Mognato (francesco-mognato)]

@Zoubidoo
I used bt and the answer was:
0xb6e669e8 in mlt_event_unblock () from /usr/local/lib/libmlt.so.2

I used pystack macro, but after a long time (30 min) I had no answer: so I quit.
In alternative I launched: python -dv /usr/bin/openshot and the result is in the attachment.
I hope this will be useful.

I didn't understand why pystack/pystackv was silent. Suggest me some other option.
Francesco

[Zoubidoo (zoubidoo)]

@Francesco
I had the same problem with pystack. I just discovered from this thread it is broken:
http://<email address hidden>/msg259881.html
I haven't tried the fix yet. Please let me know if you try.

Your stack (bt) looks really short. Don't you get several lines? Something like this (for a different segfault):

(gdb) bt
#0 0x03b30000 in ?? () from /usr/lib/libSDL-1.2.so.0
#1 0x03aeda2f in ?? () from /usr/lib/libSDL-1.2.so.0
#2 0x03aebaa0 in SDL_DisplayYUVOverlay () from /usr/lib/libSDL-1.2.so.0
#3 0x00fb63c4 in ?? () from /usr/lib/mlt/libmltsdl.so
#4 0x00c2b80e in start_thread () from /lib/tls/i686/cmov/libpthread.so.0
#5 0x004c17ee in clone () from /lib/tls/i686/cmov/libc.so.6

I also haven't yet worked out if it is possible to get debug symbols for libSDL without recompiling it. There seems to be no -dbg package. A shame because it would help to get MLT fixed.

Cheers,
Z.

[Francesco Mognato (francesco-mognato)]

In gdb I made several run of the same test one after another, obtaining different answers.
The test is: to import 6 small jpeg images in multiple mode (click on the 1st and shift+click on the 6th).
The answer is in the file attached.

[Francesco Mognato (francesco-mognato)]

@Zoubidoo
I try the patch of T. Madden, but I have no answer

[Andy Finch (fincha)]

Not an issue, see comment #13