Please run testsuite during build

Bug #452900 reported by Loïc Minier
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ubuntu Server papercuts
Fix Released
Undecided
Unassigned
asm2 (Ubuntu)
Fix Released
Medium
James Page

Bug Description

Hi

asm2 has a large testsuite, but it isn't used during build.

Please change the build to fail if the testsuite doesn't pass.

Thanks,

Related branches

Mathias Gug (mathiaz)
Changed in asm2 (Ubuntu):
status: New → Triaged
importance: Undecided → Medium
Revision history for this message
James Page (james-page) wrote :

I've completed some analysis on the asm2 test process and what it will take to integrate this into the current build process.

Basically, the asm2 test suite executes two sets of tests:

a) Conformance (functional) tests against the Java rt.jar file
b) Performance tests for asm2, bcel, serp and javassist

This presents the following challenges:

a) Conformance

The rt.jar contains 17.5k ish classes - which results in a large number of test executions. I suspect that when asm2 was released (in 2006) the java runtime environment was considerably smaller.

This also results in out of PermGen memory errors (which are resolvable with some additional ant options) which are related to the large number of classes being loaded by the Java virtual machine during execution.

There are also a large number of test failures which I have not investigated in full yet; bearing in mind the age of this release of asm2 (4 years since last upstream update) if this is a true failure we are unlikely to get a fix from the upstream project.

b) Performance

bcel and javassist are already in the Ubuntu archive - however serp is not; in addition these tests just generally showcase asm2 performance against these other toolsets rather than proving the performance to specified tolerances.

I think that it would make sense to remove these from the default build process as the conformance tests are more useful; this would also mean removing the source files from the package (managed by quilt so not a big issue.) to make the test source code build correctly without increasing the build dependencies for this package.

James Page (james-page)
Changed in asm2 (Ubuntu):
assignee: nobody → James Page (james-page)
status: Triaged → In Progress
Revision history for this message
James Page (james-page) wrote :

Enabling the test process is relatively easy; however due to the customised way (using libow-util-ant-tasks-java) in which the testing tasks are executed, it is not possible to fail the build process is there is a failure during test executing as test failures are ignored.

Branch uploaded with test execution enabled for future review.

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package asm2 - 2.2.3-4ubuntu2

---------------
asm2 (2.2.3-4ubuntu2) natty; urgency=low

  * Amended build process to execute test suite (LP: #452900)
  * Amended misc javac and javadoc warning messages (LP: #452910)
  * Updated Standards-Version: 3.9.1, no changes required.
  * Added source/format: 3.0 (quilt).
 -- James Page <email address hidden> Wed, 09 Feb 2011 19:42:17 +0100

Changed in asm2 (Ubuntu):
status: In Progress → Fix Released
Joshua Powers (powersj)
Changed in server-papercuts:
status: New → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Related blueprints

Remote bug watches

Bug watches keep track of this bug in other bug trackers.