Please run testsuite during build
Bug #452900 reported by
Loïc Minier
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Ubuntu Server papercuts |
Fix Released
|
Undecided
|
Unassigned | ||
asm2 (Ubuntu) |
Fix Released
|
Medium
|
James Page |
Bug Description
Hi
asm2 has a large testsuite, but it isn't used during build.
Please change the build to fail if the testsuite doesn't pass.
Thanks,
Related branches
lp:~james-page/ubuntu/natty/asm2/sweepup-fixes
- Martin Pitt: Approve
- James Page: Needs Resubmitting
-
Diff: 1772 lines (+1712/-3)8 files modifieddebian/changelog (+9/-0)
debian/control (+3/-2)
debian/patches/javac_warnings.diff (+27/-0)
debian/patches/javadoc_warnings.diff (+129/-0)
debian/patches/series (+3/-0)
debian/patches/testsuite_fix.diff (+1537/-0)
debian/rules (+3/-1)
debian/source/format (+1/-0)
Changed in asm2 (Ubuntu): | |
status: | New → Triaged |
importance: | Undecided → Medium |
Changed in asm2 (Ubuntu): | |
assignee: | nobody → James Page (james-page) |
status: | Triaged → In Progress |
Changed in server-papercuts: | |
status: | New → Fix Released |
To post a comment you must log in.
I've completed some analysis on the asm2 test process and what it will take to integrate this into the current build process.
Basically, the asm2 test suite executes two sets of tests:
a) Conformance (functional) tests against the Java rt.jar file
b) Performance tests for asm2, bcel, serp and javassist
This presents the following challenges:
a) Conformance
The rt.jar contains 17.5k ish classes - which results in a large number of test executions. I suspect that when asm2 was released (in 2006) the java runtime environment was considerably smaller.
This also results in out of PermGen memory errors (which are resolvable with some additional ant options) which are related to the large number of classes being loaded by the Java virtual machine during execution.
There are also a large number of test failures which I have not investigated in full yet; bearing in mind the age of this release of asm2 (4 years since last upstream update) if this is a true failure we are unlikely to get a fix from the upstream project.
b) Performance
bcel and javassist are already in the Ubuntu archive - however serp is not; in addition these tests just generally showcase asm2 performance against these other toolsets rather than proving the performance to specified tolerances.
I think that it would make sense to remove these from the default build process as the conformance tests are more useful; this would also mean removing the source files from the package (managed by quilt so not a big issue.) to make the test source code build correctly without increasing the build dependencies for this package.