Session Indicator Still Appears in Stracciatella Session

Bug #444149 reported by Rick Spencer
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Indicator Applet
Fix Released
Medium
Unassigned
gnome-panel (Ubuntu)
Fix Released
Medium
Martin Pitt
indicator-applet (Ubuntu)
Fix Released
Medium
Martin Pitt

Bug Description

Observed:
With a stracciatella session, the Session Indicator appears and works, and the System menu does not have standard log out/shutdown items.

Expected:
No Session indicator, System menu is stock

ProblemType: Bug
Architecture: i386
Date: Mon Oct 5 17:29:13 2009
DistroRelease: Ubuntu 9.10
Package: gnome-stracciatella-session 0.0.2
PackageArchitecture: all
ProcEnviron:
 PATH=(custom, user)
 LANG=en_US.UTF-8
 SHELL=/bin/bash
ProcVersionSignature: Ubuntu 2.6.31-11.38-generic
SourcePackage: stracciatella-session
Uname: Linux 2.6.31-11-generic i686
XsessionErrors:
 (gnome-settings-daemon:2488): GLib-CRITICAL **: g_propagate_error: assertion `src != NULL' failed
 (gnome-settings-daemon:2488): GLib-CRITICAL **: g_propagate_error: assertion `src != NULL' failed
 (polkit-gnome-authentication-agent-1:2644): GLib-CRITICAL **: g_once_init_leave: assertion `initialization_value != 0' failed
 (nautilus:2594): Eel-CRITICAL **: eel_preferences_get_boolean: assertion `preferences_is_initialized ()' failed
 (gnome-panel:2589): Gtk-WARNING **: gtk_widget_size_allocate(): attempt to allocate widget with width -15 and height 24

Revision history for this message
Rick Spencer (rick-rickspencer3) wrote :
Changed in stracciatella-session (Ubuntu):
importance: Undecided → Low
assignee: nobody → Martin Pitt (pitti)
Revision history for this message
Rick Spencer (rick-rickspencer3) wrote :

I would be happy to see this picked up in an update after karmic ships

Martin Pitt (pitti)
Changed in stracciatella-session (Ubuntu):
status: New → Triaged
tags: added: regression-potential
Martin Pitt (pitti)
Changed in stracciatella-session (Ubuntu):
importance: Low → Medium
status: Triaged → In Progress
Revision history for this message
Martin Pitt (pitti) wrote :

This needs to be fixed in indicator-session itself, similar to what indicator-applet does:

        /* check if we are running stracciatella session */
        if (g_strcmp0(g_getenv("GDMSESSION"), "gnome-stracciatella") == 0) {
                g_debug("Running stracciatella GNOME session, disabling myself");
                return TRUE;
        }

affects: stracciatella-session (Ubuntu) → indicator-session (Ubuntu)
Martin Pitt (pitti)
affects: indicator-session (Ubuntu) → indicator-applet (Ubuntu)
Revision history for this message
Martin Pitt (pitti) wrote :

This seems to be trickier than I thought. Using the same code in src-session/ (for indicator-applet-session) as in src/ (for indicator-applet) works fine, and the applet hides itself under stracciatella. However, this is "running enough" to tell the panel to not show the log out/shutdown entries any more.

So either we need to adapt the gnome-panel code for this as well and only hide the menu entries if the applet is really running, or we need a better way to terminate the applet without triggering the "unexpected quit" gnome-session complaint.

Revision history for this message
Martin Pitt (pitti) wrote :

Discussed with Ted (thanks!).

Changed in gnome-panel (Ubuntu):
assignee: nobody → Martin Pitt (pitti)
importance: Undecided → Medium
status: New → In Progress
Revision history for this message
Martin Pitt (pitti) wrote :

Ted, since you already upstreamified the corresponding patch in the indicator-applet code, would you consider applying this as well?

Changed in indicator-applet:
status: New → Confirmed
Martin Pitt (pitti)
Changed in indicator-applet (Ubuntu):
status: In Progress → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package indicator-applet - 0.2.0-0ubuntu2

---------------
indicator-applet (0.2.0-0ubuntu2) karmic; urgency=low

  * debian/rules: Enable simple-patchsys.
  * Add debian/patches/01_stracciatella.patch: Do not show up in stracciatella
    session. (LP: #444149)

 -- Martin Pitt <email address hidden> Wed, 14 Oct 2009 20:38:39 +0200

Changed in indicator-applet (Ubuntu):
status: Fix Committed → Fix Released
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package gnome-panel - 1:2.28.0-0ubuntu5

---------------
gnome-panel (1:2.28.0-0ubuntu5) karmic; urgency=low

  * 25_dynamic_fusa_detection.patch: Do not touch menu items when running
    under stracciatella. (LP: #444149)

 -- Martin Pitt <email address hidden> Wed, 14 Oct 2009 20:42:35 +0200

Changed in gnome-panel (Ubuntu):
status: In Progress → Fix Released
Ted Gould (ted)
Changed in indicator-applet:
milestone: none → 0.2.1
status: Confirmed → Fix Committed
Changed in indicator-applet:
importance: Undecided → Medium
Ted Gould (ted)
Changed in indicator-applet:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.