mp status change emails appear in a separate thread from the review
Bug #436294 reported by
Martin Pool
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Launchpad itself |
Fix Released
|
Low
|
Martin Pool |
Bug Description
A follow-on to bug 382527 and bug 240564:
Launchpad sends mail when a proposed merge is actually merged, which is nice, but in gmail (at least) it appears disconnected from the original discussion.
I think this is as simple as just omitting the " updated" from the end of the subject line so it remains the same as in the regular discussion. It's not adding much...
Related branches
lp:~mbp/launchpad/436294-review-mails
- Michael Hudson-Doyle: Approve
-
Diff: 36 lines (+4/-4)2 files modifiedlib/lp/code/mail/branchmergeproposal.py (+3/-3)
lib/lp/code/mail/tests/test_branchmergeproposal.py (+1/-1)
summary: |
- mp merged emails appear in a separate thread from the review + mp status change emails appear in a separate thread from the review |
tags: | added: code-review email |
Changed in launchpad-code: | |
assignee: | nobody → Martin Pool (mbp) |
status: | Triaged → In Progress |
Changed in launchpad-code: | |
status: | In Progress → Fix Committed |
Changed in launchpad-code: | |
milestone: | none → 10.02 |
Changed in launchpad-code: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
We are correctly setting the In-Reply-To header. It would be nice if Gmail would respect that. Nevertheless, we can look at making Gmail happy.