Missing hub context user commands

[dairinin]

Hello, guys.

I'm trying to launch ADC hub atm, and found a problem with hubmenu items not being installed, when their context is 1. So there is an example. This command from hub does not create menu item:
ICMD Commands\\Hub\\Userlist\\all TTBMSG\s%[mySID]\s+userlist CT1

And this does:
ICMD Commands\\Userinfo TTBMSG\s%[mySID]\s+userinfo\ssid\s%[userSID] CT2

[Steven Sheehy (steven-sheehy)]

Context 2 means it should show up in chat right click user menu item. Context 1 is hub context and should only show up in hub tab right click menu at the top of the screen. However, the latter is not implemented and I'm not sure it will ever be implemented because it seems pretty pointless. Based on your command you need the parameters to be replaced with user data so you probably only want it shown in chat menu (context 2).

[dairinin (nowhere-hakkenden)]

Steven, thanks for the reply

I always thought, that context means parameter substitusion, so the first command is definetely a hub-level command. According to ADC 1.0 spec, mySID is available in hub context, and no other data is required - hence it IS context 1, IMHO.
Well, afaik NMDC also provides contexts for commands, and they are always show up in userlist right-click menu, and this is expected behavior. Maybe with ADC client should also place all commands in userlist menu?

[Steven Sheehy (steven-sheehy)]

The context is where the command is supposed to appear in the UI and as a result this affects what parameters are available for substitution. First command could in theory be either hub or chat since mySID is available for all contexts (technically speaking, logically the command may not make sense in chat). The second could only be chat since userSID would not be available for hub context.

Parameter substitution is not done when the command is received from the hub, it is done at the time the user right clicks and the menu is prepared. Thus, the core doesn't care what context is received from the hub for a command, it simply adds it to its list and makes it available to the UI. It's only when the UI requests the list of commands does the context matter. You request commands from the core by passing in a desired context and the core retrieves only what commands have that context. If you request context 1, it will only show up in hub menu (though this again not implemented). If you request context 2 it will show up in the user list right click menu. If you request context 3 it will show up in both user list and hub menu since 3 equals 1 OR 2 in binary.

[Steven Sheehy (steven-sheehy)]

What is the status of this bug? Can it be closed or did my explanation not make sense?

[dairinin (nowhere-hakkenden)]

Your explanation is clear. What about the idea to include hub-context commands into userlist menu, as with nmdc?

[Steven Sheehy (steven-sheehy)]

You're saying instead of placing hub context commands on right click tab popup, to place them in userlist popup along with chat context? How would you separate the two? Currently chat context is in "User commands" sub-menu.

[dairinin (nowhere-hakkenden)]

Please, ignore my last message. Although it's a pity that program does not fully conforms to ADC specs, the idea to place hub-context into user-context is a total mess. Sorry for troubles, the bug should be closed.

[Steven Sheehy (steven-sheehy)]

We probably need to add hub context user commands somewhere. Not in the user list menu, but somewhere else is probably okay.